Re: [PATCH v2] binman: Fix SyntaxWarning: invalid escape sequence '\('

2023-09-23 Thread Simon Glass 
On 9/11/23 6:36 AM, Simon Glass wrote:
> Hi,
>
> On Tue, 5 Sept 2023 at 19:34, 荣涛  wrote:
>> Thanks, Simon
>>
>> The following lines is my systeme ENV and make log
>>
>> $ cat /etc/os-release
>> NAME="Fedora Linux"
>> VERSION="40 (Workstation Edition Prerelease)"
>> ID=fedora
>> VERSION_ID=40
>> VERSION_CODENAME=""
>> PLATFORM_ID="platform:f40"
>> PRETTY_NAME="Fedora Linux 40 (Workstation Edition Prerelease)"
>> ANSI_COLOR="0;38;2;60;110;180"
>> LOGO=fedora-logo-icon
>> CPE_NAME="cpe:/o:fedoraproject:fedora:40"
>> DEFAULT_HOSTNAME="fedora"
>> HOME_URL="https://fedoraproject.org/;
>> DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/;
>> SUPPORT_URL="https://ask.fedoraproject.org/;
>> BUG_REPORT_URL="https://bugzilla.redhat.com/;
>> REDHAT_BUGZILLA_PRODUCT="Fedora"
>> REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
>> REDHAT_SUPPORT_PRODUCT="Fedora"
>> REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
>> SUPPORT_END=2024-05-14
>> VARIANT="Workstation Edition"
>> VARIANT_ID=workstation
>>
>> $ uname -r
>> 6.6.0-0.rc0.20230901git99d99825fc07.3.fc40.x86_64
>>
>> $ gcc --version
>> gcc (GCC) 13.2.1 20230728 (Red Hat 13.2.1-1)
>> Copyright (C) 2023 Free Software Foundation, Inc.
>> This is free software; see the source for copying conditions.  There is NO
>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>>
>> $ make qemu-x86_64_defconfig
>>HOSTCC  scripts/basic/fixdep
>>HOSTCC  scripts/kconfig/conf.o
>>YACCscripts/kconfig/zconf.tab.c
>>LEX scripts/kconfig/zconf.lex.c
>>HOSTCC  scripts/kconfig/zconf.tab.o
>>HOSTLD  scripts/kconfig/conf
>> #
>> # configuration written to .config
>> #
>>
>> $ make -j8
>> ... [too much logs]
>>SYM spl/u-boot-spl.sym
>>OBJCOPY spl/u-boot-x86-start16-spl.bin
>>OBJCOPY spl/u-boot-x86-reset16-spl.bin
>>CAT spl/u-boot-spl-dtb.bin
>>COPYspl/u-boot-spl.bin
>>BINMAN  .binman_stamp
>> /home/sda/git-repos/u-boot/tools/binman/etype/section.py:25: SyntaxWarning: 
>> invalid escape sequence '\('
>>"""Entry that contains other entries
>>OFCHK   .config
>>
> Thanks for that. What is your Python version?

Thanks Simon

$ python --version
Python 3.12.0rc1

>
> Regards,
> Simon


Applied to u-boot-dm, thanks!

Re: [PATCH v2] binman: Fix SyntaxWarning: invalid escape sequence '\('

2023-09-10 Thread Rong Tao 

On 9/11/23 6:36 AM, Simon Glass wrote:

Hi,

On Tue, 5 Sept 2023 at 19:34, 荣涛  wrote:

Thanks, Simon

The following lines is my systeme ENV and make log

$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="40 (Workstation Edition Prerelease)"
ID=fedora
VERSION_ID=40
VERSION_CODENAME=""
PLATFORM_ID="platform:f40"
PRETTY_NAME="Fedora Linux 40 (Workstation Edition Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:40"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/;
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/;
SUPPORT_URL="https://ask.fedoraproject.org/;
BUG_REPORT_URL="https://bugzilla.redhat.com/;
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
SUPPORT_END=2024-05-14
VARIANT="Workstation Edition"
VARIANT_ID=workstation

$ uname -r
6.6.0-0.rc0.20230901git99d99825fc07.3.fc40.x86_64

$ gcc --version
gcc (GCC) 13.2.1 20230728 (Red Hat 13.2.1-1)
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ make qemu-x86_64_defconfig
   HOSTCC  scripts/basic/fixdep
   HOSTCC  scripts/kconfig/conf.o
   YACCscripts/kconfig/zconf.tab.c
   LEX scripts/kconfig/zconf.lex.c
   HOSTCC  scripts/kconfig/zconf.tab.o
   HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#

$ make -j8
... [too much logs]
   SYM spl/u-boot-spl.sym
   OBJCOPY spl/u-boot-x86-start16-spl.bin
   OBJCOPY spl/u-boot-x86-reset16-spl.bin
   CAT spl/u-boot-spl-dtb.bin
   COPYspl/u-boot-spl.bin
   BINMAN  .binman_stamp
/home/sda/git-repos/u-boot/tools/binman/etype/section.py:25: SyntaxWarning: 
invalid escape sequence '\('
   """Entry that contains other entries
   OFCHK   .config


Thanks for that. What is your Python version?


Thanks Simon

$ python --version
Python 3.12.0rc1



Regards,
Simon

Re: [PATCH v2] binman: Fix SyntaxWarning: invalid escape sequence '\('

2023-09-10 Thread Simon Glass 
Hi,

On Tue, 5 Sept 2023 at 19:34, 荣涛  wrote:
>
> Thanks, Simon
>
> The following lines is my systeme ENV and make log
>
> $ cat /etc/os-release
> NAME="Fedora Linux"
> VERSION="40 (Workstation Edition Prerelease)"
> ID=fedora
> VERSION_ID=40
> VERSION_CODENAME=""
> PLATFORM_ID="platform:f40"
> PRETTY_NAME="Fedora Linux 40 (Workstation Edition Prerelease)"
> ANSI_COLOR="0;38;2;60;110;180"
> LOGO=fedora-logo-icon
> CPE_NAME="cpe:/o:fedoraproject:fedora:40"
> DEFAULT_HOSTNAME="fedora"
> HOME_URL="https://fedoraproject.org/;
> DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/;
> SUPPORT_URL="https://ask.fedoraproject.org/;
> BUG_REPORT_URL="https://bugzilla.redhat.com/;
> REDHAT_BUGZILLA_PRODUCT="Fedora"
> REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
> REDHAT_SUPPORT_PRODUCT="Fedora"
> REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
> SUPPORT_END=2024-05-14
> VARIANT="Workstation Edition"
> VARIANT_ID=workstation
>
> $ uname -r
> 6.6.0-0.rc0.20230901git99d99825fc07.3.fc40.x86_64
>
> $ gcc --version
> gcc (GCC) 13.2.1 20230728 (Red Hat 13.2.1-1)
> Copyright (C) 2023 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> $ make qemu-x86_64_defconfig
>   HOSTCC  scripts/basic/fixdep
>   HOSTCC  scripts/kconfig/conf.o
>   YACCscripts/kconfig/zconf.tab.c
>   LEX scripts/kconfig/zconf.lex.c
>   HOSTCC  scripts/kconfig/zconf.tab.o
>   HOSTLD  scripts/kconfig/conf
> #
> # configuration written to .config
> #
>
> $ make -j8
> ... [too much logs]
>   SYM spl/u-boot-spl.sym
>   OBJCOPY spl/u-boot-x86-start16-spl.bin
>   OBJCOPY spl/u-boot-x86-reset16-spl.bin
>   CAT spl/u-boot-spl-dtb.bin
>   COPYspl/u-boot-spl.bin
>   BINMAN  .binman_stamp
> /home/sda/git-repos/u-boot/tools/binman/etype/section.py:25: SyntaxWarning: 
> invalid escape sequence '\('
>   """Entry that contains other entries
>   OFCHK   .config
>

Thanks for that. What is your Python version?

Regards,
Simon

Re: [PATCH v2] binman: Fix SyntaxWarning: invalid escape sequence '\('

2023-09-05 Thread ???? 
Thanks, Simon


The following lines is my systeme ENV and make log


$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="40 (Workstation Edition Prerelease)"
ID=fedora
VERSION_ID=40
VERSION_CODENAME=""
PLATFORM_ID="platform:f40"
PRETTY_NAME="Fedora Linux 40 (Workstation Edition Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:40"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/;
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/;
SUPPORT_URL="https://ask.fedoraproject.org/;
BUG_REPORT_URL="https://bugzilla.redhat.com/;
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
SUPPORT_END=2024-05-14
VARIANT="Workstation Edition"
VARIANT_ID=workstation



$ uname -r
6.6.0-0.rc0.20230901git99d99825fc07.3.fc40.x86_64



$ gcc --version
gcc (GCC) 13.2.1 20230728 (Red Hat 13.2.1-1)
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.



$ make qemu-x86_64_defconfig
 HOSTCC scripts/basic/fixdep
 HOSTCC scripts/kconfig/conf.o
 YACC  scripts/kconfig/zconf.tab.c
 LEX  scripts/kconfig/zconf.lex.c
 HOSTCC scripts/kconfig/zconf.tab.o
 HOSTLD scripts/kconfig/conf
#
# configuration written to .config
#



$ make -j8
... [too much logs]
 SYM  spl/u-boot-spl.sym
 OBJCOPY spl/u-boot-x86-start16-spl.bin
 OBJCOPY spl/u-boot-x86-reset16-spl.bin
 CAT  spl/u-boot-spl-dtb.bin
 COPY  spl/u-boot-spl.bin
 BINMAN .binman_stamp
/home/sda/git-repos/u-boot/tools/binman/etype/section.py:25: SyntaxWarning: 
invalid escape sequence '\('
 """Entry that contains other entries
 OFCHK .config

[PATCH v2] binman: Fix SyntaxWarning: invalid escape sequence '\('

2023-09-05 Thread Rong Tao 
From: Rong Tao 

Reproduct warning:

$ git clean -dfx
$ make CROSS_COMPILE="" qemu-x86_64_defconfig
$ make -j8
...
u-boot/tools/binman/etype/section.py:25:
SyntaxWarning: invalid escape sequence '\('
"""Entry that contains other entries

Signed-off-by: Rong Tao 
---
 tools/binman/etype/section.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
index fb49e85a7634..30c1041c7e8d 100644
--- a/tools/binman/etype/section.py
+++ b/tools/binman/etype/section.py
@@ -40,7 +40,7 @@ class Entry_section(Entry):
 For example code, see etypes which subclass `Entry_section`, or `cbfs.py`
 for a more involved example::
 
-   $ grep -l \(Entry_section tools/binman/etype/*.py
+   $ grep -l \\(Entry_section tools/binman/etype/*.py
 
 ReadNode()
 Call `super().ReadNode()`, then read any special properties for the
-- 
2.41.0

Re: [PATCH v2] binman: Fix SyntaxWarning: invalid escape sequence '\('

2023-09-05 Thread Simon Glass 
Hi Rong,

On Tue, 5 Sept 2023 at 05:47, Rong Tao  wrote:
>
> From: Rong Tao 
>
> Reproduct warning:
>
> $ git clean -dfx
> $ make CROSS_COMPILE="" qemu-x86_64_defconfig
> $ make -j8

I cannot repro that...what toolchain are you using? Could you send the full
build log?

> ...
> u-boot/tools/binman/etype/section.py:25:
> SyntaxWarning: invalid escape sequence '\('
> """Entry that contains other entries
>
> Signed-off-by: Rong Tao 
> ---
>  tools/binman/etype/section.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
> index fb49e85a7634..30c1041c7e8d 100644
> --- a/tools/binman/etype/section.py
> +++ b/tools/binman/etype/section.py
> @@ -40,7 +40,7 @@ class Entry_section(Entry):
>  For example code, see etypes which subclass `Entry_section`, or
`cbfs.py`
>  for a more involved example::
>
> -   $ grep -l \(Entry_section tools/binman/etype/*.py
> +   $ grep -l \\(Entry_section tools/binman/etype/*.py
>
>  ReadNode()
>  Call `super().ReadNode()`, then read any special properties for
the
> --
> 2.41.0
>

Reviewed-by: Simon Glass 

Regards,
Simon