Re: [PATCH v2] cmd: fdt: skip board specific fixup using env variable

2021-02-25 Thread Tom Rini
On Thu, Feb 04, 2021 at 03:44:04PM +0100, Wasim Khan wrote:

> From: Wasim Khan 
> 
> Sometimes it is useful to boot OS with already fixed-up
> device tree. Check for env variable 'skip_board_fixup'
> before calling ft_board_setup().
> Current behaviour is unchanged, additionally user can
> set skip_board_fixup to 1 to skip the fixup.
> 
> Signed-off-by: Wasim Khan 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature


[PATCH v2] cmd: fdt: skip board specific fixup using env variable

2021-02-04 Thread Wasim Khan
From: Wasim Khan 

Sometimes it is useful to boot OS with already fixed-up
device tree. Check for env variable 'skip_board_fixup'
before calling ft_board_setup().
Current behaviour is unchanged, additionally user can
set skip_board_fixup to 1 to skip the fixup.

Signed-off-by: Wasim Khan 
---
Changes in v2:
- Added check for skip_board_fixup in checkpatch.pl

 common/image-fdt.c| 17 -
 scripts/checkpatch.pl |  6 ++
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/common/image-fdt.c b/common/image-fdt.c
index 327a8c4c39..0435176863 100644
--- a/common/image-fdt.c
+++ b/common/image-fdt.c
@@ -572,11 +572,18 @@ int image_setup_libfdt(bootm_headers_t *images, void 
*blob,
fdt_fixup_pstore(blob);
 #endif
if (IMAGE_OF_BOARD_SETUP) {
-   fdt_ret = ft_board_setup(blob, gd->bd);
-   if (fdt_ret) {
-   printf("ERROR: board-specific fdt fixup failed: %s\n",
-  fdt_strerror(fdt_ret));
-   goto err;
+   const char *skip_board_fixup;
+
+   skip_board_fixup = env_get("skip_board_fixup");
+   if (skip_board_fixup && ((int)simple_strtol(skip_board_fixup, 
NULL, 10) == 1)) {
+   printf("skip board fdt fixup\n");
+   } else {
+   fdt_ret = ft_board_setup(blob, gd->bd);
+   if (fdt_ret) {
+   printf("ERROR: board-specific fdt fixup failed: 
%s\n",
+  fdt_strerror(fdt_ret));
+   goto err;
+   }
}
}
if (IMAGE_OF_SYSTEM_SETUP) {
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4ed7e124c9..7b76894fb4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2366,6 +2366,12 @@ sub u_boot_line {
 "fdt or initrd relocation disabled at boot time\n" . 
$herecurr);
}
 
+   # make sure 'skip_board_fixup' is not
+   if ($rawline =~ /.*skip_board_fixup.*/) {
+   ERROR("SKIP_BOARD_FIXUP",
+"Avoid setting skip_board_fixup env variable\n" . 
$herecurr);
+   }
+
# Do not use CONFIG_ prefix in CONFIG_IS_ENABLED() calls
if ($line =~ /^\+.*CONFIG_IS_ENABLED\(CONFIG_\w*\).*/) {
ERROR("CONFIG_IS_ENABLED_CONFIG",
-- 
2.25.1