Re: [PATCH v2 0/3] Implement GPIO cells for PALMAS and MAX77663 PMICs

2023-11-06 Thread Svyatoslav Ryhel
пн, 6 лист. 2023 р. о 14:00 Peter Robinson  пише:
>
> On Mon, Nov 6, 2023 at 10:18 AM Svyatoslav Ryhel  wrote:
> >
> > This patchset adds support for gpio-uclass to work with pmic gpio childrens
> > properly and implements MAX77663 and PALMAS GPIO cells/children as a
> > reference and to be further used in devices I am currently maintaining.
> >
> > All drivers are tested on actual hardware and confirmed to work as
> > expected. MAX77663 GPIO cell is tested on wexler qc750 tegra 3 device
>
> Is the MAX77663 seems more related to the MAX77686 PMIC, why is it
> being done as s a GPIO and not a PMIC driver or the existing driver
> extended to support this chip?
>

This patchset brings support for MAX77663 PMIC GPIO cell support of
existing PMIC driver, it has nothing to do with MAX77686.

> > and PALMAS GPIO cell is tested on tegra note 7 tegra 4 device.
> >
> > ---
> > Changes from v1:
> >  - isolate PMIC GPIO cells parsing behind enabling DM_PMIC
> > ---
> >
> > Svyatoslav Ryhel (3):
> >   drivers: gpio-uclass: support PMIC GPIO children
> >   drivers: gpio: implement MAX77663 GPIO cell
> >   drivers: gpio: implement PALMAS GPIO cell
> >
> >  drivers/gpio/Kconfig|  16 +++
> >  drivers/gpio/Makefile   |   2 +
> >  drivers/gpio/gpio-uclass.c  |  19 +++
> >  drivers/gpio/max77663_gpio.c| 178 
> >  drivers/gpio/palmas_gpio.c  | 132 +
> >  drivers/power/pmic/max77663.c   |   9 ++
> >  drivers/power/pmic/palmas.c |  10 +-
> >  include/dt-bindings/pmic/max77663.h |  18 +++
> >  include/power/max77663.h|   1 +
> >  include/power/palmas.h  |  12 ++
> >  10 files changed, 396 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/gpio/max77663_gpio.c
> >  create mode 100644 drivers/gpio/palmas_gpio.c
> >  create mode 100644 include/dt-bindings/pmic/max77663.h
> >
> > --
> > 2.40.1
> >


Re: [PATCH v2 0/3] Implement GPIO cells for PALMAS and MAX77663 PMICs

2023-11-06 Thread Peter Robinson
On Mon, Nov 6, 2023 at 10:18 AM Svyatoslav Ryhel  wrote:
>
> This patchset adds support for gpio-uclass to work with pmic gpio childrens
> properly and implements MAX77663 and PALMAS GPIO cells/children as a
> reference and to be further used in devices I am currently maintaining.
>
> All drivers are tested on actual hardware and confirmed to work as
> expected. MAX77663 GPIO cell is tested on wexler qc750 tegra 3 device

Is the MAX77663 seems more related to the MAX77686 PMIC, why is it
being done as s a GPIO and not a PMIC driver or the existing driver
extended to support this chip?

> and PALMAS GPIO cell is tested on tegra note 7 tegra 4 device.
>
> ---
> Changes from v1:
>  - isolate PMIC GPIO cells parsing behind enabling DM_PMIC
> ---
>
> Svyatoslav Ryhel (3):
>   drivers: gpio-uclass: support PMIC GPIO children
>   drivers: gpio: implement MAX77663 GPIO cell
>   drivers: gpio: implement PALMAS GPIO cell
>
>  drivers/gpio/Kconfig|  16 +++
>  drivers/gpio/Makefile   |   2 +
>  drivers/gpio/gpio-uclass.c  |  19 +++
>  drivers/gpio/max77663_gpio.c| 178 
>  drivers/gpio/palmas_gpio.c  | 132 +
>  drivers/power/pmic/max77663.c   |   9 ++
>  drivers/power/pmic/palmas.c |  10 +-
>  include/dt-bindings/pmic/max77663.h |  18 +++
>  include/power/max77663.h|   1 +
>  include/power/palmas.h  |  12 ++
>  10 files changed, 396 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/gpio/max77663_gpio.c
>  create mode 100644 drivers/gpio/palmas_gpio.c
>  create mode 100644 include/dt-bindings/pmic/max77663.h
>
> --
> 2.40.1
>


[PATCH v2 0/3] Implement GPIO cells for PALMAS and MAX77663 PMICs

2023-11-06 Thread Svyatoslav Ryhel
This patchset adds support for gpio-uclass to work with pmic gpio childrens
properly and implements MAX77663 and PALMAS GPIO cells/children as a 
reference and to be further used in devices I am currently maintaining.

All drivers are tested on actual hardware and confirmed to work as
expected. MAX77663 GPIO cell is tested on wexler qc750 tegra 3 device
and PALMAS GPIO cell is tested on tegra note 7 tegra 4 device.

---
Changes from v1:
 - isolate PMIC GPIO cells parsing behind enabling DM_PMIC
---

Svyatoslav Ryhel (3):
  drivers: gpio-uclass: support PMIC GPIO children
  drivers: gpio: implement MAX77663 GPIO cell
  drivers: gpio: implement PALMAS GPIO cell

 drivers/gpio/Kconfig|  16 +++
 drivers/gpio/Makefile   |   2 +
 drivers/gpio/gpio-uclass.c  |  19 +++
 drivers/gpio/max77663_gpio.c| 178 
 drivers/gpio/palmas_gpio.c  | 132 +
 drivers/power/pmic/max77663.c   |   9 ++
 drivers/power/pmic/palmas.c |  10 +-
 include/dt-bindings/pmic/max77663.h |  18 +++
 include/power/max77663.h|   1 +
 include/power/palmas.h  |  12 ++
 10 files changed, 396 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpio/max77663_gpio.c
 create mode 100644 drivers/gpio/palmas_gpio.c
 create mode 100644 include/dt-bindings/pmic/max77663.h

-- 
2.40.1