Re: [PATCH v2 03/17] dm: core: Change syscon to use helper function

[Bin Meng]

On Tue, Feb 4, 2020 at 8:20 AM Simon Glass  wrote:
>
> Now that we have uclass_first_device_drvdata(), use it from syscon to
> reduce code duplication.
>
> Signed-off-by: Simon Glass 
> ---
>
> Changes in v2:
> - Add new patch to change syscon to use helper function
>
>  drivers/core/syscon-uclass.c | 15 ---
>  1 file changed, 4 insertions(+), 11 deletions(-)
>

Reviewed-by: Bin Meng 

[PATCH v2 03/17] dm: core: Change syscon to use helper function

[Simon Glass]

Now that we have uclass_first_device_drvdata(), use it from syscon to
reduce code duplication.

Signed-off-by: Simon Glass 
---

Changes in v2:
- Add new patch to change syscon to use helper function

 drivers/core/syscon-uclass.c | 15 ---
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/core/syscon-uclass.c b/drivers/core/syscon-uclass.c
index 5bb38e329c..b9ae82174e 100644
--- a/drivers/core/syscon-uclass.c
+++ b/drivers/core/syscon-uclass.c
@@ -128,22 +128,15 @@ struct regmap *syscon_regmap_lookup_by_phandle(struct 
udevice *dev,
 
 int syscon_get_by_driver_data(ulong driver_data, struct udevice **devp)
 {
-   struct udevice *dev;
-   struct uclass *uc;
int ret;
 
*devp = NULL;
-   ret = uclass_get(UCLASS_SYSCON, &uc);
+
+   ret = uclass_first_device_drvdata(UCLASS_SYSCON, driver_data, devp);
if (ret)
-   return ret;
-   uclass_foreach_dev(dev, uc) {
-   if (dev->driver_data == driver_data) {
-   *devp = dev;
-   return device_probe(dev);
-   }
-   }
+   return log_msg_ret("find", ret);
 
-   return -ENODEV;
+   return 0;
 }
 
 struct regmap *syscon_get_regmap_by_driver_data(ulong driver_data)
-- 
2.25.0.341.g760bfbb309-goog