Re: [PATCH v2 04/17] tegra: i2c: Change driver to use helper function

[Bin Meng]

On Tue, Feb 4, 2020 at 8:20 AM Simon Glass  wrote:
>
> Now that we have uclass_first_device_drvdata(), use it from the I2C driver
> to reduce code duplication.
>
> Signed-off-by: Simon Glass 
> ---
>
> Changes in v2:
> - Add new patch to change tegra driver to use helper function
>
>  drivers/i2c/tegra_i2c.c | 13 +
>  1 file changed, 1 insertion(+), 12 deletions(-)
>

Reviewed-by: Bin Meng 

Re: [PATCH v2 04/17] tegra: i2c: Change driver to use helper function

[Heiko Schocher]

Hello Simon,

Am 04.02.2020 um 01:19 schrieb Simon Glass:

Now that we have uclass_first_device_drvdata(), use it from the I2C driver
to reduce code duplication.

Signed-off-by: Simon Glass 
---

Changes in v2:
- Add new patch to change tegra driver to use helper function

  drivers/i2c/tegra_i2c.c | 13 +
  1 file changed, 1 insertion(+), 12 deletions(-)


Reviewed-by: Heiko Schocher 

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de

[PATCH v2 04/17] tegra: i2c: Change driver to use helper function

[Simon Glass]

Now that we have uclass_first_device_drvdata(), use it from the I2C driver
to reduce code duplication.

Signed-off-by: Simon Glass 
---

Changes in v2:
- Add new patch to change tegra driver to use helper function

 drivers/i2c/tegra_i2c.c | 13 +
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/i2c/tegra_i2c.c b/drivers/i2c/tegra_i2c.c
index 4be41ddbf0..142463ef44 100644
--- a/drivers/i2c/tegra_i2c.c
+++ b/drivers/i2c/tegra_i2c.c
@@ -499,18 +499,7 @@ static int tegra_i2c_xfer(struct udevice *bus, struct 
i2c_msg *msg,
 
 int tegra_i2c_get_dvc_bus(struct udevice **busp)
 {
-   struct udevice *bus;
-
-   for (uclass_first_device(UCLASS_I2C, &bus);
-bus;
-uclass_next_device(&bus)) {
-   if (dev_get_driver_data(bus) == TYPE_DVC) {
-   *busp = bus;
-   return 0;
-   }
-   }
-
-   return -ENODEV;
+   return uclass_first_device_drvdata(UCLASS_I2C, TYPE_DVC, busp);
 }
 
 static const struct dm_i2c_ops tegra_i2c_ops = {
-- 
2.25.0.341.g760bfbb309-goog