Re: [PATCH v2 1/2] Kconfig: add btrfs to distro boot

2020-01-15 Thread Matthias Brugger



On 15/01/2020 17:07, Adam Ford wrote:
> On Wed, Jan 15, 2020 at 9:55 AM  wrote:
>>
>> From: Matthias Brugger 
>>
>> Some distributions use btrfs as the default file system.
>> Enable btrfs support by default when using distro boot for all
>> architectures but riscv, as it breaks compilation due to size problems.
>>
>> Signed-off-by: Matthias Brugger 
>>
>> ---
>>
>> Changes in v2:
>> - disable default btrfs support riscv
>>
>>  Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Kconfig b/Kconfig
>> index 99cc56f3c2..f0abf91e99 100644
>> --- a/Kconfig
>> +++ b/Kconfig
>> @@ -79,6 +79,7 @@ config DISTRO_DEFAULTS
>> select CMDLINE_EDITING
>> select CMD_BOOTI if ARM64
>> select CMD_BOOTZ if ARM && !ARM64
>> +   select CMD_BTRFS if !RISCV
> 
> Any chance this could be done with 'imply' instead of 'select' to give
> people the ability to turn it off if they want?
> 

Sounds reasonable. I'll change that in v3.

Thanks for the feedback!

Matthias


Re: [PATCH v2 1/2] Kconfig: add btrfs to distro boot

2020-01-15 Thread Adam Ford
On Wed, Jan 15, 2020 at 9:55 AM  wrote:
>
> From: Matthias Brugger 
>
> Some distributions use btrfs as the default file system.
> Enable btrfs support by default when using distro boot for all
> architectures but riscv, as it breaks compilation due to size problems.
>
> Signed-off-by: Matthias Brugger 
>
> ---
>
> Changes in v2:
> - disable default btrfs support riscv
>
>  Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Kconfig b/Kconfig
> index 99cc56f3c2..f0abf91e99 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -79,6 +79,7 @@ config DISTRO_DEFAULTS
> select CMDLINE_EDITING
> select CMD_BOOTI if ARM64
> select CMD_BOOTZ if ARM && !ARM64
> +   select CMD_BTRFS if !RISCV

Any chance this could be done with 'imply' instead of 'select' to give
people the ability to turn it off if they want?

> select CMD_DHCP if CMD_NET
> select CMD_ENV_EXISTS
> select CMD_EXT2
> --

adam

> 2.24.0
>


[PATCH v2 1/2] Kconfig: add btrfs to distro boot

2020-01-15 Thread matthias . bgg
From: Matthias Brugger 

Some distributions use btrfs as the default file system.
Enable btrfs support by default when using distro boot for all
architectures but riscv, as it breaks compilation due to size problems.

Signed-off-by: Matthias Brugger 

---

Changes in v2:
- disable default btrfs support riscv

 Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Kconfig b/Kconfig
index 99cc56f3c2..f0abf91e99 100644
--- a/Kconfig
+++ b/Kconfig
@@ -79,6 +79,7 @@ config DISTRO_DEFAULTS
select CMDLINE_EDITING
select CMD_BOOTI if ARM64
select CMD_BOOTZ if ARM && !ARM64
+   select CMD_BTRFS if !RISCV
select CMD_DHCP if CMD_NET
select CMD_ENV_EXISTS
select CMD_EXT2
-- 
2.24.0