Re: [PATCH v2 1/2] arm: page align EFI binary section

[Ilias Apalodimas]

On Mon, 26 Feb 2024 at 23:24, Heinrich Schuchardt
 wrote:
>
> Change the alignment of the relocation code in EFI binaries to match page
> boundaries.
>
> Signed-off-by: Heinrich Schuchardt 
> ---
> v2:
> new patch
> ---
>  arch/arm/lib/crt0_arm_efi.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/lib/crt0_arm_efi.S b/arch/arm/lib/crt0_arm_efi.S
> index 75ee37b7d3..7a4e5dff75 100644
> --- a/arch/arm/lib/crt0_arm_efi.S
> +++ b/arch/arm/lib/crt0_arm_efi.S
> @@ -115,14 +115,14 @@ section_table:
> .short  0   /* NumberOfLineNumbers  (0 for executables) */
> .long   0xe0500020  /* Characteristics (section flags) */
>
> -   .align  9
> +   .align  12
>  _start:
> stmfd   sp!, {r0-r2, lr}
>
> adr r1, .L_DYNAMIC
> ldr r0, [r1]
> add r1, r0, r1
> -   adr r0, image_base
> +   adrlr0, image_base
> bl  _relocate
> teq r0, #0
> bne 0f
> --
> 2.43.0
>

Reviewed-by: Ilias Apalodimas 

[PATCH v2 1/2] arm: page align EFI binary section

[Heinrich Schuchardt]

Change the alignment of the relocation code in EFI binaries to match page
boundaries.

Signed-off-by: Heinrich Schuchardt 
---
v2:
new patch
---
 arch/arm/lib/crt0_arm_efi.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/lib/crt0_arm_efi.S b/arch/arm/lib/crt0_arm_efi.S
index 75ee37b7d3..7a4e5dff75 100644
--- a/arch/arm/lib/crt0_arm_efi.S
+++ b/arch/arm/lib/crt0_arm_efi.S
@@ -115,14 +115,14 @@ section_table:
.short  0   /* NumberOfLineNumbers  (0 for executables) */
.long   0xe0500020  /* Characteristics (section flags) */
 
-   .align  9
+   .align  12
 _start:
stmfd   sp!, {r0-r2, lr}
 
adr r1, .L_DYNAMIC
ldr r0, [r1]
add r1, r0, r1
-   adr r0, image_base
+   adrlr0, image_base
bl  _relocate
teq r0, #0
bne 0f
-- 
2.43.0