Re: [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type

2022-03-14 Thread Bin Meng
On Sun, Mar 13, 2022 at 2:03 PM Simon Glass  wrote:
>
> This enum is currently anonymous. Add a name so it can be used in the
> code.
>
> Signed-off-by: Simon Glass 
> Reviewed-by: Bin Meng 
> ---
>
> Changes in v2:
> - Add some comments for the enum
>
>  arch/x86/include/asm/intel_gnvs.h | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>

applied to u-boot-x86, thanks!


[PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type

2022-03-12 Thread Simon Glass
This enum is currently anonymous. Add a name so it can be used in the
code.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng 
---

Changes in v2:
- Add some comments for the enum

 arch/x86/include/asm/intel_gnvs.h | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/intel_gnvs.h 
b/arch/x86/include/asm/intel_gnvs.h
index fc743dc9285..0b69530edbf 100644
--- a/arch/x86/include/asm/intel_gnvs.h
+++ b/arch/x86/include/asm/intel_gnvs.h
@@ -47,7 +47,13 @@ enum {
BINF_RW_B = 2
 };
 
-enum {
+/**
+ * enum cros_fw_type_t - Used to indicate Chromium OS firmware type
+ *
+ * Chromium OS uses a region of the GNVS starting at offset 0x100 to store
+ * various bits of information, including the type of firmware being booted
+ */
+enum cros_fw_type_t {
FIRMWARE_TYPE_AUTO_DETECT = -1,
FIRMWARE_TYPE_RECOVERY = 0,
FIRMWARE_TYPE_NORMAL = 1,
-- 
2.35.1.723.g4982287a31-goog