Re: [PATCH v2 16/18] dm: Use access methods for dev/uclass private data

2020-12-28 Thread Simon Glass
Most drivers use these access methods but a few do not. Update them.

In some cases the access is not permitted, so mark those with a FIXME tag
for the maintainer to check.

Signed-off-by: Simon Glass 
Acked-by: Andy Shevchenko 
Acked-by: Pratyush Yadav 
---

(no changes since v1)

 arch/arm/cpu/armv7/ls102xa/fdt.c  |  4 ++
 arch/arm/mach-stm32mp/pwr_regulator.c |  3 +-
 arch/x86/cpu/apollolake/uart.c|  3 +-
 arch/x86/cpu/slimbootloader/serial.c  |  2 +-
 drivers/clk/clk.c |  4 +-
 drivers/clk/clk_fixed_rate.c  |  4 +-
 drivers/clk/rockchip/clk_px30.c   |  3 +-
 drivers/clk/rockchip/clk_rk3036.c |  3 +-
 drivers/clk/rockchip/clk_rk3128.c |  3 +-
 drivers/clk/rockchip/clk_rk3188.c |  2 +-
 drivers/clk/rockchip/clk_rk322x.c |  3 +-
 drivers/clk/rockchip/clk_rk3288.c |  2 +-
 drivers/clk/rockchip/clk_rk3308.c |  3 +-
 drivers/clk/rockchip/clk_rk3328.c |  3 +-
 drivers/clk/rockchip/clk_rk3368.c |  3 +-
 drivers/clk/rockchip/clk_rk3399.c |  3 +-
 drivers/clk/rockchip/clk_rv1108.c |  3 +-
 drivers/core/device-remove.c  | 16 
 drivers/ddr/altera/sdram_agilex.c |  2 +-
 drivers/ddr/altera/sdram_gen5.c   |  4 +-
 drivers/ddr/altera/sdram_s10.c|  2 +-
 drivers/ddr/altera/sdram_soc64.c  |  2 +-
 drivers/gpio/dwapb_gpio.c |  2 +-
 drivers/gpio/gpio-uclass.c|  2 +-
 drivers/gpio/hi6220_gpio.c|  2 +-
 drivers/gpio/imx_rgpio2p.c|  5 ++-
 drivers/gpio/lpc32xx_gpio.c   |  2 +-
 drivers/gpio/mt7621_gpio.c|  2 +-
 drivers/gpio/mxs_gpio.c   |  2 +-
 drivers/gpio/omap_gpio.c  |  3 +-
 drivers/gpio/s5p_gpio.c   |  6 +--
 drivers/gpio/sandbox.c|  6 ++-
 drivers/gpio/sunxi_gpio.c |  2 +-
 drivers/gpio/tegra186_gpio.c  |  6 +--
 drivers/gpio/tegra_gpio.c |  6 +--
 drivers/misc/altera_sysid.c   |  2 +-
 drivers/misc/cros_ec_sandbox.c|  4 +-
 drivers/misc/fs_loader.c  |  6 +--
 drivers/misc/vexpress_config.c|  2 +-
 drivers/mmc/arm_pl180_mmci.c  |  6 +--
 drivers/mmc/mxsmmc.c  |  2 +-
 drivers/mmc/octeontx_hsmmc.c  | 17 ++---
 drivers/mux/mmio.c|  3 +-
 drivers/net/eth-phy-uclass.c  |  4 +-
 drivers/net/fm/eth.c  | 22 +--
 drivers/net/fsl_mcdmafec.c| 10 ++---
 drivers/net/mcffec.c  | 12 +++---
 drivers/net/mcfmii.c  |  8 
 drivers/net/pfe_eth/pfe_eth.c |  2 +-
 drivers/net/sunxi_emac.c  |  2 +-
 drivers/net/tsec.c| 46 +--
 drivers/net/xilinx_emaclite.c |  2 +-
 drivers/pci/pci-emul-uclass.c |  4 +-
 drivers/pci/pci-uclass.c  |  8 ++--
 drivers/pinctrl/pinctrl-qe-io.c   |  4 +-
 drivers/pinctrl/pinctrl-single.c  |  6 +--
 drivers/power/regulator/da9063.c  | 24 ++--
 drivers/power/regulator/pbias_regulator.c |  3 +-
 drivers/remoteproc/rproc-uclass.c |  4 +-
 drivers/reset/reset-mediatek.c|  3 +-
 drivers/reset/reset-rockchip.c|  3 +-
 drivers/reset/reset-sifive.c  |  3 +-
 drivers/reset/reset-sunxi.c   |  3 +-
 drivers/serial/altera_jtag_uart.c |  8 ++--
 drivers/serial/altera_uart.c  |  8 ++--
 drivers/serial/atmel_usart.c  |  2 +-
 drivers/serial/ns16550.c  |  4 +-
 drivers/serial/sandbox.c  |  6 +--
 drivers/serial/serial_arc.c   |  8 ++--
 drivers/serial/serial_linflexuart.c   |  2 +-
 drivers/serial/serial_lpuart.c| 10 ++---
 drivers/serial/serial_mcf.c   | 10 ++---
 drivers/serial/serial_meson.c | 12 +++---
 drivers/serial/serial_mxc.c   | 12 +++---
 drivers/serial/serial_omap.c  |  2 +-
 drivers/serial/serial_pxa.c   | 10 ++---
 drivers/serial/serial_rockchip.c  |  3 +-
 drivers/serial/serial_s5p.c   | 12 +++---
 drivers/spi/cadence_qspi.c| 12 +++---
 drivers/spi/cf_spi.c  |  2 +-
 drivers/spi/davinci_spi.c |  4 +-
 drivers/spi/designware_spi.c  |  4 +-
 drivers/spi/exynos_spi.c  |  4 +-
 drivers/spi/fsl_dspi.c|  4 +-
 drivers/spi/fsl_espi.c|  2 +-
 drivers/spi/fsl_qspi.c|  2 +-
 drivers/spi/mxs_spi.c |  2 +-
 drivers/spi/pl022_spi.c   |  2 +-
 drivers/spi/rk_spi.c  |  6 +--
 drivers/spi/soft_spi.c|  4 +-
 

[PATCH v2 16/18] dm: Use access methods for dev/uclass private data

2020-12-23 Thread Simon Glass
Most drivers use these access methods but a few do not. Update them.

In some cases the access is not permitted, so mark those with a FIXME tag
for the maintainer to check.

Signed-off-by: Simon Glass 
Acked-by: Andy Shevchenko 
Acked-by: Pratyush Yadav 
---

(no changes since v1)

 arch/arm/cpu/armv7/ls102xa/fdt.c  |  4 ++
 arch/arm/mach-stm32mp/pwr_regulator.c |  3 +-
 arch/x86/cpu/apollolake/uart.c|  3 +-
 arch/x86/cpu/slimbootloader/serial.c  |  2 +-
 drivers/clk/clk.c |  4 +-
 drivers/clk/clk_fixed_rate.c  |  4 +-
 drivers/clk/rockchip/clk_px30.c   |  3 +-
 drivers/clk/rockchip/clk_rk3036.c |  3 +-
 drivers/clk/rockchip/clk_rk3128.c |  3 +-
 drivers/clk/rockchip/clk_rk3188.c |  2 +-
 drivers/clk/rockchip/clk_rk322x.c |  3 +-
 drivers/clk/rockchip/clk_rk3288.c |  2 +-
 drivers/clk/rockchip/clk_rk3308.c |  3 +-
 drivers/clk/rockchip/clk_rk3328.c |  3 +-
 drivers/clk/rockchip/clk_rk3368.c |  3 +-
 drivers/clk/rockchip/clk_rk3399.c |  3 +-
 drivers/clk/rockchip/clk_rv1108.c |  3 +-
 drivers/core/device-remove.c  | 16 
 drivers/ddr/altera/sdram_agilex.c |  2 +-
 drivers/ddr/altera/sdram_gen5.c   |  4 +-
 drivers/ddr/altera/sdram_s10.c|  2 +-
 drivers/ddr/altera/sdram_soc64.c  |  2 +-
 drivers/gpio/dwapb_gpio.c |  2 +-
 drivers/gpio/gpio-uclass.c|  2 +-
 drivers/gpio/hi6220_gpio.c|  2 +-
 drivers/gpio/imx_rgpio2p.c|  5 ++-
 drivers/gpio/lpc32xx_gpio.c   |  2 +-
 drivers/gpio/mt7621_gpio.c|  2 +-
 drivers/gpio/mxs_gpio.c   |  2 +-
 drivers/gpio/omap_gpio.c  |  3 +-
 drivers/gpio/s5p_gpio.c   |  6 +--
 drivers/gpio/sandbox.c|  6 ++-
 drivers/gpio/sunxi_gpio.c |  2 +-
 drivers/gpio/tegra186_gpio.c  |  6 +--
 drivers/gpio/tegra_gpio.c |  6 +--
 drivers/misc/altera_sysid.c   |  2 +-
 drivers/misc/cros_ec_sandbox.c|  4 +-
 drivers/misc/fs_loader.c  |  6 +--
 drivers/misc/vexpress_config.c|  2 +-
 drivers/mmc/arm_pl180_mmci.c  |  6 +--
 drivers/mmc/mxsmmc.c  |  2 +-
 drivers/mmc/octeontx_hsmmc.c  | 17 ++---
 drivers/mux/mmio.c|  3 +-
 drivers/net/eth-phy-uclass.c  |  4 +-
 drivers/net/fm/eth.c  | 22 +--
 drivers/net/fsl_mcdmafec.c| 10 ++---
 drivers/net/mcffec.c  | 12 +++---
 drivers/net/mcfmii.c  |  8 
 drivers/net/pfe_eth/pfe_eth.c |  2 +-
 drivers/net/sunxi_emac.c  |  2 +-
 drivers/net/tsec.c| 46 +--
 drivers/net/xilinx_emaclite.c |  2 +-
 drivers/pci/pci-emul-uclass.c |  4 +-
 drivers/pci/pci-uclass.c  |  8 ++--
 drivers/pinctrl/pinctrl-qe-io.c   |  4 +-
 drivers/pinctrl/pinctrl-single.c  |  6 +--
 drivers/power/regulator/da9063.c  | 24 ++--
 drivers/power/regulator/pbias_regulator.c |  3 +-
 drivers/remoteproc/rproc-uclass.c |  4 +-
 drivers/reset/reset-mediatek.c|  3 +-
 drivers/reset/reset-rockchip.c|  3 +-
 drivers/reset/reset-sifive.c  |  3 +-
 drivers/reset/reset-sunxi.c   |  3 +-
 drivers/serial/altera_jtag_uart.c |  8 ++--
 drivers/serial/altera_uart.c  |  8 ++--
 drivers/serial/atmel_usart.c  |  2 +-
 drivers/serial/ns16550.c  |  4 +-
 drivers/serial/sandbox.c  |  6 +--
 drivers/serial/serial_arc.c   |  8 ++--
 drivers/serial/serial_linflexuart.c   |  2 +-
 drivers/serial/serial_lpuart.c| 10 ++---
 drivers/serial/serial_mcf.c   | 10 ++---
 drivers/serial/serial_meson.c | 12 +++---
 drivers/serial/serial_mxc.c   | 12 +++---
 drivers/serial/serial_omap.c  |  2 +-
 drivers/serial/serial_pxa.c   | 10 ++---
 drivers/serial/serial_rockchip.c  |  3 +-
 drivers/serial/serial_s5p.c   | 12 +++---
 drivers/spi/cadence_qspi.c| 12 +++---
 drivers/spi/cf_spi.c  |  2 +-
 drivers/spi/davinci_spi.c |  4 +-
 drivers/spi/designware_spi.c  |  4 +-
 drivers/spi/exynos_spi.c  |  4 +-
 drivers/spi/fsl_dspi.c|  4 +-
 drivers/spi/fsl_espi.c|  2 +-
 drivers/spi/fsl_qspi.c|  2 +-
 drivers/spi/mxs_spi.c |  2 +-
 drivers/spi/pl022_spi.c   |  2 +-
 drivers/spi/rk_spi.c  |  6 +--
 drivers/spi/soft_spi.c|  4 +-