Re: [PATCH v2 2/3] gpio: intel_gpio: Clear tx state bit when setting output

[Bin Meng]

On Mon, Feb 3, 2020 at 6:38 PM Wolfgang Wallner
 wrote:
>
> Add missing 'PAD_CFG0_TX_STATE' to the clear mask for pcr_clrsetbits32().
> Otherwise this bit cannot be cleared again after it has been set once.
>
> Signed-off-by: Wolfgang Wallner 
> Reviewed-by: Simon Glass 
> Reviewed-by: Bin Meng 
>
> ---
>
> Changes in v2:
> - Added reviewed-by tags
>
>  drivers/gpio/intel_gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

applied to u-boot-x86, thanks!

[PATCH v2 2/3] gpio: intel_gpio: Clear tx state bit when setting output

[Wolfgang Wallner]

Add missing 'PAD_CFG0_TX_STATE' to the clear mask for pcr_clrsetbits32().
Otherwise this bit cannot be cleared again after it has been set once.

Signed-off-by: Wolfgang Wallner 
Reviewed-by: Simon Glass 
Reviewed-by: Bin Meng 

---

Changes in v2:
- Added reviewed-by tags

 drivers/gpio/intel_gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/intel_gpio.c b/drivers/gpio/intel_gpio.c
index b05cfc4aed..be91626cc5 100644
--- a/drivers/gpio/intel_gpio.c
+++ b/drivers/gpio/intel_gpio.c
@@ -41,7 +41,7 @@ static int intel_gpio_direction_output(struct udevice *dev, 
uint offset,
 
pcr_clrsetbits32(pinctrl, config_offset,
 PAD_CFG0_MODE_MASK | PAD_CFG0_RX_STATE |
- PAD_CFG0_TX_DISABLE,
+ PAD_CFG0_TX_DISABLE | PAD_CFG0_TX_STATE,
 PAD_CFG0_MODE_GPIO | PAD_CFG0_RX_DISABLE |
  (value ? PAD_CFG0_TX_STATE : 0));
 
-- 
2.25.0