Re: [PATCH v2 2/5] image: Show the load address when decompressing

2023-11-14 Thread Tom Rini
On Sat, Nov 11, 2023 at 08:49:54PM -0700, Simon Glass wrote:

> The destination address for decompression (or copying) is useful
> information. Show this to the user while booting, e.g.:
> 
>Uncompressing Kernel Image (no loading done) to 208
> 
> Signed-off-by: Simon Glass 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: PGP signature


[PATCH v2 2/5] image: Show the load address when decompressing

2023-11-11 Thread Simon Glass
The destination address for decompression (or copying) is useful
information. Show this to the user while booting, e.g.:

   Uncompressing Kernel Image (no loading done) to 208

Signed-off-by: Simon Glass 
---

(no changes since v1)

 boot/image.c | 13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/boot/image.c b/boot/image.c
index 88b67bc3a199..675b5dd77f94 100644
--- a/boot/image.c
+++ b/boot/image.c
@@ -415,15 +415,20 @@ void image_print_contents(const void *ptr)
  * @type:  OS type (IH_OS_...)
  * @comp_type: Compression type being used (IH_COMP_...)
  * @is_xip:true if the load address matches the image start
+ * @load:  Load address for printing
  */
-static void print_decomp_msg(int comp_type, int type, bool is_xip)
+static void print_decomp_msg(int comp_type, int type, bool is_xip,
+ulong load)
 {
const char *name = genimg_get_type_name(type);
 
+   /* Shows "Loading Kernel Image" for example */
if (comp_type == IH_COMP_NONE)
-   printf("   %s %s\n", is_xip ? "XIP" : "Loading", name);
+   printf("   %s %s", is_xip ? "XIP" : "Loading", name);
else
-   printf("   Uncompressing %s\n", name);
+   printf("   Uncompressing %s", name);
+
+   printf(" to %lx\n", load);
 }
 
 int image_decomp_type(const unsigned char *buf, ulong len)
@@ -448,7 +453,7 @@ int image_decomp(int comp, ulong load, ulong image_start, 
int type,
int ret = -ENOSYS;
 
*load_end = load;
-   print_decomp_msg(comp, type, load == image_start);
+   print_decomp_msg(comp, type, load == image_start, load);
 
/*
 * Load the image to the right place, decompressing if needed. After
-- 
2.42.0.869.gea05f2083d-goog