Re: [PATCH v2 3/4] thermal: add sandbox driver

2022-08-13 Thread Simon Glass
On Fri, 12 Aug 2022 at 12:16, Robert Marko  wrote:
>
> Provide a simple sandbox driver for the thermal uclass.
> It simply registers and returns 100 degrees C if requested.
>
> Signed-off-by: Robert Marko 
> ---
>  arch/sandbox/dts/sandbox.dtsi |  4 
>  arch/sandbox/dts/test.dts |  4 
>  configs/sandbox_defconfig |  2 ++
>  drivers/thermal/Makefile  |  1 +
>  drivers/thermal/thermal_sandbox.c | 36 +++
>  5 files changed, 47 insertions(+)
>  create mode 100644 drivers/thermal/thermal_sandbox.c

Reviewed-by: Simon Glass 


[PATCH v2 3/4] thermal: add sandbox driver

2022-08-12 Thread Robert Marko
Provide a simple sandbox driver for the thermal uclass.
It simply registers and returns 100 degrees C if requested.

Signed-off-by: Robert Marko 
---
 arch/sandbox/dts/sandbox.dtsi |  4 
 arch/sandbox/dts/test.dts |  4 
 configs/sandbox_defconfig |  2 ++
 drivers/thermal/Makefile  |  1 +
 drivers/thermal/thermal_sandbox.c | 36 +++
 5 files changed, 47 insertions(+)
 create mode 100644 drivers/thermal/thermal_sandbox.c

diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi
index aa22b8765c..c24aee1d05 100644
--- a/arch/sandbox/dts/sandbox.dtsi
+++ b/arch/sandbox/dts/sandbox.dtsi
@@ -426,6 +426,10 @@
sandbox_tee {
compatible = "sandbox,tee";
};
+
+   thermal {
+   compatible = "sandbox,thermal";
+   };
 };
 
 _ec {
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index d1a8cc7bfb..f002233064 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -1668,6 +1668,10 @@
compatible = "sandbox,regmap_test";
};
};
+
+   thermal {
+   compatible = "sandbox,thermal";
+   };
 };
 
 #include "sandbox_pmic.dtsi"
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index eba7bcbb48..d4965248d4 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -77,6 +77,7 @@ CONFIG_CMD_PCI=y
 CONFIG_CMD_READ=y
 CONFIG_CMD_REMOTEPROC=y
 CONFIG_CMD_SPI=y
+CONFIG_CMD_TEMPERATURE=y
 CONFIG_CMD_USB=y
 CONFIG_CMD_AXI=y
 CONFIG_CMD_SETEXPR_FMT=y
@@ -282,6 +283,7 @@ CONFIG_SYSINFO=y
 CONFIG_SYSINFO_SANDBOX=y
 CONFIG_SYSINFO_GPIO=y
 CONFIG_SYSRESET=y
+CONFIG_DM_THERMAL=y
 CONFIG_TIMER=y
 CONFIG_TIMER_EARLY=y
 CONFIG_SANDBOX_TIMER=y
diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
index 6dda62bcd1..f2ee1df394 100644
--- a/drivers/thermal/Makefile
+++ b/drivers/thermal/Makefile
@@ -4,6 +4,7 @@
 # Author: Nitin Garg 
 
 obj-$(CONFIG_DM_THERMAL) += thermal-uclass.o
+obj-$(CONFIG_SANDBOX) += thermal_sandbox.o
 obj-$(CONFIG_IMX_THERMAL) += imx_thermal.o
 obj-$(CONFIG_IMX_SCU_THERMAL) += imx_scu_thermal.o
 obj-$(CONFIG_SPARX5_THERMAL) += sparx5-temp.o
diff --git a/drivers/thermal/thermal_sandbox.c 
b/drivers/thermal/thermal_sandbox.c
new file mode 100644
index 00..acc364feb0
--- /dev/null
+++ b/drivers/thermal/thermal_sandbox.c
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2022 Sartura Ltd.
+ * Written by Robert Marko 
+ *
+ * Sandbox driver for the thermal uclass.
+ */
+
+#include 
+#include 
+#include 
+
+int sandbox_thermal_get_temp(struct udevice *dev, int *temp)
+{
+   /* Simply return 100°C */
+   *temp = 100;
+
+   return 0;
+}
+
+static const struct dm_thermal_ops sandbox_thermal_ops = {
+   .get_temp = sandbox_thermal_get_temp,
+};
+
+static const struct udevice_id sandbox_thermal_ids[] = {
+   { .compatible = "sandbox,thermal" },
+   { }
+};
+
+U_BOOT_DRIVER(thermal_sandbox) = {
+   .name   = "thermal-sandbox",
+   .id = UCLASS_THERMAL,
+   .of_match   = sandbox_thermal_ids,
+   .ops= _thermal_ops,
+   .flags  = DM_FLAG_PRE_RELOC,
+};
-- 
2.37.1