Re: [PATCH v2 3/7] net: dwc_eth_qos: Stop spam of RX packet not available message

[Ramon Fried]

On Sun, Oct 1, 2023 at 10:17 PM Jonas Karlman  wrote:
>
> Remove spam of RX packet not available debug messages when waiting to
> receive a packet.
>
> Signed-off-by: Jonas Karlman 
> Reviewed-by: Kever Yang 
> ---
> v2:
> - Collect r-b tag
>
>  drivers/net/dwc_eth_qos.c | 8 +++-
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> index 7565e716823a..24fb3fac1f12 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -1193,14 +1193,12 @@ static int eqos_recv(struct udevice *dev, int flags, 
> uchar **packetp)
> struct eqos_desc *rx_desc;
> int length;
>
> -   debug("%s(dev=%p, flags=%x):\n", __func__, dev, flags);
> -
> rx_desc = eqos_get_desc(eqos, eqos->rx_desc_idx, true);
> eqos->config->ops->eqos_inval_desc(rx_desc);
> -   if (rx_desc->des3 & EQOS_DESC3_OWN) {
> -   debug("%s: RX packet not available\n", __func__);
> +   if (rx_desc->des3 & EQOS_DESC3_OWN)
> return -EAGAIN;
> -   }
> +
> +   debug("%s(dev=%p, flags=%x):\n", __func__, dev, flags);
>
> *packetp = eqos->rx_dma_buf +
> (eqos->rx_desc_idx * EQOS_MAX_PACKET_SIZE);
> --
> 2.42.0
>
Reviewed-by: Ramon Fried 

[PATCH v2 3/7] net: dwc_eth_qos: Stop spam of RX packet not available message

[Jonas Karlman]

Remove spam of RX packet not available debug messages when waiting to
receive a packet.

Signed-off-by: Jonas Karlman 
Reviewed-by: Kever Yang 
---
v2:
- Collect r-b tag

 drivers/net/dwc_eth_qos.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index 7565e716823a..24fb3fac1f12 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -1193,14 +1193,12 @@ static int eqos_recv(struct udevice *dev, int flags, 
uchar **packetp)
struct eqos_desc *rx_desc;
int length;
 
-   debug("%s(dev=%p, flags=%x):\n", __func__, dev, flags);
-
rx_desc = eqos_get_desc(eqos, eqos->rx_desc_idx, true);
eqos->config->ops->eqos_inval_desc(rx_desc);
-   if (rx_desc->des3 & EQOS_DESC3_OWN) {
-   debug("%s: RX packet not available\n", __func__);
+   if (rx_desc->des3 & EQOS_DESC3_OWN)
return -EAGAIN;
-   }
+
+   debug("%s(dev=%p, flags=%x):\n", __func__, dev, flags);
 
*packetp = eqos->rx_dma_buf +
(eqos->rx_desc_idx * EQOS_MAX_PACKET_SIZE);
-- 
2.42.0