Re: [PATCH v2 4/6] test: spi: Add sandbox_spi_get_{speed, mode} interface

2020-12-23 Thread Simon Glass
On Mon, 14 Dec 2020 at 10:08, Ovidiu Panait  wrote:
>
> Introduce sandbox_spi_get_{speed, mode} public interface to retrieve the
> sandbox spi bus internal state. They are meant to be used in sandbox spi
> testcases.
>
> Signed-off-by: Ovidiu Panait 
> Reviewed-by: Simon Glass 
> ---
>
> Changes in v2:
> - add reviewed-by tag
>
>  arch/sandbox/include/asm/test.h | 16 
>  drivers/spi/sandbox_spi.c   | 14 ++
>  2 files changed, 30 insertions(+)

Applied to u-boot-dm/next, thanks!


[PATCH v2 4/6] test: spi: Add sandbox_spi_get_{speed, mode} interface

2020-12-14 Thread Ovidiu Panait
Introduce sandbox_spi_get_{speed, mode} public interface to retrieve the
sandbox spi bus internal state. They are meant to be used in sandbox spi
testcases.

Signed-off-by: Ovidiu Panait 
Reviewed-by: Simon Glass 
---

Changes in v2:
- add reviewed-by tag

 arch/sandbox/include/asm/test.h | 16 
 drivers/spi/sandbox_spi.c   | 14 ++
 2 files changed, 30 insertions(+)

diff --git a/arch/sandbox/include/asm/test.h b/arch/sandbox/include/asm/test.h
index 7f99d07c47..05f66f700c 100644
--- a/arch/sandbox/include/asm/test.h
+++ b/arch/sandbox/include/asm/test.h
@@ -202,6 +202,22 @@ void sandbox_set_allow_beep(struct udevice *dev, bool 
allow);
  */
 int sandbox_get_beep_frequency(struct udevice *dev);
 
+/**
+ * sandbox_spi_get_speed() - Get current speed setting of a sandbox spi bus
+ *
+ * @dev: Device to check
+ * @return current bus speed
+ */
+uint sandbox_spi_get_speed(struct udevice *dev);
+
+/**
+ * sandbox_spi_get_mode() - Get current mode setting of a sandbox spi bus
+ *
+ * @dev: Device to check
+ * @return current mode
+ */
+uint sandbox_spi_get_mode(struct udevice *dev);
+
 /**
  * sandbox_get_pch_spi_protect() - Get the PCI SPI protection status
  *
diff --git a/drivers/spi/sandbox_spi.c b/drivers/spi/sandbox_spi.c
index 72f22d066f..cbe8d62681 100644
--- a/drivers/spi/sandbox_spi.c
+++ b/drivers/spi/sandbox_spi.c
@@ -52,6 +52,20 @@ __weak int sandbox_spi_get_emul(struct sandbox_state *state,
return -ENOENT;
 }
 
+uint sandbox_spi_get_speed(struct udevice *dev)
+{
+   struct sandbox_spi_priv *priv = dev_get_priv(dev);
+
+   return priv->speed;
+}
+
+uint sandbox_spi_get_mode(struct udevice *dev)
+{
+   struct sandbox_spi_priv *priv = dev_get_priv(dev);
+
+   return priv->mode;
+}
+
 static int sandbox_spi_xfer(struct udevice *slave, unsigned int bitlen,
const void *dout, void *din, unsigned long flags)
 {
-- 
2.17.1