Re: [PATCH v3 01/13] smegw01: Enable setting additional boot params

2023-04-24 Thread Tom Rini
On Mon, Apr 24, 2023 at 08:11:54AM -0300, Fabio Estevam wrote:
> From: Eduard Strehlau 
> 
> Introduce EXTRA_BOOTPARAMS to allow passing additional parameters
> to kernel command line. This is useful for debugging purposes.
> 
> Signed-off-by: Eduard Strehlau 
> Signed-off-by: Fabio Estevam 
> ---
> Changes since v2:
> - None
> 
>  include/configs/smegw01.h | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/smegw01.h b/include/configs/smegw01.h
> index 11031744be..a356f095a6 100644
> --- a/include/configs/smegw01.h
> +++ b/include/configs/smegw01.h
> @@ -17,6 +17,11 @@
>  /* MMC Config*/
>  #define CFG_SYS_FSL_ESDHC_ADDR   0
>  
> +/* default to no extra bootparams, we need an empty define for 
> stringification*/
> +#ifndef EXTRA_BOOTPARAMS
> +#define EXTRA_BOOTPARAMS
> +#endif
> +
>  #define CFG_EXTRA_ENV_SETTINGS \
>   "image=zImage\0" \
>   "console=ttymxc0\0" \
> @@ -26,7 +31,8 @@
>   "mmcdev=0\0" \
>   "mmcpart=1\0" \
>   "mmcargs=setenv bootargs console=${console},${baudrate} " \
> - "root=/dev/mmcblk0p${mmcpart} rootwait rw\0" \
> + "root=/dev/mmcblk0p${mmcpart} rootwait rw " \
> + __stringify(EXTRA_BOOTPARAMS) "\0" \
>   "loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/${image}\0" \
>   "loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} boot/${fdtfile}\0" \
>   "mmcboot=echo Booting from mmc ...; " \

As this series does a lot of environment changes, please update the
board to use plain text environment instead of CFG_EXTRA_ENV_SETTINGS,
thanks. If it's too much to do at the start of the series, at the end is
OK.

-- 
Tom


signature.asc
Description: PGP signature


[PATCH v3 01/13] smegw01: Enable setting additional boot params

2023-04-24 Thread Fabio Estevam
From: Eduard Strehlau 

Introduce EXTRA_BOOTPARAMS to allow passing additional parameters
to kernel command line. This is useful for debugging purposes.

Signed-off-by: Eduard Strehlau 
Signed-off-by: Fabio Estevam 
---
Changes since v2:
- None

 include/configs/smegw01.h | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/include/configs/smegw01.h b/include/configs/smegw01.h
index 11031744be..a356f095a6 100644
--- a/include/configs/smegw01.h
+++ b/include/configs/smegw01.h
@@ -17,6 +17,11 @@
 /* MMC Config*/
 #define CFG_SYS_FSL_ESDHC_ADDR 0
 
+/* default to no extra bootparams, we need an empty define for 
stringification*/
+#ifndef EXTRA_BOOTPARAMS
+#define EXTRA_BOOTPARAMS
+#endif
+
 #define CFG_EXTRA_ENV_SETTINGS \
"image=zImage\0" \
"console=ttymxc0\0" \
@@ -26,7 +31,8 @@
"mmcdev=0\0" \
"mmcpart=1\0" \
"mmcargs=setenv bootargs console=${console},${baudrate} " \
-   "root=/dev/mmcblk0p${mmcpart} rootwait rw\0" \
+   "root=/dev/mmcblk0p${mmcpart} rootwait rw " \
+   __stringify(EXTRA_BOOTPARAMS) "\0" \
"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/${image}\0" \
"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} boot/${fdtfile}\0" \
"mmcboot=echo Booting from mmc ...; " \
-- 
2.38.1