Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
Hi Johan, Pawel, On 2022/3/14 23:36, Johan Jonker wrote: On 3/12/22 15:39, Kever Yang wrote: Hi Johan, On 2022/3/12 18:01, Johan Jonker wrote: On 3/12/22 09:51, Jagan Teki wrote: On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker wrote: Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker --- Changed V3: add ROCKCHIP_STIMER --- arch/arm/mach-rockchip/Kconfig| 22 ++ arch/arm/mach-rockchip/px30/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++ arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ include/configs/px30_common.h | 1 - include/configs/rk3036_common.h | 1 - include/configs/rk3128_common.h | 1 - include/configs/rk322x_common.h | 1 - include/configs/rk3288_common.h | 1 - include/configs/rk3308_common.h | 1 - include/configs/rk3328_common.h | 1 - include/configs/rk3368_common.h | 1 - include/configs/rk3399_common.h | 1 - include/configs/rk3568_common.h | 1 - 21 files changed, 55 insertions(+), 14 deletions(-) diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index da6871eb..7a624c64 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG The Soc will enter to different boot mode(defined in asm/arch-rockchip/boot_mode.h) according to the value from this register. +config ROCKCHIP_STIMER + bool "Rockchip STIMER support" + default y + depends on (ROCKCHIP_PX30|| \ + ROCKCHIP_RK3036|| \ + ROCKCHIP_RK3128|| \ + ROCKCHIP_RK322X|| \ + ROCKCHIP_RK3288|| \ + ROCKCHIP_RK3308|| \ + ROCKCHIP_RK3328|| \ + ROCKCHIP_RK3368|| \ + ROCKCHIP_RK3399|| \ + ROCKCHIP_RK3568) What if we select !(SOC-Which-don't-support-stimer). I believe the condition check here is much simpler. The condition would be simpler that's correct, but this patch is made with rk3066 in mind and there's no ROCKCHIP_RK3066 available yet. The right approach is to only include SoC's that have a specific property/functionality linked to there specific config tag. U-boot should be generic. And we should not have to fix all dependencies all over the place when a SoC doesn't have something. Please advise how to support other SoC's like rk3066. Thanks for you hard working on this, would you mind to share what's the motivation for support rk3066 and MK808 board? RK3066 is an SoC release at 2012, which has been EOL for a long time, and MK808 is a product at 2013, almost 10 years ago. One of the advantages of open source is that a manufacturer doesn't dictate where, when and how long a product can be used. It's about freedom of choice. No matter how many obstacles are put in the way. It works in two ways. Rockchip make use of free open source for there products. Users can add there own ideas/support based on manufacturer sources. If that's not your thing then join a group of monopolists for software, but don't sabotage things here. It's part of the game. MK808 was one of the first products with a Rockchip SoC that hobbyists where able to run there own kernel on and still does, so we keep that heritage alive. I'm not object for enable more SoC support on the mainline, and I know you have spend a lot of time on this, I have do something like this before, but to be honest I don't think it's a good idea to add support for rk3066 on mainline now. If Linux is able to support the full product range then U-boot can do that too. I agree with this point, my concern is the maintain of the source code and the lifecycle after we add it. Since both Powel and you declare that still RK3066 device on the market and some developers are working on it, I'm happy to get them in tree, I will land patches after verify no broken for other platform. Thanks, - Kever
Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
On 3/12/22 15:39, Kever Yang wrote: > Hi Johan, > > On 2022/3/12 18:01, Johan Jonker wrote: >> On 3/12/22 09:51, Jagan Teki wrote: >>> On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker wrote: Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker --- Changed V3: add ROCKCHIP_STIMER --- arch/arm/mach-rockchip/Kconfig| 22 ++ arch/arm/mach-rockchip/px30/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++ arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ include/configs/px30_common.h | 1 - include/configs/rk3036_common.h | 1 - include/configs/rk3128_common.h | 1 - include/configs/rk322x_common.h | 1 - include/configs/rk3288_common.h | 1 - include/configs/rk3308_common.h | 1 - include/configs/rk3328_common.h | 1 - include/configs/rk3368_common.h | 1 - include/configs/rk3399_common.h | 1 - include/configs/rk3568_common.h | 1 - 21 files changed, 55 insertions(+), 14 deletions(-) diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index da6871eb..7a624c64 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG The Soc will enter to different boot mode(defined in asm/arch-rockchip/boot_mode.h) according to the value from this register. +config ROCKCHIP_STIMER + bool "Rockchip STIMER support" + default y + depends on (ROCKCHIP_PX30|| \ + ROCKCHIP_RK3036|| \ + ROCKCHIP_RK3128|| \ + ROCKCHIP_RK322X|| \ + ROCKCHIP_RK3288|| \ + ROCKCHIP_RK3308|| \ + ROCKCHIP_RK3328|| \ + ROCKCHIP_RK3368|| \ + ROCKCHIP_RK3399|| \ + ROCKCHIP_RK3568) >>> What if we select !(SOC-Which-don't-support-stimer). I believe the >>> condition check here is much simpler. >> The condition would be simpler that's correct, but this patch is made >> with rk3066 in mind and there's no ROCKCHIP_RK3066 available yet. >> The right approach is to only include SoC's that have a specific >> property/functionality linked to there specific config tag. >> U-boot should be generic. And we should not have to fix all dependencies >> all over the place when a SoC doesn't have something. >> >> Please advise how to support other SoC's like rk3066. > Thanks for you hard working on this, would you mind to share what's the > motivation for support rk3066 and MK808 board? > RK3066 is an SoC release at 2012, which has been EOL for a long time, > and MK808 is a product at 2013, almost 10 years ago. One of the advantages of open source is that a manufacturer doesn't dictate where, when and how long a product can be used. It's about freedom of choice. No matter how many obstacles are put in the way. It works in two ways. Rockchip make use of free open source for there products. Users can add there own ideas/support based on manufacturer sources. If that's not your thing then join a group of monopolists for software, but don't sabotage things here. It's part of the game. MK808 was one of the first products with a Rockchip SoC that hobbyists where able to run there own kernel on and still does, so we keep that heritage alive. > > > I'm not object for enable more SoC support on the mainline, and I know > you have spend a lot > of time on this, I have do something like this before, but to be honest > I don't think it's a good idea to add support for > rk3066 on mainline now. If Linux is able to support the full product range then U-boot can do that too. The last 2 years were spent with upgrading and fixing the Linux Device tree. It would be nice if that was synced standard automatically for the Rockchip branch on a regular base. The more you neglect the more outdated it becomes. See rk3288 DT. > > > I merge the patches from Paweł Jarosz many years ago into rockchip local > u-boot and make it work, > I want to make the branch support as much SoCs as possible at that time. > But later I found there is no people to use > it, No wonder, no serious person would concern the Rockchip Linux and U-boot tree a usable option given it's current state. It's official kernel tree hasn't been updated for some while and based on LT versions that are outdated.
Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
Hi, On Sun, 13 Mar 2022 at 06:41, Paweł Jarosz wrote: > > Hi Kever, > > > > Thanks for you hard working on this, would you mind to share what's the > > motivation for support rk3066 and MK808 board? > > RK3066 is an SoC release at 2012, which has been EOL for a long time, > > and MK808 is a product at 2013, almost 10 years ago. > > > That is true but at least here at Poland there are still rk3066 devices which > you can buy. And i don't think it's an exception. There are known cases > in opensource community of support for hardware much older than 10 years. > I.e. thanks to Linus Torwalds linux still supports EISA FDDI [1]. > There are at least a few rk3066a SOC users and in the spirit of > Linus Torvalds' open source principles, adding support for this > platform is the correct step. > > RK3066 is a great soc to play with. > I use my MK808 for three years now to keep my 3d printer in contact > with my local network. > I have been using the URZ0350 as a wifi camera for a long time. > And guess what! They don't want to break down. > > [1] https://blog.desdelinux.net/en/linus-supports-a-device-by-a-user/ > > > I'm not object for enable more SoC support on the mainline, and I know > > you have spend a lot > > of time on this, I have do something like this before, but to be honest > > I don't think it's a good idea to add support for > > rk3066 on mainline now. > > > I do not agree. > > As long as the world is using armv7 architecture adding support for SOC > rk3066a is a great and noble idea. > I personally am working on following up on my and Johan's patches by > adding support for writing firmware to these devices, using only opensource > tools like u-boot and rkflashtool. This support can be extended to other > devices such as rk3399, rk3568 and others. So other SOCs can also benefit > from adding support for rk3066a. > > I also want to add that Linux actively supports rk3066a [2]. > So if linux supports it, U-BOOT SHOULD ALSO! > > [2] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep=rk3066 > > I appeal to you Kever Yang in the spirit of opensource, don't give up on > rk3066a yet. These devices are there and they work! > > > Thanks > -Paweł > > > I merge the patches from Paweł Jarosz many years ago into rockchip local > > u-boot and make it work, > > I want to make the branch support as much SoCs as possible at that time. > > But later I found there is no people to use > > it, and the U-Boot is getting more and more heavy, old SoC support is > > the one part people want to clean, > > for it always bring in more '#if, #else' or something like this clean up > > series patches, and more terrible thing is how to > > always maintain the source code works on the old hardware. I do make > > everything work for a long time at first, > > but one day my only rk3066 board is broken, and I'm not able to do it > > anymore. Actually we have much older devices in U-Boot than that! The key thing is to have someone maintaining the board. Regards, SImon
Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
Hi Kever, > Thanks for you hard working on this, would you mind to share what's the > motivation for support rk3066 and MK808 board? > RK3066 is an SoC release at 2012, which has been EOL for a long time, > and MK808 is a product at 2013, almost 10 years ago. That is true but at least here at Poland there are still rk3066 devices which you can buy. And i don't think it's an exception. There are known cases in opensource community of support for hardware much older than 10 years. I.e. thanks to Linus Torwalds linux still supports EISA FDDI [1]. There are at least a few rk3066a SOC users and in the spirit of Linus Torvalds' open source principles, adding support for this platform is the correct step. RK3066 is a great soc to play with. I use my MK808 for three years now to keep my 3d printer in contact with my local network. I have been using the URZ0350 as a wifi camera for a long time. And guess what! They don't want to break down. [1] https://blog.desdelinux.net/en/linus-supports-a-device-by-a-user/ > I'm not object for enable more SoC support on the mainline, and I know > you have spend a lot > of time on this, I have do something like this before, but to be honest > I don't think it's a good idea to add support for > rk3066 on mainline now. I do not agree. As long as the world is using armv7 architecture adding support for SOC rk3066a is a great and noble idea. I personally am working on following up on my and Johan's patches by adding support for writing firmware to these devices, using only opensource tools like u-boot and rkflashtool. This support can be extended to other devices such as rk3399, rk3568 and others. So other SOCs can also benefit from adding support for rk3066a. I also want to add that Linux actively supports rk3066a [2]. So if linux supports it, U-BOOT SHOULD ALSO! [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep=rk3066 I appeal to you Kever Yang in the spirit of opensource, don't give up on rk3066a yet. These devices are there and they work! Thanks -Paweł > I merge the patches from Paweł Jarosz many years ago into rockchip local > u-boot and make it work, > I want to make the branch support as much SoCs as possible at that time. > But later I found there is no people to use > it, and the U-Boot is getting more and more heavy, old SoC support is > the one part people want to clean, > for it always bring in more '#if, #else' or something like this clean up > series patches, and more terrible thing is how to > always maintain the source code works on the old hardware. I do make > everything work for a long time at first, > but one day my only rk3066 board is broken, and I'm not able to do it > anymore. > > Thanks, > - Kever
Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
Hi Johan, On 2022/3/12 18:01, Johan Jonker wrote: On 3/12/22 09:51, Jagan Teki wrote: On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker wrote: Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker --- Changed V3: add ROCKCHIP_STIMER --- arch/arm/mach-rockchip/Kconfig| 22 ++ arch/arm/mach-rockchip/px30/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++ arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ include/configs/px30_common.h | 1 - include/configs/rk3036_common.h | 1 - include/configs/rk3128_common.h | 1 - include/configs/rk322x_common.h | 1 - include/configs/rk3288_common.h | 1 - include/configs/rk3308_common.h | 1 - include/configs/rk3328_common.h | 1 - include/configs/rk3368_common.h | 1 - include/configs/rk3399_common.h | 1 - include/configs/rk3568_common.h | 1 - 21 files changed, 55 insertions(+), 14 deletions(-) diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index da6871eb..7a624c64 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG The Soc will enter to different boot mode(defined in asm/arch-rockchip/boot_mode.h) according to the value from this register. +config ROCKCHIP_STIMER + bool "Rockchip STIMER support" + default y + depends on (ROCKCHIP_PX30|| \ + ROCKCHIP_RK3036|| \ + ROCKCHIP_RK3128|| \ + ROCKCHIP_RK322X|| \ + ROCKCHIP_RK3288|| \ + ROCKCHIP_RK3308|| \ + ROCKCHIP_RK3328|| \ + ROCKCHIP_RK3368|| \ + ROCKCHIP_RK3399|| \ + ROCKCHIP_RK3568) What if we select !(SOC-Which-don't-support-stimer). I believe the condition check here is much simpler. The condition would be simpler that's correct, but this patch is made with rk3066 in mind and there's no ROCKCHIP_RK3066 available yet. The right approach is to only include SoC's that have a specific property/functionality linked to there specific config tag. U-boot should be generic. And we should not have to fix all dependencies all over the place when a SoC doesn't have something. Please advise how to support other SoC's like rk3066. Thanks for you hard working on this, would you mind to share what's the motivation for support rk3066 and MK808 board? RK3066 is an SoC release at 2012, which has been EOL for a long time, and MK808 is a product at 2013, almost 10 years ago. I'm not object for enable more SoC support on the mainline, and I know you have spend a lot of time on this, I have do something like this before, but to be honest I don't think it's a good idea to add support for rk3066 on mainline now. I merge the patches from Paweł Jarosz many years ago into rockchip local u-boot and make it work, I want to make the branch support as much SoCs as possible at that time. But later I found there is no people to use it, and the U-Boot is getting more and more heavy, old SoC support is the one part people want to clean, for it always bring in more '#if, #else' or something like this clean up series patches, and more terrible thing is how to always maintain the source code works on the old hardware. I do make everything work for a long time at first, but one day my only rk3066 board is broken, and I'm not able to do it anymore. Thanks, - Kever Johan Jagan.
Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
On 3/12/22 09:51, Jagan Teki wrote: > On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker wrote: >> >> Move ROCKCHIP_STIMER_BASE to Kconfig. >> >> Signed-off-by: Johan Jonker >> --- >> >> Changed V3: >> add ROCKCHIP_STIMER >> --- >> arch/arm/mach-rockchip/Kconfig| 22 ++ >> arch/arm/mach-rockchip/px30/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++ >> arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ >> arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ >> include/configs/px30_common.h | 1 - >> include/configs/rk3036_common.h | 1 - >> include/configs/rk3128_common.h | 1 - >> include/configs/rk322x_common.h | 1 - >> include/configs/rk3288_common.h | 1 - >> include/configs/rk3308_common.h | 1 - >> include/configs/rk3328_common.h | 1 - >> include/configs/rk3368_common.h | 1 - >> include/configs/rk3399_common.h | 1 - >> include/configs/rk3568_common.h | 1 - >> 21 files changed, 55 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig >> index da6871eb..7a624c64 100644 >> --- a/arch/arm/mach-rockchip/Kconfig >> +++ b/arch/arm/mach-rockchip/Kconfig >> @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG >> The Soc will enter to different boot mode(defined in >> asm/arch-rockchip/boot_mode.h) >> according to the value from this register. >> >> +config ROCKCHIP_STIMER >> + bool "Rockchip STIMER support" >> + default y >> + depends on (ROCKCHIP_PX30|| \ >> + ROCKCHIP_RK3036|| \ >> + ROCKCHIP_RK3128|| \ >> + ROCKCHIP_RK322X|| \ >> + ROCKCHIP_RK3288|| \ >> + ROCKCHIP_RK3308|| \ >> + ROCKCHIP_RK3328|| \ >> + ROCKCHIP_RK3368|| \ >> + ROCKCHIP_RK3399|| \ >> + ROCKCHIP_RK3568) > > What if we select !(SOC-Which-don't-support-stimer). I believe the > condition check here is much simpler. The condition would be simpler that's correct, but this patch is made with rk3066 in mind and there's no ROCKCHIP_RK3066 available yet. The right approach is to only include SoC's that have a specific property/functionality linked to there specific config tag. U-boot should be generic. And we should not have to fix all dependencies all over the place when a SoC doesn't have something. Please advise how to support other SoC's like rk3066. Johan > > Jagan.
Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker wrote: > > Move ROCKCHIP_STIMER_BASE to Kconfig. > > Signed-off-by: Johan Jonker > --- > > Changed V3: > add ROCKCHIP_STIMER > --- > arch/arm/mach-rockchip/Kconfig| 22 ++ > arch/arm/mach-rockchip/px30/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++ > arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ > include/configs/px30_common.h | 1 - > include/configs/rk3036_common.h | 1 - > include/configs/rk3128_common.h | 1 - > include/configs/rk322x_common.h | 1 - > include/configs/rk3288_common.h | 1 - > include/configs/rk3308_common.h | 1 - > include/configs/rk3328_common.h | 1 - > include/configs/rk3368_common.h | 1 - > include/configs/rk3399_common.h | 1 - > include/configs/rk3568_common.h | 1 - > 21 files changed, 55 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index da6871eb..7a624c64 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG > The Soc will enter to different boot mode(defined in > asm/arch-rockchip/boot_mode.h) > according to the value from this register. > > +config ROCKCHIP_STIMER > + bool "Rockchip STIMER support" > + default y > + depends on (ROCKCHIP_PX30|| \ > + ROCKCHIP_RK3036|| \ > + ROCKCHIP_RK3128|| \ > + ROCKCHIP_RK322X|| \ > + ROCKCHIP_RK3288|| \ > + ROCKCHIP_RK3308|| \ > + ROCKCHIP_RK3328|| \ > + ROCKCHIP_RK3368|| \ > + ROCKCHIP_RK3399|| \ > + ROCKCHIP_RK3568) What if we select !(SOC-Which-don't-support-stimer). I believe the condition check here is much simpler. Jagan.
Re: [PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
On Thu, 30 Dec 2021 at 09:48, Johan Jonker wrote: > > Move ROCKCHIP_STIMER_BASE to Kconfig. > > Signed-off-by: Johan Jonker > --- > > Changed V3: > add ROCKCHIP_STIMER > --- > arch/arm/mach-rockchip/Kconfig| 22 ++ > arch/arm/mach-rockchip/px30/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++ > arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ > arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ > include/configs/px30_common.h | 1 - > include/configs/rk3036_common.h | 1 - > include/configs/rk3128_common.h | 1 - > include/configs/rk322x_common.h | 1 - > include/configs/rk3288_common.h | 1 - > include/configs/rk3308_common.h | 1 - > include/configs/rk3328_common.h | 1 - > include/configs/rk3368_common.h | 1 - > include/configs/rk3399_common.h | 1 - > include/configs/rk3568_common.h | 1 - > 21 files changed, 55 insertions(+), 14 deletions(-) Reviewed-by: Simon Glass
[PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig
Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker --- Changed V3: add ROCKCHIP_STIMER --- arch/arm/mach-rockchip/Kconfig| 22 ++ arch/arm/mach-rockchip/px30/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++ arch/arm/mach-rockchip/rk322x/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++ arch/arm/mach-rockchip/rk3328/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3368/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3399/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3568/Kconfig | 3 +++ include/configs/px30_common.h | 1 - include/configs/rk3036_common.h | 1 - include/configs/rk3128_common.h | 1 - include/configs/rk322x_common.h | 1 - include/configs/rk3288_common.h | 1 - include/configs/rk3308_common.h | 1 - include/configs/rk3328_common.h | 1 - include/configs/rk3368_common.h | 1 - include/configs/rk3399_common.h | 1 - include/configs/rk3568_common.h | 1 - 21 files changed, 55 insertions(+), 14 deletions(-) diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index da6871eb..7a624c64 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG The Soc will enter to different boot mode(defined in asm/arch-rockchip/boot_mode.h) according to the value from this register. +config ROCKCHIP_STIMER + bool "Rockchip STIMER support" + default y + depends on (ROCKCHIP_PX30|| \ + ROCKCHIP_RK3036|| \ + ROCKCHIP_RK3128|| \ + ROCKCHIP_RK322X|| \ + ROCKCHIP_RK3288|| \ + ROCKCHIP_RK3308|| \ + ROCKCHIP_RK3328|| \ + ROCKCHIP_RK3368|| \ + ROCKCHIP_RK3399|| \ + ROCKCHIP_RK3568) + help + Enable Rockchip STIMER support. + +config ROCKCHIP_STIMER_BASE + hex "Rockchip secure timer base address" + depends on ROCKCHIP_STIMER + help + Rockchip secure timer base address. + config ROCKCHIP_SPL_RESERVE_IRAM hex "Size of IRAM reserved in SPL" default 0 diff --git a/arch/arm/mach-rockchip/px30/Kconfig b/arch/arm/mach-rockchip/px30/Kconfig index aa5cc471..42cc111b 100644 --- a/arch/arm/mach-rockchip/px30/Kconfig +++ b/arch/arm/mach-rockchip/px30/Kconfig @@ -30,6 +30,9 @@ config TARGET_PX30_CORE config ROCKCHIP_BOOT_MODE_REG default 0xff010200 +config ROCKCHIP_STIMER_BASE + default 0xff220020 + config SYS_SOC default "px30" diff --git a/arch/arm/mach-rockchip/rk3036/Kconfig b/arch/arm/mach-rockchip/rk3036/Kconfig index b746795d..111531be 100644 --- a/arch/arm/mach-rockchip/rk3036/Kconfig +++ b/arch/arm/mach-rockchip/rk3036/Kconfig @@ -16,6 +16,9 @@ endchoice config ROCKCHIP_BOOT_MODE_REG default 0x200081c8 +config ROCKCHIP_STIMER_BASE + default 0x200440a0 + config SYS_SOC default "rk3036" diff --git a/arch/arm/mach-rockchip/rk3128/Kconfig b/arch/arm/mach-rockchip/rk3128/Kconfig index b867401c..9cc494eb 100644 --- a/arch/arm/mach-rockchip/rk3128/Kconfig +++ b/arch/arm/mach-rockchip/rk3128/Kconfig @@ -16,6 +16,9 @@ endchoice config ROCKCHIP_BOOT_MODE_REG default 0x100a0038 +config ROCKCHIP_STIMER_BASE + default 0x200440a0 + config SYS_SOC default "rk3128" diff --git a/arch/arm/mach-rockchip/rk322x/Kconfig b/arch/arm/mach-rockchip/rk322x/Kconfig index 6458cd55..058f848d 100644 --- a/arch/arm/mach-rockchip/rk322x/Kconfig +++ b/arch/arm/mach-rockchip/rk322x/Kconfig @@ -8,6 +8,9 @@ config TARGET_EVB_RK3229 config ROCKCHIP_BOOT_MODE_REG default 0x110005c8 +config ROCKCHIP_STIMER_BASE + default 0x110d0020 + config SYS_SOC default "rk322x" diff --git a/arch/arm/mach-rockchip/rk3288/Kconfig b/arch/arm/mach-rockchip/rk3288/Kconfig index f37b1bdf..dd8c7826 100644 --- a/arch/arm/mach-rockchip/rk3288/Kconfig +++ b/arch/arm/mach-rockchip/rk3288/Kconfig @@ -148,6 +148,9 @@ config ROCKCHIP_FAST_SPL config ROCKCHIP_BOOT_MODE_REG default 0xff730094 +config ROCKCHIP_STIMER_BASE + default 0xff810020 + config SYS_SOC default "rk3288" diff --git a/arch/arm/mach-rockchip/rk3308/Kconfig b/arch/arm/mach-rockchip/rk3308/Kconfig index 8fa536e1..194353e4 100644 --- a/arch/arm/mach-rockchip/rk3308/Kconfig +++ b/arch/arm/mach-rockchip/rk3308/Kconfig @@ -8,6 +8,12 @@ config TARGET_ROC_RK3308_CC bool "Firefly roc-rk3308-cc" select BOARD_LATE_INIT +config ROCKCHIP_BOOT_MODE_REG + default 0xff000500 + +config ROCKCHIP_STIMER_BASE + default 0xff1b00a0 + config SYS_SOC default "rk3308" @@ -17,10 +23,6 @@ config SYS_MALLOC_F_LEN config SPL_SERIAL default y -config
