Re: [PATCH v3 52/57] x86: fsp: Add more debugging for silicon init

[Bin Meng]

On Mon, Sep 7, 2020 at 5:45 AM Simon Glass  wrote:
>
> If locating the FSP header hangs for whatever reason it is useful to see
> where it got stuck. Add a debug print. Also show the address of the FSP-S
> entry point as a sanity check.
>
> Signed-off-by: Simon Glass 
> ---
>
> (no changes since v1)
>
>  arch/x86/lib/fsp2/fsp_silicon_init.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng 

[PATCH v3 52/57] x86: fsp: Add more debugging for silicon init

[Simon Glass]

If locating the FSP header hangs for whatever reason it is useful to see
where it got stuck. Add a debug print. Also show the address of the FSP-S
entry point as a sanity check.

Signed-off-by: Simon Glass 
---

(no changes since v1)

 arch/x86/lib/fsp2/fsp_silicon_init.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/lib/fsp2/fsp_silicon_init.c 
b/arch/x86/lib/fsp2/fsp_silicon_init.c
index 0f221a864fb..ead3493de82 100644
--- a/arch/x86/lib/fsp2/fsp_silicon_init.c
+++ b/arch/x86/lib/fsp2/fsp_silicon_init.c
@@ -26,8 +26,10 @@ int fsp_silicon_init(bool s3wake, bool use_spi_flash)
struct binman_entry entry;
struct udevice *dev;
ulong rom_offset = 0;
+   u32 init_addr;
int ret;
 
+   log_debug("Locating FSP\n");
ret = fsp_locate_fsp(FSP_S, , use_spi_flash, , ,
 _offset);
if (ret)
@@ -44,7 +46,7 @@ int fsp_silicon_init(bool s3wake, bool use_spi_flash)
ret = fsps_update_config(dev, rom_offset, );
if (ret)
return log_msg_ret("Could not setup config", ret);
-   log_debug("Silicon init...");
+   log_debug("Silicon init @ %x...", init_addr);
bootstage_start(BOOTSTAGE_ID_ACCUM_FSP_S, "fsp-s");
func = (fsp_silicon_init_func)(hdr->img_base + hdr->fsp_silicon_init);
ret = func();
-- 
2.28.0.526.ge36021eeef-goog