Re: [PATCH v4 3/5] qemu: add sandbox driver and tests

2021-02-25 Thread Simon Glass
On Tue, 23 Feb 2021 at 22:24, Asherah Connor  wrote:
>
> We minimally exercise the sandbox driver.
>
> Signed-off-by: Asherah Connor 
> ---
>
> (no changes since v1)
>
>  arch/sandbox/dts/sandbox.dtsi |   4 ++
>  arch/sandbox/dts/test.dts |   4 ++
>  drivers/misc/Makefile |   1 +
>  drivers/misc/qfw_sandbox.c| 129 ++
>  test/dm/Makefile  |   1 +
>  test/dm/qfw.c |  42 +++
>  6 files changed, 181 insertions(+)
>  create mode 100644 drivers/misc/qfw_sandbox.c
>  create mode 100644 test/dm/qfw.c
>

Reviewed-by: Simon Glass 


[PATCH v4 3/5] qemu: add sandbox driver and tests

2021-02-23 Thread Asherah Connor
We minimally exercise the sandbox driver.

Signed-off-by: Asherah Connor 
---

(no changes since v1)

 arch/sandbox/dts/sandbox.dtsi |   4 ++
 arch/sandbox/dts/test.dts |   4 ++
 drivers/misc/Makefile |   1 +
 drivers/misc/qfw_sandbox.c| 129 ++
 test/dm/Makefile  |   1 +
 test/dm/qfw.c |  42 +++
 6 files changed, 181 insertions(+)
 create mode 100644 drivers/misc/qfw_sandbox.c
 create mode 100644 test/dm/qfw.c

diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi
index dc933f3bfc..7ce05b9662 100644
--- a/arch/sandbox/dts/sandbox.dtsi
+++ b/arch/sandbox/dts/sandbox.dtsi
@@ -390,6 +390,10 @@
sandbox_tee {
compatible = "sandbox,tee";
};
+
+   qfw {
+   compatible = "sandbox,qemu-fw-cfg-mmio";
+   };
 };
 
 _ec {
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index d4195b45bb..4b3f8831d5 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -112,6 +112,10 @@
compatible = "sandbox,dsi-host";
};
 
+   qfw {
+   compatible = "sandbox,qemu-fw-cfg-mmio";
+   };
+
a-test {
reg = <0 1>;
compatible = "denx,u-boot-fdt-test";
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 2988289ea3..c48f61b797 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -59,6 +59,7 @@ ifdef CONFIG_QFW
 obj-y += qfw.o
 obj-$(CONFIG_X86) += qfw_pio.o
 obj-$(CONFIG_ARM) += qfw_mmio.o
+obj-$(CONFIG_SANDBOX) += qfw_sandbox.o
 endif
 obj-$(CONFIG_ROCKCHIP_EFUSE) += rockchip-efuse.o
 obj-$(CONFIG_ROCKCHIP_OTP) += rockchip-otp.o
diff --git a/drivers/misc/qfw_sandbox.c b/drivers/misc/qfw_sandbox.c
new file mode 100644
index 00..fc7006ae19
--- /dev/null
+++ b/drivers/misc/qfw_sandbox.c
@@ -0,0 +1,129 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Sandbox interface for QFW
+ *
+ * (C) Copyright 2015 Miao Yan 
+ * (C) Copyright 2021 Asherah Connor 
+ */
+
+#define LOG_CATEGORY UCLASS_QFW
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+struct qfw_sandbox_plat {
+   u8 file_dir_offset;
+};
+
+static void qfw_sandbox_read_entry_io(struct udevice *dev, u16 entry, u32 size,
+ void *address)
+{
+   debug("%s: entry 0x%x size %u address %p\n", __func__, entry, size,
+ address);
+
+   switch (entry) {
+   case FW_CFG_SIGNATURE:
+   if (size == 4)
+   *((u32 *)address) = cpu_to_be32(QEMU_FW_CFG_SIGNATURE);
+   break;
+   case FW_CFG_ID:
+   /* Advertise DMA support */
+   if (size == 1)
+   *((u8 *)address) = FW_CFG_DMA_ENABLED;
+   break;
+   default:
+   debug("%s got unsupported entry 0x%x\n", __func__, entry);
+   /*
+* Sandbox driver doesn't support other entries here, assume we use DMA
+* to read them -- the uclass driver will exclusively use it when
+* advertised.
+*/
+   }
+}
+
+static void qfw_sandbox_read_entry_dma(struct udevice *dev, struct qfw_dma 
*dma)
+{
+   u16 entry;
+   u32 control = be32_to_cpu(dma->control);
+   void *address = (void *)be64_to_cpu(dma->address);
+   u32 length = be32_to_cpu(dma->length);
+   struct qfw_sandbox_plat *plat = dev_get_plat(dev);
+   struct fw_cfg_file *file;
+
+   debug("%s\n", __func__);
+
+   if (!(control & FW_CFG_DMA_READ))
+   return;
+
+   if (control & FW_CFG_DMA_SELECT) {
+   /* Start new read. */
+   entry = control >> 16;
+
+   /* Arbitrary values to be used by tests. */
+   switch (entry) {
+   case FW_CFG_NB_CPUS:
+   if (length == 2)
+   *((u16 *)address) = cpu_to_le16(5);
+   break;
+   case FW_CFG_FILE_DIR:
+   if (length == 4) {
+   *((u32 *)address) = cpu_to_be32(2);
+   plat->file_dir_offset = 1;
+   }
+   break;
+   default:
+   debug("%s got unsupported entry 0x%x\n", __func__,
+ entry);
+   }
+   } else if (plat->file_dir_offset && length == 64) {
+   file = address;
+   switch (plat->file_dir_offset) {
+   case 1:
+   file->size = cpu_to_be32(8);
+   file->select = cpu_to_be16(FW_CFG_FILE_FIRST);
+   strcpy(file->name, "test-one");
+   plat->file_dir_offset++;
+   break;
+   case 2:
+   file->size = cpu_to_be32(8);
+   file->select = cpu_to_be16(FW_CFG_FILE_FIRST + 1);
+