Re: [PATCH v5 0/6] ARM: arbitrary virtual-physical mappings for RPi4 XHCI support
Hi Marek, On 09/07/2020 08:33, Marek Szyprowski wrote: Hi Matthias, On 11.06.2020 10:39, Matthias Brugger wrote: ... Series looks good to me. The problem is that on RPi4 with 8 GB the USB FW get's loaded via the RPi FW. Nicolas provided a series which is under review right now. Without this series the 8 GB RPi4 won't boot. As soon as the series is ready I'll take all the RPi4 PCI/USB related patches into the next branch. I've noticed that You took both required patchsets to rpi-next branch. May I ask for taking this one too? I didn't forgot that series. The thing is, that it is assigned to Tom in patchwork, so I wanted to sync with him, if he is OK that I take the series. He provided already his Reviewed-by tags for the parts that I was concerned about. @Tom, is it OK if I take this series through my rpi-next branch? Regards, Matthias
Re: [PATCH v5 0/6] ARM: arbitrary virtual-physical mappings for RPi4 XHCI support
Hi Matthias, On 11.06.2020 10:39, Matthias Brugger wrote: > ... > Series looks good to me. The problem is that on RPi4 with 8 GB the USB FW > get's > loaded via the RPi FW. Nicolas provided a series which is under review right > now. Without this series the 8 GB RPi4 won't boot. As soon as the series is > ready I'll take all the RPi4 PCI/USB related patches into the next branch. I've noticed that You took both required patchsets to rpi-next branch. May I ask for taking this one too? Best regards -- Marek Szyprowski, PhD Samsung R Institute Poland
Re: [PATCH v5 0/6] ARM: arbitrary virtual-physical mappings for RPi4 XHCI support
On 03/06/2020 14:43, Marek Szyprowski wrote: > Hi All, > > This patchset adds support for creating a mapping for the arbitrary > physical address at the given virtual address. This is needed to enable > support for XHCI USB controller on PCIe bridge on Raspberry Pi 4 board, > on which the USB controller's MMIO area 0x6 has to be remapped > somewhere to fit in 4GiB virtual address space when running in ARM 32bit > mode. > > This patchset is a continuation of the Raspberry Pi 4 XHCI/PCIe patchset: > https://patchwork.ozlabs.org/project/uboot/list/?series=179078 > and the following discussion: > https://lists.denx.de/pipermail/u-boot/2020-May/411086.html > > Best regards > Marek Szyprowski > Samsung R Institute Poland > > > Changelog: > > v5: > - fixed issues pointed by Tom Rini (comments style, ifdefs, spdx) > > v4: https://lists.denx.de/pipermail/u-boot/2020-June/414531.html > - added a patch, which moves ADDR_MAP config entry to Kconfig system > as requested by Simon Glass > - rebased onto v4 of the "USB host support for Raspberry Pi 4 board > (64-bit)" patchset > > v3: https://lists.denx.de/pipermail/u-boot/2020-May/412427.html > - fixed broken RPi3 and lack of the identity mapping for map_physmem > (for example for the itest command was broken) > - added a patch fixing a new build warning > > v2: https://lists.denx.de/pipermail/u-boot/2020-May/411765.html > - fixed ARM64 build > > v1: https://lists.denx.de/pipermail/u-boot/2020-May/411765.html > - initial RFC > > > Patch summary: > > Marek Szyprowski (5): > powerpc: move ADDR_MAP to Kconfig > arm: update comments to the common style > arm: provide a function for boards init code to modify MMU > virtual-physical map > rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM > 32bit) > config: Enable support for the XHCI controller on RPI4 board > > Seung-Woo Kim (1): > mmc: bcm283x: fix int to pointer cast > Series looks good to me. The problem is that on RPi4 with 8 GB the USB FW get's loaded via the RPi FW. Nicolas provided a series which is under review right now. Without this series the 8 GB RPi4 won't boot. As soon as the series is ready I'll take all the RPi4 PCI/USB related patches into the next branch. Regards, Matthias > arch/arm/include/asm/mmu.h | 8 + > arch/arm/include/asm/system.h | 36 > -- > arch/arm/lib/cache-cp15.c | 24 +++ > arch/arm/mach-bcm283x/Kconfig | 1 + > arch/arm/mach-bcm283x/include/mach/base.h | 8 + > arch/arm/mach-bcm283x/init.c | 21 + > configs/B4420QDS_NAND_defconfig| 2 ++ > configs/B4420QDS_SPIFLASH_defconfig| 2 ++ > configs/B4420QDS_defconfig | 2 ++ > configs/B4860QDS_NAND_defconfig| 2 ++ > configs/B4860QDS_SECURE_BOOT_defconfig | 2 ++ > configs/B4860QDS_SPIFLASH_defconfig| 2 ++ > configs/B4860QDS_SRIO_PCIE_BOOT_defconfig | 2 ++ > configs/B4860QDS_defconfig | 2 ++ > configs/C29XPCIE_NAND_defconfig| 1 + > configs/C29XPCIE_NOR_SECBOOT_defconfig | 1 + > configs/C29XPCIE_SPIFLASH_SECBOOT_defconfig| 1 + > configs/C29XPCIE_SPIFLASH_defconfig| 1 + > configs/C29XPCIE_defconfig | 1 + > configs/Cyrus_P5020_defconfig | 2 ++ > configs/Cyrus_P5040_defconfig | 2 ++ > configs/MPC8536DS_36BIT_defconfig | 1 + > configs/MPC8548CDS_36BIT_defconfig | 1 + > configs/MPC8572DS_36BIT_defconfig | 1 + > configs/MPC8641HPCN_36BIT_defconfig| 2 ++ > configs/MPC8641HPCN_defconfig | 2 ++ > configs/P1010RDB-PA_36BIT_NAND_SECBOOT_defconfig | 1 + > configs/P1010RDB-PA_36BIT_NAND_defconfig | 1 + > configs/P1010RDB-PA_36BIT_NOR_SECBOOT_defconfig| 1 + > configs/P1010RDB-PA_36BIT_NOR_defconfig| 1 + > configs/P1010RDB-PA_36BIT_SDCARD_defconfig | 1 + > .../P1010RDB-PA_36BIT_SPIFLASH_SECBOOT_defconfig | 1 + > configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig | 1 + > configs/P1010RDB-PB_36BIT_NAND_SECBOOT_defconfig | 1 + > configs/P1010RDB-PB_36BIT_NAND_defconfig | 1 + > configs/P1010RDB-PB_36BIT_NOR_SECBOOT_defconfig| 1 + > configs/P1010RDB-PB_36BIT_NOR_defconfig| 1 + > configs/P1010RDB-PB_36BIT_SDCARD_defconfig | 1 + > .../P1010RDB-PB_36BIT_SPIFLASH_SECBOOT_defconfig | 1 + > configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig | 1 + > configs/P1020MBG-PC_36BIT_SDCARD_defconfig | 1 + > configs/P1020MBG-PC_36BIT_defconfig| 1 + > configs/P1020RDB-PC_36BIT_NAND_defconfig | 1 + >
[PATCH v5 0/6] ARM: arbitrary virtual-physical mappings for RPi4 XHCI support
Hi All, This patchset adds support for creating a mapping for the arbitrary physical address at the given virtual address. This is needed to enable support for XHCI USB controller on PCIe bridge on Raspberry Pi 4 board, on which the USB controller's MMIO area 0x6 has to be remapped somewhere to fit in 4GiB virtual address space when running in ARM 32bit mode. This patchset is a continuation of the Raspberry Pi 4 XHCI/PCIe patchset: https://patchwork.ozlabs.org/project/uboot/list/?series=179078 and the following discussion: https://lists.denx.de/pipermail/u-boot/2020-May/411086.html Best regards Marek Szyprowski Samsung R Institute Poland Changelog: v5: - fixed issues pointed by Tom Rini (comments style, ifdefs, spdx) v4: https://lists.denx.de/pipermail/u-boot/2020-June/414531.html - added a patch, which moves ADDR_MAP config entry to Kconfig system as requested by Simon Glass - rebased onto v4 of the "USB host support for Raspberry Pi 4 board (64-bit)" patchset v3: https://lists.denx.de/pipermail/u-boot/2020-May/412427.html - fixed broken RPi3 and lack of the identity mapping for map_physmem (for example for the itest command was broken) - added a patch fixing a new build warning v2: https://lists.denx.de/pipermail/u-boot/2020-May/411765.html - fixed ARM64 build v1: https://lists.denx.de/pipermail/u-boot/2020-May/411765.html - initial RFC Patch summary: Marek Szyprowski (5): powerpc: move ADDR_MAP to Kconfig arm: update comments to the common style arm: provide a function for boards init code to modify MMU virtual-physical map rpi4: add a mapping for the PCIe XHCI controller MMIO registers (ARM 32bit) config: Enable support for the XHCI controller on RPI4 board Seung-Woo Kim (1): mmc: bcm283x: fix int to pointer cast arch/arm/include/asm/mmu.h | 8 + arch/arm/include/asm/system.h | 36 -- arch/arm/lib/cache-cp15.c | 24 +++ arch/arm/mach-bcm283x/Kconfig | 1 + arch/arm/mach-bcm283x/include/mach/base.h | 8 + arch/arm/mach-bcm283x/init.c | 21 + configs/B4420QDS_NAND_defconfig| 2 ++ configs/B4420QDS_SPIFLASH_defconfig| 2 ++ configs/B4420QDS_defconfig | 2 ++ configs/B4860QDS_NAND_defconfig| 2 ++ configs/B4860QDS_SECURE_BOOT_defconfig | 2 ++ configs/B4860QDS_SPIFLASH_defconfig| 2 ++ configs/B4860QDS_SRIO_PCIE_BOOT_defconfig | 2 ++ configs/B4860QDS_defconfig | 2 ++ configs/C29XPCIE_NAND_defconfig| 1 + configs/C29XPCIE_NOR_SECBOOT_defconfig | 1 + configs/C29XPCIE_SPIFLASH_SECBOOT_defconfig| 1 + configs/C29XPCIE_SPIFLASH_defconfig| 1 + configs/C29XPCIE_defconfig | 1 + configs/Cyrus_P5020_defconfig | 2 ++ configs/Cyrus_P5040_defconfig | 2 ++ configs/MPC8536DS_36BIT_defconfig | 1 + configs/MPC8548CDS_36BIT_defconfig | 1 + configs/MPC8572DS_36BIT_defconfig | 1 + configs/MPC8641HPCN_36BIT_defconfig| 2 ++ configs/MPC8641HPCN_defconfig | 2 ++ configs/P1010RDB-PA_36BIT_NAND_SECBOOT_defconfig | 1 + configs/P1010RDB-PA_36BIT_NAND_defconfig | 1 + configs/P1010RDB-PA_36BIT_NOR_SECBOOT_defconfig| 1 + configs/P1010RDB-PA_36BIT_NOR_defconfig| 1 + configs/P1010RDB-PA_36BIT_SDCARD_defconfig | 1 + .../P1010RDB-PA_36BIT_SPIFLASH_SECBOOT_defconfig | 1 + configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig | 1 + configs/P1010RDB-PB_36BIT_NAND_SECBOOT_defconfig | 1 + configs/P1010RDB-PB_36BIT_NAND_defconfig | 1 + configs/P1010RDB-PB_36BIT_NOR_SECBOOT_defconfig| 1 + configs/P1010RDB-PB_36BIT_NOR_defconfig| 1 + configs/P1010RDB-PB_36BIT_SDCARD_defconfig | 1 + .../P1010RDB-PB_36BIT_SPIFLASH_SECBOOT_defconfig | 1 + configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig | 1 + configs/P1020MBG-PC_36BIT_SDCARD_defconfig | 1 + configs/P1020MBG-PC_36BIT_defconfig| 1 + configs/P1020RDB-PC_36BIT_NAND_defconfig | 1 + configs/P1020RDB-PC_36BIT_SDCARD_defconfig | 1 + configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig | 1 + configs/P1020RDB-PC_36BIT_defconfig| 1 + configs/P1020UTM-PC_36BIT_SDCARD_defconfig | 1 + configs/P1020UTM-PC_36BIT_defconfig| 1 + configs/P1021RDB-PC_36BIT_NAND_defconfig | 1 + configs/P1021RDB-PC_36BIT_SDCARD_defconfig | 1 + configs/P1021RDB-PC_36BIT_SPIFLASH_defconfig | 1 + configs/P1021RDB-PC_36BIT_defconfig| 1 + configs/P1022DS_36BIT_NAND_defconfig | 1 +
