Re: [PATCH v5 01/12] arm: mvebu: fix SerDes table alignment

[Stefan Roese]

On 27.01.20 21:01, Joel Johnson wrote:

Tested on Solidrun ClearFog Base. Table alignment was:
  | Lane #  | Speed |  Type   |
  
  |   0|  3   |  SATA0   |
  |   1|  0   |  SGMII1  |
  |   2|  3   |  SATA1   |
  |   3|  5   |  USB3 HOST1  |
  |   4|  5   |  USB3 HOST0  |
  |   5|  4   |  SGMII2  |
  

After the change, it's correctly aligned as:
  | Lane # | Speed |  Type   |
  
  |   0|   3   | SATA0   |
  |   1|   0   | SGMII1  |
  |   2|   5   | PCIe1   |
  |   3|   5   | USB3 HOST1  |
  |   4|   5   | PCIe2   |
  |   5|   0   | SGMII2  |
  

Signed-off-by: Joel Johnson 


Reviewed-by: Stefan Roese 

Thanks,
Stefan

[PATCH v5 01/12] arm: mvebu: fix SerDes table alignment

[Joel Johnson]

Tested on Solidrun ClearFog Base. Table alignment was:
 | Lane #  | Speed |  Type   |
 
 |   0|  3   |  SATA0   |
 |   1|  0   |  SGMII1  |
 |   2|  3   |  SATA1   |
 |   3|  5   |  USB3 HOST1  |
 |   4|  5   |  USB3 HOST0  |
 |   5|  4   |  SGMII2  |
 

After the change, it's correctly aligned as:
 | Lane # | Speed |  Type   |
 
 |   0|   3   | SATA0   |
 |   1|   0   | SGMII1  |
 |   2|   5   | PCIe1   |
 |   3|   5   | USB3 HOST1  |
 |   4|   5   | PCIe2   |
 |   5|   0   | SGMII2  |
 

Signed-off-by: Joel Johnson 

---

v2 changes
  - none
v3 changes
  - none
v4 changes
  - none
v5 changes
  - none

---
 arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c 
b/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c
index 33e70569bc..66409a50c0 100644
--- a/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c
+++ b/arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c
@@ -1366,16 +1366,16 @@ static void print_topology_details(const struct 
serdes_map *serdes_map,
 
DEBUG_INIT_S("board SerDes lanes topology details:\n");
 
-   DEBUG_INIT_S(" | Lane #  | Speed |  Type   |\n");
+   DEBUG_INIT_S(" | Lane # | Speed |  Type   |\n");
DEBUG_INIT_S(" \n");
for (lane_num = 0; lane_num < count; lane_num++) {
if (serdes_map[lane_num].serdes_type == DEFAULT_SERDES)
continue;
DEBUG_INIT_S(" |   ");
DEBUG_INIT_D(hws_get_physical_serdes_num(lane_num), 1);
-   DEBUG_INIT_S("|  ");
+   DEBUG_INIT_S("|   ");
DEBUG_INIT_D(serdes_map[lane_num].serdes_speed, 2);
-   DEBUG_INIT_S("   |  ");
+   DEBUG_INIT_S("   | ");
DEBUG_INIT_S((char *)
 serdes_type_to_string[serdes_map[lane_num].
   serdes_type]);
-- 
2.20.1