Re: [PATCH v6 02/18] video: tegra20: dc: fix image shift on rotated panels

[Thierry Reding]

On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote:
> Subtracting 1 from x and y fixes image shifting on rotated
> panels.
>
> Tested-by: Robert Eckelmann  # ASUS Grouper E1565
> Signed-off-by: Svyatoslav Ryhel 
> ---
>  drivers/video/tegra20/tegra-dc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Yeah, looks like we have that same fixup in Linux:

Reviewed-by: Thierry Reding 


signature.asc
Description: PGP signature

[PATCH v6 02/18] video: tegra20: dc: fix image shift on rotated panels

[Svyatoslav Ryhel]

Subtracting 1 from x and y fixes image shifting on rotated
panels.

Tested-by: Robert Eckelmann  # ASUS Grouper E1565
Signed-off-by: Svyatoslav Ryhel 
---
 drivers/video/tegra20/tegra-dc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/tegra20/tegra-dc.c b/drivers/video/tegra20/tegra-dc.c
index 7605e77bc1..bcc2748623 100644
--- a/drivers/video/tegra20/tegra-dc.c
+++ b/drivers/video/tegra20/tegra-dc.c
@@ -242,8 +242,8 @@ static int setup_window(struct tegra_lcd_priv *priv,
struct disp_ctl_win *win)
 {
if (priv->rotation) {
-   win->x = priv->width * 2;
-   win->y = priv->height;
+   win->x = priv->width * 2 - 1;
+   win->y = priv->height - 1;
} else {
win->x = 0;
win->y = 0;
-- 
2.40.1