Re: [PATCH v6 037/102] x86: Move fsp_prepare_mrc_cache() to fsp1 directory

2019-12-07 Thread Bin Meng
On Sat, Dec 7, 2019 at 12:48 PM Simon Glass  wrote:
>
> This function needs to be different for FSP2, so move the existing
> function into the fsp1 directory. Since it is only called from one file,
> drop it from the header file.
>
> Signed-off-by: Simon Glass 
> Reviewed-by: Bin Meng 
> ---
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  arch/x86/include/asm/fsp/fsp_support.h |  7 ---
>  arch/x86/lib/fsp/fsp_common.c  | 20 
>  arch/x86/lib/fsp1/fsp_common.c | 20 
>  3 files changed, 20 insertions(+), 27 deletions(-)
>

applied to u-boot-x86/next, thanks!


[PATCH v6 037/102] x86: Move fsp_prepare_mrc_cache() to fsp1 directory

2019-12-06 Thread Simon Glass
This function needs to be different for FSP2, so move the existing
function into the fsp1 directory. Since it is only called from one file,
drop it from the header file.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng 
---

Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 arch/x86/include/asm/fsp/fsp_support.h |  7 ---
 arch/x86/lib/fsp/fsp_common.c  | 20 
 arch/x86/lib/fsp1/fsp_common.c | 20 
 3 files changed, 20 insertions(+), 27 deletions(-)

diff --git a/arch/x86/include/asm/fsp/fsp_support.h 
b/arch/x86/include/asm/fsp/fsp_support.h
index 4ac27d26f5..29e511415c 100644
--- a/arch/x86/include/asm/fsp/fsp_support.h
+++ b/arch/x86/include/asm/fsp/fsp_support.h
@@ -143,13 +143,6 @@ int fsp_init_phase_pci(void);
  */
 int fsp_scan_for_ram_size(void);
 
-/**
- * fsp_prepare_mrc_cache() - Find the DRAM training data from the MRC cache
- *
- * @return pointer to data, or NULL if no cache or no data found in the cache
- */
-void *fsp_prepare_mrc_cache(void);
-
 /**
  * fsp_notify() - FSP notification wrapper function
  *
diff --git a/arch/x86/lib/fsp/fsp_common.c b/arch/x86/lib/fsp/fsp_common.c
index 4c5358e1d2..5eff0f99aa 100644
--- a/arch/x86/lib/fsp/fsp_common.c
+++ b/arch/x86/lib/fsp/fsp_common.c
@@ -58,26 +58,6 @@ void board_final_cleanup(void)
debug("OK\n");
 }
 
-void *fsp_prepare_mrc_cache(void)
-{
-   struct mrc_data_container *cache;
-   struct mrc_region entry;
-   int ret;
-
-   ret = mrccache_get_region(MRC_TYPE_NORMAL, NULL, );
-   if (ret)
-   return NULL;
-
-   cache = mrccache_find_current();
-   if (!cache)
-   return NULL;
-
-   debug("%s: mrc cache at %p, size %x checksum %04x\n", __func__,
- cache->data, cache->data_size, cache->checksum);
-
-   return cache->data;
-}
-
 #ifdef CONFIG_HAVE_ACPI_RESUME
 int fsp_save_s3_stack(void)
 {
diff --git a/arch/x86/lib/fsp1/fsp_common.c b/arch/x86/lib/fsp1/fsp_common.c
index e8066d8de3..ec9c218778 100644
--- a/arch/x86/lib/fsp1/fsp_common.c
+++ b/arch/x86/lib/fsp1/fsp_common.c
@@ -18,6 +18,26 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+static void *fsp_prepare_mrc_cache(void)
+{
+   struct mrc_data_container *cache;
+   struct mrc_region entry;
+   int ret;
+
+   ret = mrccache_get_region(MRC_TYPE_NORMAL, NULL, );
+   if (ret)
+   return NULL;
+
+   cache = mrccache_find_current();
+   if (!cache)
+   return NULL;
+
+   debug("%s: mrc cache at %p, size %x checksum %04x\n", __func__,
+ cache->data, cache->data_size, cache->checksum);
+
+   return cache->data;
+}
+
 int arch_fsp_init(void)
 {
void *nvs;
-- 
2.24.0.393.g34dc348eaf-goog