Re: [PATCH v8 09/16] board: ti: j784s4: Add board support for J784S4 EVM

2024-01-23 Thread Apurva Nandan 

Hi Nishanth

On 20/01/24 01:09, Nishanth Menon wrote:

On 23:20-20240119, Apurva Nandan wrote:

Add board files for J784S4 EVM.

SYS_DISABLE_DCACHE_OPS is selected in the Kconfig because
J784S4/AM69 are a coherent architecture at A72 level by
MSMC support.

Signed-off-by: Hari Nagalla 
[ add env and board specific yaml files for binman ]

Neither of them are part of this patch?

Signed-off-by: Neha Malcom Francis 
[ cleaned up the env files ]

no env file in this patch?

Will fix.



Signed-off-by: Manorit Chawdhry 
Signed-off-by: Dasnavis Sabiya 
Signed-off-by: Apurva Nandan 
Reviewed-by: Tom Rini 

[...]


diff --git a/board/ti/j784s4/MAINTAINERS b/board/ti/j784s4/MAINTAINERS
new file mode 100644
index 00..9e0df11503
--- /dev/null
+++ b/board/ti/j784s4/MAINTAINERS
@@ -0,0 +1,14 @@
+J784S4 EVM BOARD
+M: Apurva Nandan 
+S: Maintained
+F: board/ti/j784s4
+F: arch/arm/mach-k3/j784s4
+F: include/configs/j784s4_evm.h
+F: arch/arm/dts/k3-j784s4.dtsi
+F: arch/arm/dts/k3-j784s4-main.dtsi
+F: arch/arm/dts/k3-j784s4-mcu-wakeup.dtsi
+F: arch/arm/dts/k3-j784s4-thermal.dtsi
+F: arch/arm/dts/k3-j784s4-evm.dts
+
+AM69 SK BOARD

Don't all entries need a maintainer? I am not actually sure if the above
M will fall through for SK board.

Okay, will add M for AM69 as well.



+F: arch/arm/dts/k3-am69-sk.dts
diff --git a/board/ti/j784s4/Makefile b/board/ti/j784s4/Makefile
new file mode 100644
index 00..60161a8b5c
--- /dev/null
+++ b/board/ti/j784s4/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
+#  Hari Nagalla 
+#
+
+obj-y += evm.o
diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c
new file mode 100644
index 00..5af3e21ff0
--- /dev/null
+++ b/board/ti/j784s4/evm.c
@@ -0,0 +1,43 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Board specific initialization for J784S4 EVM
+ *
+ * Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
+ * Hari Nagalla 
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 

Are you sure we need all the above headers?

Ok, will cleanup



+#include "../common/fdt_ops.h"

[...]


--
Regards,
Apurva Nandan,
Texas Instruments.

Re: [PATCH v8 09/16] board: ti: j784s4: Add board support for J784S4 EVM

2024-01-19 Thread Nishanth Menon 
On 23:20-20240119, Apurva Nandan wrote:
> Add board files for J784S4 EVM.
> 
> SYS_DISABLE_DCACHE_OPS is selected in the Kconfig because
> J784S4/AM69 are a coherent architecture at A72 level by
> MSMC support.
> 
> Signed-off-by: Hari Nagalla 
> [ add env and board specific yaml files for binman ]
Neither of them are part of this patch?
> Signed-off-by: Neha Malcom Francis 
> [ cleaned up the env files ]
no env file in this patch?

> Signed-off-by: Manorit Chawdhry 
> Signed-off-by: Dasnavis Sabiya 
> Signed-off-by: Apurva Nandan 
> Reviewed-by: Tom Rini 

[...]

> diff --git a/board/ti/j784s4/MAINTAINERS b/board/ti/j784s4/MAINTAINERS
> new file mode 100644
> index 00..9e0df11503
> --- /dev/null
> +++ b/board/ti/j784s4/MAINTAINERS
> @@ -0,0 +1,14 @@
> +J784S4 EVM BOARD
> +M:   Apurva Nandan 
> +S:   Maintained
> +F:   board/ti/j784s4
> +F:   arch/arm/mach-k3/j784s4
> +F:   include/configs/j784s4_evm.h
> +F:   arch/arm/dts/k3-j784s4.dtsi
> +F:   arch/arm/dts/k3-j784s4-main.dtsi
> +F:   arch/arm/dts/k3-j784s4-mcu-wakeup.dtsi
> +F:   arch/arm/dts/k3-j784s4-thermal.dtsi
> +F:   arch/arm/dts/k3-j784s4-evm.dts
> +
> +AM69 SK BOARD
Don't all entries need a maintainer? I am not actually sure if the above
M will fall through for SK board.

> +F:   arch/arm/dts/k3-am69-sk.dts
> diff --git a/board/ti/j784s4/Makefile b/board/ti/j784s4/Makefile
> new file mode 100644
> index 00..60161a8b5c
> --- /dev/null
> +++ b/board/ti/j784s4/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +#
> +# Copyright (C) 2023-2024 Texas Instruments Incorporated - 
> https://www.ti.com/
> +#Hari Nagalla 
> +#
> +
> +obj-y += evm.o
> diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c
> new file mode 100644
> index 00..5af3e21ff0
> --- /dev/null
> +++ b/board/ti/j784s4/evm.c
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Board specific initialization for J784S4 EVM
> + *
> + * Copyright (C) 2023-2024 Texas Instruments Incorporated - 
> https://www.ti.com/
> + *   Hari Nagalla 
> + *
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 

Are you sure we need all the above headers?

> +#include "../common/fdt_ops.h"
[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 
849D 1736 249D

[PATCH v8 09/16] board: ti: j784s4: Add board support for J784S4 EVM

2024-01-19 Thread Apurva Nandan 
Add board files for J784S4 EVM.

SYS_DISABLE_DCACHE_OPS is selected in the Kconfig because
J784S4/AM69 are a coherent architecture at A72 level by
MSMC support.

Signed-off-by: Hari Nagalla 
[ add env and board specific yaml files for binman ]
Signed-off-by: Neha Malcom Francis 
[ cleaned up the env files ]
Signed-off-by: Manorit Chawdhry 
Signed-off-by: Dasnavis Sabiya 
Signed-off-by: Apurva Nandan 
Reviewed-by: Tom Rini 
---
 arch/arm/mach-k3/Kconfig|  1 +
 arch/arm/mach-k3/j784s4/Kconfig | 34 ++
 board/ti/j784s4/Kconfig | 37 
 board/ti/j784s4/MAINTAINERS | 14 +++
 board/ti/j784s4/Makefile|  7 ++
 board/ti/j784s4/evm.c   | 43 +
 include/configs/j784s4_evm.h| 15 
 7 files changed, 151 insertions(+)
 create mode 100644 arch/arm/mach-k3/j784s4/Kconfig
 create mode 100644 board/ti/j784s4/Kconfig
 create mode 100644 board/ti/j784s4/MAINTAINERS
 create mode 100644 board/ti/j784s4/Makefile
 create mode 100644 board/ti/j784s4/evm.c
 create mode 100644 include/configs/j784s4_evm.h

diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig
index 217def3bb4..fdde67c2d3 100644
--- a/arch/arm/mach-k3/Kconfig
+++ b/arch/arm/mach-k3/Kconfig
@@ -157,5 +157,6 @@ source "arch/arm/mach-k3/am62x/Kconfig"
 source "arch/arm/mach-k3/am62ax/Kconfig"
 source "arch/arm/mach-k3/j721e/Kconfig"
 source "arch/arm/mach-k3/j721s2/Kconfig"
+source "arch/arm/mach-k3/j784s4/Kconfig"
 
 endif
diff --git a/arch/arm/mach-k3/j784s4/Kconfig b/arch/arm/mach-k3/j784s4/Kconfig
new file mode 100644
index 00..1eadfb346a
--- /dev/null
+++ b/arch/arm/mach-k3/j784s4/Kconfig
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
+#  Hari Nagalla 
+
+if SOC_K3_J784S4
+
+choice
+   prompt "K3 J784S4 board"
+   optional
+
+config TARGET_J784S4_A72_EVM
+   bool "TI K3 based J784S4 EVM running on A72"
+   select ARM64
+   select BOARD_LATE_INIT
+   select SYS_DISABLE_DCACHE_OPS
+   select BINMAN
+
+config TARGET_J784S4_R5_EVM
+   bool "TI K3 based J784S4 EVM running on R5"
+   select CPU_V7R
+   select SYS_THUMB_BUILD
+   select K3_LOAD_SYSFW
+   select RAM
+   select SPL_RAM
+   select K3_DDRSS
+   select BINMAN
+   imply SYS_K3_SPL_ATF
+
+endchoice
+
+source "board/ti/j784s4/Kconfig"
+
+endif
diff --git a/board/ti/j784s4/Kconfig b/board/ti/j784s4/Kconfig
new file mode 100644
index 00..490c7be66b
--- /dev/null
+++ b/board/ti/j784s4/Kconfig
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
+#  Hari Nagalla 
+
+if TARGET_J784S4_A72_EVM
+
+config SYS_BOARD
+   default "j784s4"
+
+config SYS_VENDOR
+   default "ti"
+
+config SYS_CONFIG_NAME
+   default "j784s4_evm"
+
+source "board/ti/common/Kconfig"
+
+endif
+
+if TARGET_J784S4_R5_EVM
+
+config SYS_BOARD
+   default "j784s4"
+
+config SYS_VENDOR
+   default "ti"
+
+config SYS_CONFIG_NAME
+   default "j784s4_evm"
+
+config SPL_LDSCRIPT
+   default "arch/arm/mach-omap2/u-boot-spl.lds"
+
+source "board/ti/common/Kconfig"
+
+endif
diff --git a/board/ti/j784s4/MAINTAINERS b/board/ti/j784s4/MAINTAINERS
new file mode 100644
index 00..9e0df11503
--- /dev/null
+++ b/board/ti/j784s4/MAINTAINERS
@@ -0,0 +1,14 @@
+J784S4 EVM BOARD
+M: Apurva Nandan 
+S: Maintained
+F: board/ti/j784s4
+F: arch/arm/mach-k3/j784s4
+F: include/configs/j784s4_evm.h
+F: arch/arm/dts/k3-j784s4.dtsi
+F: arch/arm/dts/k3-j784s4-main.dtsi
+F: arch/arm/dts/k3-j784s4-mcu-wakeup.dtsi
+F: arch/arm/dts/k3-j784s4-thermal.dtsi
+F: arch/arm/dts/k3-j784s4-evm.dts
+
+AM69 SK BOARD
+F: arch/arm/dts/k3-am69-sk.dts
diff --git a/board/ti/j784s4/Makefile b/board/ti/j784s4/Makefile
new file mode 100644
index 00..60161a8b5c
--- /dev/null
+++ b/board/ti/j784s4/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
+#  Hari Nagalla 
+#
+
+obj-y += evm.o
diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c
new file mode 100644
index 00..5af3e21ff0
--- /dev/null
+++ b/board/ti/j784s4/evm.c
@@ -0,0 +1,43 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Board specific initialization for J784S4 EVM
+ *
+ * Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
+ * Hari Nagalla 
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include "../common/fdt_ops.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int board_init(void)
+{
+   return 0;
+}
+
+int dram_init(void)
+{
+   return fdtdec_setup_mem_size_base();
+}
+
+int dram_init_banksize(void)
+{
+   return fdtdec_setup_memory_banksize();
+}
+
+#ifdef