RE: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h
Hi Wasim, Thanks a lot for your comments! > -Original Message- > From: Wasim Khan > Sent: 2020年4月21日 13:41 > To: Z.q. Hou ; u-boot@lists.denx.de; Priyanka Jain > ; Biwen Li > Cc: Z.q. Hou > Subject: RE: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h > > > > > -Original Message- > > From: U-Boot On Behalf Of Zhiqiang Hou > > Sent: Tuesday, March 24, 2020 1:42 PM > > To: u-boot@lists.denx.de; Priyanka Jain ; Biwen > > Li > > Cc: Z.q. Hou > > Subject: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h > > > > From: Hou Zhiqiang > > > > The declaration of the function cpu_numcores() has been moved to > > cpu_func.h, so add including of the header file to avoid build error. > > > > Signed-off-by: Hou Zhiqiang > > --- > > V2: > > - No change. > > > > board/freescale/lx2160a/lx2160a.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/board/freescale/lx2160a/lx2160a.c > > b/board/freescale/lx2160a/lx2160a.c > > index 134ae22f85..595c774b42 100644 > > --- a/board/freescale/lx2160a/lx2160a.c > > +++ b/board/freescale/lx2160a/lx2160a.c > > @@ -5,6 +5,7 @@ > > > > #include > > #include > > +#include > > cpu_func.h is already included in board/freescale/lx2160a/lx2160a.c. > You can remove this patch. Priyanka, please drop this patch if it had been there. Thanks, Zhiqiang > > > #include > > #include #include > > -- > > 2.17.1
RE: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h
> -Original Message- > From: U-Boot On Behalf Of Zhiqiang Hou > Sent: Tuesday, March 24, 2020 1:42 PM > To: u-boot@lists.denx.de; Priyanka Jain ; Biwen Li > > Cc: Z.q. Hou > Subject: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h > > From: Hou Zhiqiang > > The declaration of the function cpu_numcores() has been moved to cpu_func.h, > so add including of the header file to avoid build error. > > Signed-off-by: Hou Zhiqiang > --- > V2: > - No change. > > board/freescale/lx2160a/lx2160a.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/freescale/lx2160a/lx2160a.c > b/board/freescale/lx2160a/lx2160a.c > index 134ae22f85..595c774b42 100644 > --- a/board/freescale/lx2160a/lx2160a.c > +++ b/board/freescale/lx2160a/lx2160a.c > @@ -5,6 +5,7 @@ > > #include > #include > +#include cpu_func.h is already included in board/freescale/lx2160a/lx2160a.c. You can remove this patch. > #include > #include #include > -- > 2.17.1
[PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h
From: Hou Zhiqiang The declaration of the function cpu_numcores() has been moved to cpu_func.h, so add including of the header file to avoid build error. Signed-off-by: Hou Zhiqiang --- V2: - No change. board/freescale/lx2160a/lx2160a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/freescale/lx2160a/lx2160a.c b/board/freescale/lx2160a/lx2160a.c index 134ae22f85..595c774b42 100644 --- a/board/freescale/lx2160a/lx2160a.c +++ b/board/freescale/lx2160a/lx2160a.c @@ -5,6 +5,7 @@ #include #include +#include #include #include #include -- 2.17.1
