[U-Boot] [PATCH] [UPDATE #2] Merged serial_pl010.c and serial_pl011.c.

2008-09-08 Thread Andreas Engel
They only differ in the init function.
This also adds the missing watchdog support for the PL011.

Signed-off-by: Andreas Engel [EMAIL PROTECTED]
---

 Updated patch to the current git head as of today.

 drivers/serial/Makefile   |3 +-
 drivers/serial/serial_pl011.c |  161 -
 drivers/serial/{serial_pl010.c = serial_pl01x.c} |   83 +--
 drivers/serial/{serial_pl011.h = serial_pl01x.h} |0
 4 files changed, 69 insertions(+), 178 deletions(-)
 delete mode 100644 drivers/serial/serial_pl011.c
 rename drivers/serial/{serial_pl010.c = serial_pl01x.c} (66%)
 rename drivers/serial/{serial_pl011.h = serial_pl01x.h} (100%)

diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
index f30014d..3cc1999 100644
--- a/drivers/serial/Makefile
+++ b/drivers/serial/Makefile
@@ -33,8 +33,7 @@ COBJS-$(CONFIG_DRIVER_S3C4510_UART) += s3c4510b_uart.o
 COBJS-$(CONFIG_S3C64XX) += s3c64xx.o
 COBJS-y += serial.o
 COBJS-$(CONFIG_MAX3100_SERIAL) += serial_max3100.o
-COBJS-y += serial_pl010.o
-COBJS-y += serial_pl011.o
+COBJS-y += serial_pl01x.o
 COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o
 COBJS-$(CONFIG_SCIF_CONSOLE) += serial_sh.o
 COBJS-$(CONFIG_USB_TTY) += usbtty.o
diff --git a/drivers/serial/serial_pl011.c b/drivers/serial/serial_pl011.c
deleted file mode 100644
index 4d35fe5..000
--- a/drivers/serial/serial_pl011.c
+++ /dev/null
@@ -1,161 +0,0 @@
-/*
- * (C) Copyright 2000
- * Rob Taylor, Flying Pig Systems. [EMAIL PROTECTED]
- *
- * (C) Copyright 2004
- * ARM Ltd.
- * Philippe Robin, [EMAIL PROTECTED]
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-/* Simple U-Boot driver for the PrimeCell PL011 UARTs on the IntegratorCP */
-/* Should be fairly simple to make it work with the PL010 as well */
-
-#include common.h
-
-#ifdef CFG_PL011_SERIAL
-
-#include serial_pl011.h
-
-#define IO_WRITE(addr, val) (*(volatile unsigned int *)(addr) = (val))
-#define IO_READ(addr) (*(volatile unsigned int *)(addr))
-
-/*
- * IntegratorCP has two UARTs, use the first one, at 38400-8-N-1
- * Versatile PB has four UARTs.
- */
-
-#define CONSOLE_PORT CONFIG_CONS_INDEX
-#define baudRate CONFIG_BAUDRATE
-static volatile unsigned char *const port[] = CONFIG_PL01x_PORTS;
-#define NUM_PORTS (sizeof(port)/sizeof(port[0]))
-
-static void pl011_putc (int portnum, char c);
-static int pl011_getc (int portnum);
-static int pl011_tstc (int portnum);
-
-
-int serial_init (void)
-{
-   unsigned int temp;
-   unsigned int divider;
-   unsigned int remainder;
-   unsigned int fraction;
-
-   /*
-** First, disable everything.
-*/
-   IO_WRITE (port[CONSOLE_PORT] + UART_PL011_CR, 0x0);
-
-   /*
-** Set baud rate
-**
-** IBRD = UART_CLK / (16 * BAUD_RATE)
-** FBRD = ROUND((64 * MOD(UART_CLK,(16 * BAUD_RATE))) / (16 * 
BAUD_RATE))
-*/
-   temp = 16 * baudRate;
-   divider = CONFIG_PL011_CLOCK / temp;
-   remainder = CONFIG_PL011_CLOCK % temp;
-   temp = (8 * remainder) / baudRate;
-   fraction = (temp  1) + (temp  1);
-
-   IO_WRITE (port[CONSOLE_PORT] + UART_PL011_IBRD, divider);
-   IO_WRITE (port[CONSOLE_PORT] + UART_PL011_FBRD, fraction);
-
-   /*
-** Set the UART to be 8 bits, 1 stop bit, no parity, fifo enabled.
-*/
-   IO_WRITE (port[CONSOLE_PORT] + UART_PL011_LCRH,
- (UART_PL011_LCRH_WLEN_8 | UART_PL011_LCRH_FEN));
-
-   /*
-** Finally, enable the UART
-*/
-   IO_WRITE (port[CONSOLE_PORT] + UART_PL011_CR,
- (UART_PL011_CR_UARTEN | UART_PL011_CR_TXE |
-  UART_PL011_CR_RXE));
-
-   return 0;
-}
-
-void serial_putc (const char c)
-{
-   if (c == '\n')
-   pl011_putc (CONSOLE_PORT, '\r');
-
-   pl011_putc (CONSOLE_PORT, c);
-}
-
-void serial_puts (const char *s)
-{
-   while (*s) {
-   serial_putc (*s++);
-   }
-}
-
-int serial_getc (void)
-{
-   return pl011_getc (CONSOLE_PORT);
-}
-
-int serial_tstc (void)
-{
-   return pl011_tstc (CONSOLE_PORT);
-}
-
-void serial_setbrg (void)
-{
-}
-
-static void pl011_putc (int portnum, char c)
-{
-   /* Wait 

Re: [U-Boot] [PATCH] [UPDATE #2] Merged serial_pl010.c and serial_pl011.c.

2008-09-08 Thread Wolfgang Denk
Dear Andreas Engel,

In message [EMAIL PROTECTED] you wrote:
 Jean-Christophe PLAGNIOL-VILLARD wrote:
  On 10:17 Mon 08 Sep , Andreas Engel wrote:
  [...]
 
  -#ifdef CFG_PL010_SERIAL
  +#if defined(CFG_PL010_SERIAL) || defined(CFG_PL011_SERIAL)
  Please move this to the Makefile
 
 Shouldn't this better be a separate patch?

Yes, indeed.

Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
You have the capacity to learn from  mistakes.  You'll  learn  a  lot
today.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] [UPDATE #2] Merged serial_pl010.c and serial_pl011.c.

2008-09-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:17 Mon 08 Sep , Andreas Engel wrote:
 They only differ in the init function.
 This also adds the missing watchdog support for the PL011.
 
 Signed-off-by: Andreas Engel [EMAIL PROTECTED]
 ---
 
  Updated patch to the current git head as of today.
 
  drivers/serial/Makefile   |3 +-
  drivers/serial/serial_pl011.c |  161 
 -
  drivers/serial/{serial_pl010.c = serial_pl01x.c} |   83 +--
  drivers/serial/{serial_pl011.h = serial_pl01x.h} |0
  4 files changed, 69 insertions(+), 178 deletions(-)
  delete mode 100644 drivers/serial/serial_pl011.c
  rename drivers/serial/{serial_pl010.c = serial_pl01x.c} (66%)
  rename drivers/serial/{serial_pl011.h = serial_pl01x.h} (100%)
 
 diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
 index f30014d..3cc1999 100644
 --- a/drivers/serial/Makefile
 +++ b/drivers/serial/Makefile
 @@ -33,8 +33,7 @@ COBJS-$(CONFIG_DRIVER_S3C4510_UART) += s3c4510b_uart.o
  COBJS-$(CONFIG_S3C64XX) += s3c64xx.o
  COBJS-y += serial.o
  COBJS-$(CONFIG_MAX3100_SERIAL) += serial_max3100.o
 -COBJS-y += serial_pl010.o
 -COBJS-y += serial_pl011.o
 +COBJS-y += serial_pl01x.o
  COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o
  COBJS-$(CONFIG_SCIF_CONSOLE) += serial_sh.o
  COBJS-$(CONFIG_USB_TTY) += usbtty.o
 diff --git a/drivers/serial/serial_pl011.c b/drivers/serial/serial_pl011.c
 deleted file mode 100644
 index 4d35fe5..000
 --- a/drivers/serial/serial_pl011.c
 +++ /dev/null
 @@ -1,161 +0,0 @@
 -/*
 - * (C) Copyright 2000
 - * Rob Taylor, Flying Pig Systems. [EMAIL PROTECTED]
 - *
 - * (C) Copyright 2004
 - * ARM Ltd.
 - * Philippe Robin, [EMAIL PROTECTED]
 - *
 - * See file CREDITS for list of people who contributed to this
 - * project.
 - *
 - * This program is free software; you can redistribute it and/or
 - * modify it under the terms of the GNU General Public License as
 - * published by the Free Software Foundation; either version 2 of
 - * the License, or (at your option) any later version.
 +++ b/drivers/serial/serial_pl01x.c
 @@ -31,24 +31,28 @@
  #include common.h
  #include watchdog.h
 
 -#ifdef CFG_PL010_SERIAL
 +#if defined(CFG_PL010_SERIAL) || defined(CFG_PL011_SERIAL)
Please move this to the Makefile

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] [UPDATE #2] Merged serial_pl010.c and serial_pl011.c.

2008-09-08 Thread Andreas Engel
Jean-Christophe PLAGNIOL-VILLARD wrote:
 On 10:17 Mon 08 Sep , Andreas Engel wrote:
 [...]

 -#ifdef CFG_PL010_SERIAL
 +#if defined(CFG_PL010_SERIAL) || defined(CFG_PL011_SERIAL)
 Please move this to the Makefile

Shouldn't this better be a separate patch?

Regards,
  Andreas

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot