Re: [U-Boot] [PATCH] - Add support for HP Jornada (710/720/728) board

2010-10-12 Thread Wolfgang Denk
Dear Kristoffer Ericson,

In message 20101006194103.ge...@boggieman.bredbandsbolaget.se you wrote:
 
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 
 This patch add support for the HP Jornada 700-series with flashrom (manufact. 
 2008). 
 With little effort it could also be made to support earlier flashroms (just a 
 change of memory settings).
 The HP Jornada is an strongarm device (sa1110 + sa).
 
 Signed-off-by: Kristoffer Ericson kristoffer.eric...@gmail.com

Please send as plain text.  Use git tools to prepare (git
format-patch) and to submit (git send-email) the patch.  In any
case, please make sure that commit message, Signed-off-by line and
body of the patch are not split into separate MIME parts.


Entry to MAINTAINERS file missing.

...
 +int board_init(void)
 +{
 + gd-bd-bi_arch_number = 48;
 + gd-bd-bi_boot_params = 0xc100;
 +
 +
 + /* turn on flashing
 +  * would be nice to have some protection but
 +  * that would have to be implemented in the
 +  * flash init function, which isnt possible yet. */

Incorrect multiline comment style. Please fix globally.

...
 +#define CONFIG_BOOTARGS  root=/dev/hda1 
 console=ttySA0,19200n8 console=tty1
 +#define CONFIG_BOOTCOMMAND   run boot_kernel
 +#define CONFIG_SYS_AUTOLOAD  n /* No autoload */
 +#define CONFIG_SYS_LOAD_ADDR 0xc000
 +
 +/*
 + * Miscellaneous configurable options
 + */
 +#define CONFIG_SYS_LONGHELP  
 /* undef to save memory */
 +#define CONFIG_SYS_PROMPTHP Jornada#   
 /* Monitor Command Prompt   */
 +#define CONFIG_SYS_CBSIZE256 
 /* Console I/O Buffer Size  */
 +#define CONFIG_SYS_PBSIZE
 (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)/* Print Buffer Size */
 +#define CONFIG_SYS_MAXARGS   16  
 /* max number of command args   */
 +#define CONFIG_SYS_BARGSIZE  256 /* Boot 
 Argument Buffer Size*/
 +#define CONFIG_SYS_MEMTEST_START 0xc004  
 /* memtest works on */
 +#define CONFIG_SYS_MEMTEST_END   0xc200  
 /* 4 ... 128 MB in SDRAM   */
 +#define CONFIG_SYS_HZ3686400 
 /* incrementer freq: 3.6864 MHz */
 +#define CONFIG_SYS_CPUSPEED  0x0a
 /* set core clock to 206MHz */
 +#define CONFIG_SYS_BAUDRATE_TABLE{ 9600, 19200, 38400, 57600, 115200 }   
 /* valid baudrates */

Lines too long. Please fix globally.


Please clean up and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Never underestimate the bandwidth of a station wagon full of tapes.
-- Dr. Warren Jackson, Director, UTCS
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] - Add support for HP Jornada (710/720/728) board

2010-10-11 Thread Kristoffer Ericson
On Wed, Oct 06, 2010 at 09:41:04PM +0200, Kristoffer Ericson wrote:
 This patch add support for the HP Jornada 700-series with flashrom (manufact. 
 2008). 
 With little effort it could also be made to support earlier flashroms (just a 
 change of memory settings).
 The HP Jornada is an strongarm device (sa1110 + sa).

Bumping this since Ive gotten no feedback or indication on
wether or not its getting applied.

/Kristoffer

 
 Signed-off-by: Kristoffer Ericson kristoffer.eric...@gmail.com

 diff --git a/board/jornada/Makefile b/board/jornada/Makefile
 new file mode 100644
 index 000..1b4e192
 --- /dev/null
 +++ b/board/jornada/Makefile
 @@ -0,0 +1,53 @@
 +#
 +# (C) Copyright 2000-2006
 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
 +#
 +# 2004 (c) MontaVista Software, Inc.
 +#
 +# See file CREDITS for list of people who contributed to this
 +# project.
 +#
 +# This program is free software; you can redistribute it and/or
 +# modify it under the terms of the GNU General Public License as
 +# published by the Free Software Foundation; either version 2 of
 +# the License, or (at your option) any later version.
 +#
 +# This program is distributed in the hope that it will be useful,
 +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +# GNU General Public License for more details.
 +#
 +# You should have received a copy of the GNU General Public License
 +# along with this program; if not, write to the Free Software
 +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 +# MA 02111-1307 USA
 +#
 +
 +include $(TOPDIR)/config.mk
 +
 +LIB  = $(obj)lib$(BOARD).a
 +
 +COBJS:= jornada.o
 +SOBJS:= setup.o
 +
 +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
 +OBJS := $(addprefix $(obj),$(COBJS))
 +SOBJS:= $(addprefix $(obj),$(SOBJS))
 +
 +$(LIB):  $(obj).depend $(OBJS) $(SOBJS)
 + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
 +
 +clean:
 + rm -f $(SOBJS) $(OBJS)
 +
 +distclean:   clean
 + rm -f $(LIB) core *.bak $(obj).depend
 +
 +#
 +
 +# defines $(obj).depend target
 +include $(SRCTREE)/rules.mk
 +
 +sinclude $(obj).depend
 +
 +#
 diff --git a/board/jornada/config.mk b/board/jornada/config.mk
 new file mode 100644
 index 000..59968aa
 --- /dev/null
 +++ b/board/jornada/config.mk
 @@ -0,0 +1,6 @@
 +#
 +# SA-1110 based HP Jornada Flashrom
 +#
 +# We got 2 x 16 Intel SDRAM in total 128MB
 +#
 +TEXT_BASE = 0xc1f0
 diff --git a/board/jornada/jornada.c b/board/jornada/jornada.c
 new file mode 100644
 index 000..5cc972b
 --- /dev/null
 +++ b/board/jornada/jornada.c
 @@ -0,0 +1,63 @@
 +/*
 + * (C) Copyright 2002
 + * Sysgo Real-Time Solutions, GmbH www.elinos.com
 + * Marius Groeger mgroe...@sysgo.de
 + *
 + * 2004 (c) MontaVista Software, Inc.
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#include common.h
 +#include SA-1100.h
 +
 +DECLARE_GLOBAL_DATA_PTR;
 +
 +/* - 
 */
 +
 +static void jornada_init(void)
 +{
 +
 +}
 +
 +int board_init(void)
 +{
 + gd-bd-bi_arch_number = 48;
 + gd-bd-bi_boot_params = 0xc100;
 +
 +
 + /* turn on flashing
 +  * would be nice to have some protection but
 +  * that would have to be implemented in the
 +  * flash init function, which isnt possible yet. */
 + PPSR |= (1  7);
 + PPDR |= (1  7);
 +
 + return 0;
 +}
 +
 +int dram_init(void)
 +{
 + gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
 + gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
 + gd-bd-bi_dram[1].start = PHYS_SDRAM_2;
 + gd-bd-bi_dram[1].size = PHYS_SDRAM_2_SIZE;
 +
 + return (0);
 +}
 diff --git a/board/jornada/setup.S b/board/jornada/setup.S
 new file mode 100644
 index 000..885e02f
 --- /dev/null
 +++ b/board/jornada/setup.S
 @@ -0,0 +1,210 @@
 +/*
 + * Memory Setup stuff - taken from blob memsetup.S
 + *
 + * Copyright (C) 1999 2000 2001 Erik Mouw (j.a.k.m...@its.tudelft.nl) and
 + *  Jan-Derk Bakker (j.d.bak...@its.tudelft.nl)
 

[U-Boot] [PATCH] - Add support for HP Jornada (710/720/728) board

2010-10-06 Thread Kristoffer Ericson
This patch add support for the HP Jornada 700-series with flashrom (manufact. 
2008). 
With little effort it could also be made to support earlier flashroms (just a 
change of memory settings).
The HP Jornada is an strongarm device (sa1110 + sa).

Signed-off-by: Kristoffer Ericson kristoffer.eric...@gmail.com
diff --git a/board/jornada/Makefile b/board/jornada/Makefile
new file mode 100644
index 000..1b4e192
--- /dev/null
+++ b/board/jornada/Makefile
@@ -0,0 +1,53 @@
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+#
+# 2004 (c) MontaVista Software, Inc.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).a
+
+COBJS  := jornada.o
+SOBJS  := setup.o
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+SOBJS  := $(addprefix $(obj),$(SOBJS))
+
+$(LIB):$(obj).depend $(OBJS) $(SOBJS)
+   $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+clean:
+   rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+   rm -f $(LIB) core *.bak $(obj).depend
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/jornada/config.mk b/board/jornada/config.mk
new file mode 100644
index 000..59968aa
--- /dev/null
+++ b/board/jornada/config.mk
@@ -0,0 +1,6 @@
+#
+# SA-1110 based HP Jornada Flashrom
+#
+# We got 2 x 16 Intel SDRAM in total 128MB
+#
+TEXT_BASE = 0xc1f0
diff --git a/board/jornada/jornada.c b/board/jornada/jornada.c
new file mode 100644
index 000..5cc972b
--- /dev/null
+++ b/board/jornada/jornada.c
@@ -0,0 +1,63 @@
+/*
+ * (C) Copyright 2002
+ * Sysgo Real-Time Solutions, GmbH www.elinos.com
+ * Marius Groeger mgroe...@sysgo.de
+ *
+ * 2004 (c) MontaVista Software, Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include SA-1100.h
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/* - */
+
+static void jornada_init(void)
+{
+
+}
+
+int board_init(void)
+{
+   gd-bd-bi_arch_number = 48;
+   gd-bd-bi_boot_params = 0xc100;
+
+
+   /* turn on flashing
+* would be nice to have some protection but
+* that would have to be implemented in the
+* flash init function, which isnt possible yet. */
+   PPSR |= (1  7);
+   PPDR |= (1  7);
+
+   return 0;
+}
+
+int dram_init(void)
+{
+   gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
+   gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+   gd-bd-bi_dram[1].start = PHYS_SDRAM_2;
+   gd-bd-bi_dram[1].size = PHYS_SDRAM_2_SIZE;
+
+   return (0);
+}
diff --git a/board/jornada/setup.S b/board/jornada/setup.S
new file mode 100644
index 000..885e02f
--- /dev/null
+++ b/board/jornada/setup.S
@@ -0,0 +1,210 @@
+/*
+ * Memory Setup stuff - taken from blob memsetup.S
+ *
+ * Copyright (C) 1999 2000 2001 Erik Mouw (j.a.k.m...@its.tudelft.nl) and
+ *Jan-Derk Bakker (j.d.bak...@its.tudelft.nl)
+ * 2004 (c) MontaVista Software, Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either