Re: [U-Boot] [PATCH] ARMv8: add GOT sections to the list of sections copied

[Tom Rini]

On Fri, Mar 24, 2017 at 07:08:55PM +0100, Philipp Tomsich wrote:

> Recent Linux distributions (e.g. Debian 9) include cross-compilers for
> AArch64, but only for the aarch64-linux-gnu triplet only. It can thus
> be expected that users will attempt to use the system cross-compiler
> (instead of an aarch64-elf variant) to compile U-Boot for their ARMv8
> target systems.
> 
> One key differences between an aarch64-linux-gnu and an aarch64-elf
> compiler are the default settings regarding position-independent: with
> the aarch64-linux-gnu compiler, the default will create and use the
> global offset table.
> 
> This change-set adjusts the list of sections copied on ARMv8 to include
> the GOT sections. With this added, the list matches the previous setup
> for AArch32 closely.
> 
> Note that this is not an 'academic' issue, but was in fact encountered
> by our QA during testing of the RK3399-Q7 BSP and resulted in an
> early failure of the SPL stage during FDT setup.
> 
> Signed-off-by: Philipp Tomsich 
> Tested-by: Klaus Goger 
> 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] ARMv8: add GOT sections to the list of sections copied

[Simon Glass]

On 24 March 2017 at 12:08, Philipp Tomsich
 wrote:
> Recent Linux distributions (e.g. Debian 9) include cross-compilers for
> AArch64, but only for the aarch64-linux-gnu triplet only. It can thus
> be expected that users will attempt to use the system cross-compiler
> (instead of an aarch64-elf variant) to compile U-Boot for their ARMv8
> target systems.
>
> One key differences between an aarch64-linux-gnu and an aarch64-elf
> compiler are the default settings regarding position-independent: with
> the aarch64-linux-gnu compiler, the default will create and use the
> global offset table.
>
> This change-set adjusts the list of sections copied on ARMv8 to include
> the GOT sections. With this added, the list matches the previous setup
> for AArch32 closely.
>
> Note that this is not an 'academic' issue, but was in fact encountered
> by our QA during testing of the RK3399-Q7 BSP and resulted in an
> early failure of the SPL stage during FDT setup.
>
> Signed-off-by: Philipp Tomsich 
> Tested-by: Klaus Goger 
>
> ---
>
>  arch/arm/config.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] ARMv8: add GOT sections to the list of sections copied

[Philipp Tomsich]

Recent Linux distributions (e.g. Debian 9) include cross-compilers for
AArch64, but only for the aarch64-linux-gnu triplet only. It can thus
be expected that users will attempt to use the system cross-compiler
(instead of an aarch64-elf variant) to compile U-Boot for their ARMv8
target systems.

One key differences between an aarch64-linux-gnu and an aarch64-elf
compiler are the default settings regarding position-independent: with
the aarch64-linux-gnu compiler, the default will create and use the
global offset table.

This change-set adjusts the list of sections copied on ARMv8 to include
the GOT sections. With this added, the list matches the previous setup
for AArch32 closely.

Note that this is not an 'academic' issue, but was in fact encountered
by our QA during testing of the RK3399-Q7 BSP and resulted in an
early failure of the SPL stage during FDT setup.

Signed-off-by: Philipp Tomsich 
Tested-by: Klaus Goger 

---

 arch/arm/config.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/config.mk b/arch/arm/config.mk
index 08d7d1b..907c693 100644
--- a/arch/arm/config.mk
+++ b/arch/arm/config.mk
@@ -120,7 +120,7 @@ endif
 # limit ourselves to the sections we want in the .bin.
 ifdef CONFIG_ARM64
 OBJCOPYFLAGS += -j .text -j .secure_text -j .secure_data -j .rodata -j .data \
-   -j .u_boot_list -j .rela.dyn
+   -j .u_boot_list -j .rela.dyn -j .got -j .got.plt
 else
 OBJCOPYFLAGS += -j .text -j .secure_text -j .secure_data -j .rodata -j .hash \
-j .data -j .got -j .got.plt -j .u_boot_list -j .rel.dyn
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot