Re: [U-Boot] [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h

2016-10-25 Thread york sun 
On 10/24/2016 11:55 PM, Prabhakar Kushwaha wrote:
>
>> -Original Message-
>> From: york sun
>> Sent: Monday, October 24, 2016 9:41 PM
>> To: Prabhakar Kushwaha ; u-
>> b...@lists.denx.de
>> Cc: o...@buserror.net
>> Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to
>> config.h
>>
>> On 10/23/2016 07:04 AM, Prabhakar Kushwaha wrote:
>>> Hi York,
>>>
 -Original Message-
 From: york sun
 Sent: Friday, October 21, 2016 7:55 PM
 To: Prabhakar Kushwaha ; u-
 b...@lists.denx.de
 Cc: o...@buserror.net
 Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to
 config.h

 On 10/20/2016 11:37 PM, Prabhakar Kushwaha wrote:
> Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding
> SoC name in Kconfig as Dependencies. It will help in having
> all SoC related defines in config.h - easy to maintain.
>

 Prabhakar,

 Why do you want to go back to config.h? I think we are going with
 Kconfig. Having everything in one config file conflicts with Kconfig.
 The former has centralized config per SoC, the latter has centralized
 config per feature.

>>>
>>> There are 2 reason for this
>>>
>>> 1) in File arch/arm/cpu/armv8/fsl-layerscape/Kconfig, "depends" row will 
>>> keep
>> on increasing with SoC.
>>> And if I add new field CONFIG_SYS_FSL_IFC_CLK_DIV, similar entry will be
>> done and it will also keep on increasing with SoC.
>>> I want to avoid it.
>>>
>>> config SYS_FSL_IFC_BANK_COUNT
>>> int "Maximum banks of Integrated flash controller"
>>> depends on ARCH_LS1043A || ARCH_LS1046A || ARCH_LS2080A
>>
>> The "depends" line can be rewritten with HAS_* feature macro.
>>
>>> default 4 if ARCH_LS1043A
>>> default 4 if ARCH_LS1046A
>>> default 8 if ARCH_LS2080A
>>
>> You can simplify the "default 4" for all and only use different number
>> for others.
>>
>
> ok
>
>
>>>
>>> 2) There is no file similar to  " 
>>> arch/arm/cpu/armv8/fsl-layerscape/Kconfig" for
>> powerpc platform. So how to add new " CONFIG SYS_FSL_IFC_CLK_DIV" with
>> different values per SoC.
>>>This problem will come for defining other clocks for " armv8/fsl-lsch3:
>> consolidate the clock system initialization"
>>>
>>
>> We will convert powerpc as well.
>
> This means, IFC and clock related patches needs to wait till powerpc is 
> converted as well.
>

Maybe. If you have bandwidth, you can take it. Or you can wait for me to 
get it done. My plate is full, so it will take a while before I start.

York

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h

2016-10-25 Thread Prabhakar Kushwaha 

> -Original Message-
> From: york sun
> Sent: Monday, October 24, 2016 9:41 PM
> To: Prabhakar Kushwaha ; u-
> b...@lists.denx.de
> Cc: o...@buserror.net
> Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to
> config.h
> 
> On 10/23/2016 07:04 AM, Prabhakar Kushwaha wrote:
> > Hi York,
> >
> >> -Original Message-
> >> From: york sun
> >> Sent: Friday, October 21, 2016 7:55 PM
> >> To: Prabhakar Kushwaha ; u-
> >> b...@lists.denx.de
> >> Cc: o...@buserror.net
> >> Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to
> >> config.h
> >>
> >> On 10/20/2016 11:37 PM, Prabhakar Kushwaha wrote:
> >>> Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding
> >>> SoC name in Kconfig as Dependencies. It will help in having
> >>> all SoC related defines in config.h - easy to maintain.
> >>>
> >>
> >> Prabhakar,
> >>
> >> Why do you want to go back to config.h? I think we are going with
> >> Kconfig. Having everything in one config file conflicts with Kconfig.
> >> The former has centralized config per SoC, the latter has centralized
> >> config per feature.
> >>
> >
> > There are 2 reason for this
> >
> > 1) in File arch/arm/cpu/armv8/fsl-layerscape/Kconfig, "depends" row will 
> > keep
> on increasing with SoC.
> > And if I add new field CONFIG_SYS_FSL_IFC_CLK_DIV, similar entry will be
> done and it will also keep on increasing with SoC.
> > I want to avoid it.
> >
> > config SYS_FSL_IFC_BANK_COUNT
> > int "Maximum banks of Integrated flash controller"
> > depends on ARCH_LS1043A || ARCH_LS1046A || ARCH_LS2080A
> 
> The "depends" line can be rewritten with HAS_* feature macro.
> 
> > default 4 if ARCH_LS1043A
> > default 4 if ARCH_LS1046A
> > default 8 if ARCH_LS2080A
> 
> You can simplify the "default 4" for all and only use different number
> for others.
> 

ok


> >
> > 2) There is no file similar to  " 
> > arch/arm/cpu/armv8/fsl-layerscape/Kconfig" for
> powerpc platform. So how to add new " CONFIG SYS_FSL_IFC_CLK_DIV" with
> different values per SoC.
> >This problem will come for defining other clocks for " armv8/fsl-lsch3:
> consolidate the clock system initialization"
> >
> 
> We will convert powerpc as well.

This means, IFC and clock related patches needs to wait till powerpc is 
converted as well.

-prabhakar

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h

2016-10-24 Thread york sun 
On 10/23/2016 07:04 AM, Prabhakar Kushwaha wrote:
> Hi York,
>
>> -Original Message-
>> From: york sun
>> Sent: Friday, October 21, 2016 7:55 PM
>> To: Prabhakar Kushwaha ; u-
>> b...@lists.denx.de
>> Cc: o...@buserror.net
>> Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to
>> config.h
>>
>> On 10/20/2016 11:37 PM, Prabhakar Kushwaha wrote:
>>> Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding
>>> SoC name in Kconfig as Dependencies. It will help in having
>>> all SoC related defines in config.h - easy to maintain.
>>>
>>
>> Prabhakar,
>>
>> Why do you want to go back to config.h? I think we are going with
>> Kconfig. Having everything in one config file conflicts with Kconfig.
>> The former has centralized config per SoC, the latter has centralized
>> config per feature.
>>
>
> There are 2 reason for this
>
> 1) in File arch/arm/cpu/armv8/fsl-layerscape/Kconfig, "depends" row will keep 
> on increasing with SoC.
> And if I add new field CONFIG_SYS_FSL_IFC_CLK_DIV, similar entry will be done 
> and it will also keep on increasing with SoC.
> I want to avoid it.
>
> config SYS_FSL_IFC_BANK_COUNT
>   int "Maximum banks of Integrated flash controller"
>   depends on ARCH_LS1043A || ARCH_LS1046A || ARCH_LS2080A

The "depends" line can be rewritten with HAS_* feature macro.

>   default 4 if ARCH_LS1043A
>   default 4 if ARCH_LS1046A
>   default 8 if ARCH_LS2080A

You can simplify the "default 4" for all and only use different number 
for others.

>
> 2) There is no file similar to  " arch/arm/cpu/armv8/fsl-layerscape/Kconfig" 
> for powerpc platform. So how to add new " CONFIG SYS_FSL_IFC_CLK_DIV" with 
> different values per SoC.
>This problem will come for defining other clocks for " armv8/fsl-lsch3: 
> consolidate the clock system initialization"
>

We will convert powerpc as well.

York

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h

2016-10-23 Thread Prabhakar Kushwaha 
Hi York,

> -Original Message-
> From: york sun
> Sent: Friday, October 21, 2016 7:55 PM
> To: Prabhakar Kushwaha ; u-
> b...@lists.denx.de
> Cc: o...@buserror.net
> Subject: Re: [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to
> config.h
> 
> On 10/20/2016 11:37 PM, Prabhakar Kushwaha wrote:
> > Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding
> > SoC name in Kconfig as Dependencies. It will help in having
> > all SoC related defines in config.h - easy to maintain.
> >
> 
> Prabhakar,
> 
> Why do you want to go back to config.h? I think we are going with
> Kconfig. Having everything in one config file conflicts with Kconfig.
> The former has centralized config per SoC, the latter has centralized
> config per feature.
> 

There are 2 reason for this

1) in File arch/arm/cpu/armv8/fsl-layerscape/Kconfig, "depends" row will keep 
on increasing with SoC.  
And if I add new field CONFIG_SYS_FSL_IFC_CLK_DIV, similar entry will be done 
and it will also keep on increasing with SoC.
I want to avoid it.

config SYS_FSL_IFC_BANK_COUNT
int "Maximum banks of Integrated flash controller"
depends on ARCH_LS1043A || ARCH_LS1046A || ARCH_LS2080A
default 4 if ARCH_LS1043A
default 4 if ARCH_LS1046A
default 8 if ARCH_LS2080A

2) There is no file similar to  " arch/arm/cpu/armv8/fsl-layerscape/Kconfig" 
for powerpc platform. So how to add new " CONFIG SYS_FSL_IFC_CLK_DIV" with 
different values per SoC.
   This problem will come for defining other clocks for " armv8/fsl-lsch3: 
consolidate the clock system initialization"

--prabhakar


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h

2016-10-21 Thread york sun 
On 10/20/2016 11:37 PM, Prabhakar Kushwaha wrote:
> Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding
> SoC name in Kconfig as Dependencies. It will help in having
> all SoC related defines in config.h - easy to maintain.
>

Prabhakar,

Why do you want to go back to config.h? I think we are going with 
Kconfig. Having everything in one config file conflicts with Kconfig. 
The former has centralized config per SoC, the latter has centralized 
config per feature.

York
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] Kconfig: ifc: Moving IFC_BANK_COUNT from Kconfig to config.h

2016-10-20 Thread Prabhakar Kushwaha 
Migration of IFC_BANK_COUNT from Kconfig to config.h avoids adding
SoC name in Kconfig as Dependencies. It will help in having
all SoC related defines in config.h - easy to maintain.

Signed-off-by: Prabhakar Kushwaha 
---
 This patch provide base for defining SYS_FSL_IFC_CLK_DIV required
 for v3 version of below patch-set
 http://patchwork.ozlabs.org/patch/666844/
 http://patchwork.ozlabs.org/patch/666849/
 http://patchwork.ozlabs.org/patch/666848/


 README|  3 +++
 arch/arm/cpu/armv7/ls102xa/Kconfig|  5 -
 arch/arm/cpu/armv8/fsl-layerscape/Kconfig |  7 ---
 arch/arm/include/asm/arch-fsl-layerscape/config.h |  4 
 arch/arm/include/asm/arch-ls102xa/config.h|  1 +
 arch/powerpc/include/asm/config_mpc85xx.h | 18 +-
 drivers/misc/fsl_ifc.c|  2 +-
 drivers/mtd/nand/fsl_ifc_nand.c   |  6 +++---
 include/fsl_ifc.h | 20 ++--
 9 files changed, 31 insertions(+), 35 deletions(-)

diff --git a/README b/README
index 68d6a49..c83171a 100644
--- a/README
+++ b/README
@@ -507,6 +507,9 @@ The following options need to be configured:
Board config to use DDR4. It can be enabled for SoCs with
DDR4 controllers.
 
+   SYS_FSL_IFC_BANK_COUNT
+   Maximum banks of Integrated flash controller
+
CONFIG_SYS_FSL_IFC_BE
Defines the IFC controller register space as Big Endian
 
diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig 
b/arch/arm/cpu/armv7/ls102xa/Kconfig
index 28bf778..68d03ab 100644
--- a/arch/arm/cpu/armv7/ls102xa/Kconfig
+++ b/arch/arm/cpu/armv7/ls102xa/Kconfig
@@ -81,9 +81,4 @@ config SYS_FSL_DDR4
help
  Enable Freescale DDR4 controller.
 
-config SYS_FSL_IFC_BANK_COUNT
-   int "Maximum banks of Integrated flash controller"
-   depends on ARCH_LS1021A
-   default 8
-
 endmenu
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig 
b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
index 94ec8d5..0587559 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
+++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
@@ -71,13 +71,6 @@ config NUM_DDR_CONTROLLERS
default 3 if ARCH_LS2080A
default 1
 
-config SYS_FSL_IFC_BANK_COUNT
-   int "Maximum banks of Integrated flash controller"
-   depends on ARCH_LS1043A || ARCH_LS1046A || ARCH_LS2080A
-   default 4 if ARCH_LS1043A
-   default 4 if ARCH_LS1046A
-   default 8 if ARCH_LS2080A
-
 config SYS_FSL_HAS_DP_DDR
bool
 
diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h 
b/arch/arm/include/asm/arch-fsl-layerscape/config.h
index 4201e0f..28d3974 100644
--- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
+++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
@@ -27,6 +27,8 @@
 #define L1_CACHE_BYTES BIT(L1_CACHE_SHIFT)
 #endif
 
+#define SYS_FSL_IFC_BANK_COUNT 8
+
 #define CONFIG_SYS_FSL_OCRAM_BASE  0x1800  /* initial RAM */
 #define CONFIG_SYS_FSL_OCRAM_SIZE  0x0020  /* 2M */
 
@@ -150,6 +152,7 @@
 
 /* SoC related */
 #ifdef CONFIG_LS1043A
+#define SYS_FSL_IFC_BANK_COUNT 4
 #define CONFIG_SYS_FMAN_V3
 #define CONFIG_SYS_NUM_FMAN1
 #define CONFIG_SYS_NUM_FM1_DTSEC   7
@@ -187,6 +190,7 @@
 #define GICD_BASE  0x01401000
 #define GICC_BASE  0x01402000
 #elif defined(CONFIG_ARCH_LS1046A)
+#define SYS_FSL_IFC_BANK_COUNT 4
 #define CONFIG_SYS_FMAN_V3
 #define CONFIG_SYS_NUM_FMAN1
 #define CONFIG_SYS_NUM_FM1_DTSEC   8
diff --git a/arch/arm/include/asm/arch-ls102xa/config.h 
b/arch/arm/include/asm/arch-ls102xa/config.h
index ec65cc0..d65f5bf 100644
--- a/arch/arm/include/asm/arch-ls102xa/config.h
+++ b/arch/arm/include/asm/arch-ls102xa/config.h
@@ -120,6 +120,7 @@
 #define CONFIG_SYS_FSL_ERRATUM_A009663
 #define CONFIG_SYS_FSL_ERRATUM_A009942
 #define CONFIG_SYS_FSL_MAX_NUM_OF_SEC  1
+#defineSYS_FSL_IFC_BANK_COUNT  8
 #else
 #error SoC not defined
 #endif
diff --git a/arch/powerpc/include/asm/config_mpc85xx.h 
b/arch/powerpc/include/asm/config_mpc85xx.h
index 6d845e8..073a7b5 100644
--- a/arch/powerpc/include/asm/config_mpc85xx.h
+++ b/arch/powerpc/include/asm/config_mpc85xx.h
@@ -150,7 +150,7 @@
 #define CONFIG_SYS_FSL_ERRATUM_ESDHC111
 #define CONFIG_NUM_DDR_CONTROLLERS 1
 #define CONFIG_USB_MAX_CONTROLLER_COUNT1
-#define CONFIG_SYS_FSL_IFC_BANK_COUNT  4
+#define SYS_FSL_IFC_BANK_COUNT 4
 #define CONFIG_SYS_CCSRBAR_DEFAULT 0xff70
 #define CONFIG_SYS_FSL_PCIE_COMPAT "fsl,qoriq-pcie-v2.2"
 #define CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY
@@ -590,7 +590,7 @@
 #define CONFIG_USB_MAX_CONTROLLER_COUNT1
 #define CONFIG_SYS_FSL_DSP_M2_RAM_ADDR 0xb000
 #define