[U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init

[Jasper kcoding]

Without this patch the Ethernet PHY on the p212 board does not get
fully configured.
When this happens Ethernet does not function.

The similar libretech-cc and khadas-vim boards have this code already.
That's why the Ethernet on these boards do work.

Signed-off-by: Jasper Kcoding 
Acked-by: Neil Armstrong 
---
 board/amlogic/p212/p212.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/amlogic/p212/p212.c b/board/amlogic/p212/p212.c
index 06c2eaee47..d5ce5397f3 100644
--- a/board/amlogic/p212/p212.c
+++ b/board/amlogic/p212/p212.c
@@ -29,7 +29,7 @@ int misc_init_r(void)
char serial[EFUSE_SN_SIZE];
ssize_t len;

-   meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+   meson_gx_eth_init(PHY_INTERFACE_MODE_RMII,
MESON_GXL_USE_INTERNAL_RMII_PHY);

if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
--
2.11.0
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init

[Neil Armstrong]

Hi jasper,

On 28/08/2018 22:26, Jasper Kcoding wrote:
> Without this patch the Ethernet PHY on the p212 board does not get fully 
> configured.
> When this happens Ethernet does not function.
> 
> The similar libretech-cc and khadas-vim boards have this code already.
> That's why the Ethernet on these boards do work.

Please add a "Signed-off-by" tag.

> ---
>  board/amlogic/p212/p212.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/amlogic/p212/p212.c b/board/amlogic/p212/p212.c
> index 06c2eaee47..d5ce5397f3 100644
> --- a/board/amlogic/p212/p212.c
> +++ b/board/amlogic/p212/p212.c
> @@ -29,7 +29,7 @@ int misc_init_r(void)
>   char serial[EFUSE_SN_SIZE];
>   ssize_t len;
>  
> - meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
> + meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 
> MESON_GXL_USE_INTERNAL_RMII_PHY);
>  
>   if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
>   len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
> 

Acked-by: Neil Armstrong 

Please resend with my Acked-by tag !

Thanks for fixing this...

Neil
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init

[Jasper Kcoding]

Without this patch the Ethernet PHY on the p212 board does not get fully 
configured.
When this happens Ethernet does not function.

The similar libretech-cc and khadas-vim boards have this code already.
That's why the Ethernet on these boards do work.
---
 board/amlogic/p212/p212.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/amlogic/p212/p212.c b/board/amlogic/p212/p212.c
index 06c2eaee47..d5ce5397f3 100644
--- a/board/amlogic/p212/p212.c
+++ b/board/amlogic/p212/p212.c
@@ -29,7 +29,7 @@ int misc_init_r(void)
char serial[EFUSE_SN_SIZE];
ssize_t len;
 
-   meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+   meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 
MESON_GXL_USE_INTERNAL_RMII_PHY);
 
if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot