Re: [U-Boot] [PATCH] arm: freescale: ls102xa: add helper Macro to get the SVR

2019-10-17 Thread Priyanka Jain


>-Original Message-
>From: Pankaj Bansal
>Sent: Wednesday, October 16, 2019 3:40 PM
>To: Priyanka Jain ; Albert Aribaud
>; Simon Glass 
>Cc: u-boot@lists.denx.de; Pankaj Bansal 
>Subject: [PATCH] arm: freescale: ls102xa: add helper Macro to get the SVR
>
>32 bit System Version Register (SVR) in NXP SOCs contains information about
>SOC such as:
>1. SOC type (bits 8 - 31)
>2. SOC Major Revision (bits 4 - 7)
>3. SOC Minor Revision (bits 0 - 3)
>
>This Macro (SVR_DEV) strips the Major and Minor revision info, so that SOC
>can be correctly identified.
>This Macro is borrowed from Macro defined in arch/arm/include/asm/arch-
>fsl-layerscape/soc.h
>
>Additinally this file doesn't contain any valid license. Therefore, add
>GPLv2+ license in the file.
>same as arch/arm/include/asm/arch-fsl-layerscape/soc.h
>
>Signed-off-by: Pankaj Bansal 
>---
> arch/arm/include/asm/arch-ls102xa/soc.h | 6 ++
> 1 file changed, 6 insertions(+)
>
>diff --git a/arch/arm/include/asm/arch-ls102xa/soc.h
>b/arch/arm/include/asm/arch-ls102xa/soc.h
>index e69de29bb2..672f126bba 100644
>--- a/arch/arm/include/asm/arch-ls102xa/soc.h
>+++ b/arch/arm/include/asm/arch-ls102xa/soc.h
>@@ -0,0 +1,6 @@
>+/* SPDX-License-Identifier: GPL-2.0+ */
>+/*
>+ * Copyright 2019 NXP
>+ */
The file have existed before 2019. Please check git log and update accordingly
>+#define SVR_DEV(svr)  ((svr) >> 8)
Is this something ls102xa specific. Can't we make it generic?
>+
>--
>2.17.1
--priyankajain 


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH] arm: freescale: ls102xa: add helper Macro to get the SVR

2019-10-16 Thread Pankaj Bansal
32 bit System Version Register (SVR) in NXP SOCs contains information
about SOC such as:
1. SOC type (bits 8 - 31)
2. SOC Major Revision (bits 4 - 7)
3. SOC Minor Revision (bits 0 - 3)

This Macro (SVR_DEV) strips the Major and Minor revision info, so that
SOC can be correctly identified.
This Macro is borrowed from Macro defined in
arch/arm/include/asm/arch-fsl-layerscape/soc.h

Additinally this file doesn't contain any valid license. Therefore, add
GPLv2+ license in the file.
same as arch/arm/include/asm/arch-fsl-layerscape/soc.h

Signed-off-by: Pankaj Bansal 
---
 arch/arm/include/asm/arch-ls102xa/soc.h | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/include/asm/arch-ls102xa/soc.h 
b/arch/arm/include/asm/arch-ls102xa/soc.h
index e69de29bb2..672f126bba 100644
--- a/arch/arm/include/asm/arch-ls102xa/soc.h
+++ b/arch/arm/include/asm/arch-ls102xa/soc.h
@@ -0,0 +1,6 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 NXP
+ */
+#define SVR_DEV(svr)   ((svr) >> 8)
+
-- 
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot