Re: [U-Boot] [PATCH] armv8: ls1046aqds: added usb feature support

[Y.T. Tang]

Hi York,

Sorry for the trouble. I remember I tested it when I submitted the patch.
Anyway, I will check it out.

Regards,
Yuantian

> -Original Message-
> From: york sun
> Sent: Thursday, January 19, 2017 1:20 AM
> To: Y.T. Tang 
> Cc: Mingkai Hu ; u-boot@lists.denx.de
> Subject: Re: [PATCH] armv8: ls1046aqds: added usb feature support
> 
> On 12/26/2016 06:55 PM, yuantian.t...@nxp.com wrote:
> > From: Tang Yuantian 
> >
> > The LS1046AQDS processor has three integrated USB 3.0 controllers
> > (USB1, USB2, and USB3) that allow direct connection to the USB ports
> > with appropriate protection circuitry and power supplies.
> > USB1 and USB2 ports are powered by a NX5P2190UK device, which supplies
> > 5v power at up to 1.2 A. The power enable and power-fault-detect pins
> > are connected to the LS1046A processor via CPLD for individual port
> > management.
> >
> > Signed-off-by: Tang Yuantian 
> > ---
> >  include/configs/ls1046aqds.h | 8 
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/include/configs/ls1046aqds.h
> > b/include/configs/ls1046aqds.h index 29e0aa5..53a1ffb 100644
> > --- a/include/configs/ls1046aqds.h
> > +++ b/include/configs/ls1046aqds.h
> > @@ -135,6 +135,14 @@ unsigned long get_board_ddr_clk(void);
> >  #define CFG_LPUART_EN  0x2
> >  #endif
> >
> > +/* USB */
> > +#define CONFIG_HAS_FSL_XHCI_USB
> > +#ifdef CONFIG_HAS_FSL_XHCI_USB
> > +#define CONFIG_USB_XHCI_FSL
> > +#define CONFIG_USB_MAX_CONTROLLER_COUNT3
> > +#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS 2
> > +#endif
> > +
> >  /* SATA */
> >  #define CONFIG_LIBATA
> >  #define CONFIG_SCSI_AHCI
> >
> 
> Yuantian,
> 
> I wonder if CONFIG_USB_XHCI_DWC3 should also be defined. Without it I
> got compiling error
> 
> drivers/usb/host/xhci-fsl.c:72:2: warning: implicit declaration of function
> 'dwc3_core_init' [-Wimplicit-function-declaration]
>ret = dwc3_core_init(fsl_xhci->dwc3_reg);
>^
> 
> I have no issue with this patch with similar change
> http://patchwork.ozlabs.org/patch/695027/
> 
> York
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] armv8: ls1046aqds: added usb feature support

[yuantian.tang]

From: Tang Yuantian 

The LS1046AQDS processor has three integrated USB 3.0 controllers
(USB1, USB2, and USB3) that allow direct connection to the USB
ports with appropriate protection circuitry and power supplies.
USB1 and USB2 ports are powered by a NX5P2190UK device, which
supplies 5v power at up to 1.2 A. The power enable and
power-fault-detect pins are connected to the LS1046A processor
via CPLD for individual port management.

Signed-off-by: Tang Yuantian 
---
 include/configs/ls1046aqds.h | 8 
 1 file changed, 8 insertions(+)

diff --git a/include/configs/ls1046aqds.h b/include/configs/ls1046aqds.h
index 29e0aa5..53a1ffb 100644
--- a/include/configs/ls1046aqds.h
+++ b/include/configs/ls1046aqds.h
@@ -135,6 +135,14 @@ unsigned long get_board_ddr_clk(void);
 #define CFG_LPUART_EN  0x2
 #endif
 
+/* USB */
+#define CONFIG_HAS_FSL_XHCI_USB
+#ifdef CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT3
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS 2
+#endif
+
 /* SATA */
 #define CONFIG_LIBATA
 #define CONFIG_SCSI_AHCI
-- 
2.1.0.27.g96db324

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot