Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
Dear Joel A Fernandes, On 16.06.13 17:44, Joel A Fernandes wrote: On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl Would it not work to pass in the -w here? this is not portable! BSD variants of env will only take a single parameter. Best regards Andreas Bießmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
On Mon, Jun 17, 2013 at 1:38 AM, Andreas Bießmann andreas.de...@googlemail.com wrote: Dear Joel A Fernandes, On 16.06.13 17:44, Joel A Fernandes wrote: On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl Would it not work to pass in the -w here? this is not portable! BSD variants of env will only take a single parameter. Sure yes I noticed that, this is an acceptable approach though I've seen some cases people solve the problem using exec. Thanks, Joel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
Hi ALL, Could any buddy tell me how can I define bootcount value after each reset cycle, right now i am using SRAM but when boot loader pass the control to kernel, it reset Sram memory so i lost my bootcount value. please suggest me another idea for storing bootcount value... My another query is I want to increase my bootcount value when system is being reset by watchdog only.. Any pointer from you guys would be help me. Thanks ~Sumit Gemini On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki jagannadha.sutradharudu-t...@xilinx.com wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
Hi Il giorno 16/giu/2013 11:55, Sumit Gemini sumit.gemi...@gmail.com ha scritto: Hi ALL, Could any buddy tell me how can I define bootcount value after each reset cycle, right now i am using SRAM but when boot loader pass the control to kernel, it reset Sram memory so i lost my bootcount value. Is this your comment on the patch? I suggest to create a new thread and at describe your architecture. Michael please suggest me another idea for storing bootcount value... My another query is I want to increase my bootcount value when system is being reset by watchdog only.. Any pointer from you guys would be help me. Thanks ~Sumit Gemini On Sun, Jun 16, 2013 at 12:46 PM, Jagannadha Sutradharudu Teki jagannadha.sutradharudu-t...@xilinx.com wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
On Sun, Jun 16, 2013 at 12:46:37PM +0530, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; Lets get this to come in via the kernel please, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
From: Joel A Fernandes [mailto:agnel.j...@gmail.com] Sent: 16 June 2013 21:15 To: Jagannadha Sutradharudu Teki Cc: u-boot@lists.denx.de; Tom Rini Subject: Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com checkpatch.plhttp://checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com --- tools/checkpatch.plhttp://checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.plhttp://checkpatch.pl b/tools/checkpatch.plhttp://checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.plhttp://checkpatch.pl +++ b/tools/checkpatch.plhttp://checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl Would it not work to pass in the -w here? Yes it will not work just to pass -w It's taking -w as a file. Thanks, Jagan. Joel # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path
On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.comjavascript:; --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl Would it not work to pass in the -w here? Joel # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp jsch...@austin.ibm.com javascript:; (the ugly bit) # (c) 2007,2008, Andy Whitcroft a...@uk.ibm.com javascript:; (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft a...@canonical.com javascript:; # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 ___ U-Boot mailing list U-Boot@lists.denx.de javascript:; http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
