Re: [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
> -Original Message-
> From: Joe Hershberger
> Sent: Tuesday, March 5, 2019 12:48 AM
> To: Ioana Ciocoi Radulescu
> Cc: u-boot@lists.denx.de; Prabhakar Kushwaha
>
> Subject: Re: [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
>
> On Tue, Feb 26, 2019 at 9:51 AM Ioana Ciocoi Radulescu
> wrote:
> >
> > If node /board_info/ports does not exist in the DPC file, function
> > mc_fixup_dpc() will skip not only MAC address fixup, but also the
> > cache flush at the end. This may cause the other fixup changes (e.g.
> > ICID relatd ones) to be ignored by MC.
>
> Typo in commit log.
>
> >
> > Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to
> > DPL")
> >
> > Signed-off-by: Ioana Radulescu
>
> Acked-by: Joe Hershberger
Applied to u-boot-fsl-qoriq, awaiting upstream
--pk
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
On Tue, Feb 26, 2019 at 9:51 AM Ioana Ciocoi Radulescu
wrote:
>
> If node /board_info/ports does not exist in the DPC file,
> function mc_fixup_dpc() will skip not only MAC address fixup,
> but also the cache flush at the end. This may cause the other
> fixup changes (e.g. ICID relatd ones) to be ignored by MC.
Typo in commit log.
>
> Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
>
> Signed-off-by: Ioana Radulescu
Acked-by: Joe Hershberger
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
On 26.02.2019 17:41, Ioana Ciocoi Radulescu wrote:
> If node /board_info/ports does not exist in the DPC file,
> function mc_fixup_dpc() will skip not only MAC address fixup,
> but also the cache flush at the end. This may cause the other
> fixup changes (e.g. ICID relatd ones) to be ignored by MC.
>
> Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
>
> Signed-off-by: Ioana Radulescu
> ---
> drivers/net/fsl-mc/mc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Laurentiu Tudor
---
Best Regards, Laurentiu
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
Dear Joe
> -Original Message-
> From: Ioana Ciocoi Radulescu
> Sent: Tuesday, February 26, 2019 9:12 PM
> To: u-boot@lists.denx.de; Prabhakar Kushwaha
>
> Cc: Laurentiu Tudor
> Subject: [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
>
> If node /board_info/ports does not exist in the DPC file, function
> mc_fixup_dpc()
> will skip not only MAC address fixup, but also the cache flush at the end.
> This
> may cause the other fixup changes (e.g. ICID relatd ones) to be ignored by MC.
>
> Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
>
> Signed-off-by: Ioana Radulescu
> ---
Please review and ack this patch.
I want to send this via u-boot-fsl-qoriq repo.
--pk
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
If node /board_info/ports does not exist in the DPC file,
function mc_fixup_dpc() will skip not only MAC address fixup,
but also the cache flush at the end. This may cause the other
fixup changes (e.g. ICID relatd ones) to be ignored by MC.
Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
Signed-off-by: Ioana Radulescu
---
drivers/net/fsl-mc/mc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
index a51b8a4..e6cf7f3 100644
--- a/drivers/net/fsl-mc/mc.c
+++ b/drivers/net/fsl-mc/mc.c
@@ -421,9 +421,11 @@ static int mc_fixup_dpc(u64 dpc_addr)
/* fixup MAC addresses for dpmac ports */
nodeoffset = fdt_path_offset(blob, "/board_info/ports");
if (nodeoffset < 0)
- return 0;
+ goto out;
err = mc_fixup_mac_addrs(blob, MC_FIXUP_DPC);
+
+out:
flush_dcache_range(dpc_addr, dpc_addr + fdt_totalsize(blob));
return err;
--
2.7.4
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
