Re: [U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI

[Tom Rini]

On Wed, Oct 26, 2016 at 11:11:31AM -0600, Stephen Warren wrote:
> On 10/24/2016 02:13 PM, Tom Rini wrote:
> >Add 'PCI' as a menu option and migrate all existing users.
> >
> >Signed-off-by: Tom Rini 
> >---
> >Tegra is in a funny spot here.  TEGRA_COMMON will select DM_PCI and
> >DM_PCICOMPAT.  But adding PCI to the list here results in the following:
> >   aarch64: (for 61/61 boards) all +217.7 data +24.8 rodata +47.9 text +145.0
> >p2571  : all +4426 data +504 rodata +974 text +2948
> >e2220-1170 : all +4426 data +504 rodata +974 text +2948
> >p2371- : all +4426 data +504 rodata +974 text +2948
> >   arm: (for 557/557 boards) all +96.9 bss +0.1 data +7.2 rodata +23.7 
> > spl/u-boot-spl:all +0.1 spl/u-boot-spl:rodata +0.1 spl/u-boot-spl:text +0.0 
> > text +65.9
> >whistler   : all +3914 bss +28 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2664
> >paz00  : all +3908 bss +16 data +280 rodata +952 text 
> > +2660
> >colibri_t30: all +3898 bss +12 data +280 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2672
> >venice2: all +3862 bss +28 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> >plutux : all +3850 bss +32 data +280 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2604
> >nyan-big   : all +3852 bss -4 data +296 rodata +952 text 
> > +2608
> >dalmore: all +3846 bss +12 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> >seaboard   : all +3848 bss +8 data +288 rodata +952 text 
> > +2600
> >medcom-wide: all +3848 bss +16 data +280 rodata +952 text 
> > +2600
> >harmony: all +3848 bss +8 data +288 rodata +952 text 
> > +2600
> >tec-ng : all +3842 bss +8 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> >ventana: all +3844 bss -48 data +280 rodata +952 text 
> > +2660
> >colibri_t20: all +3836 bss -4 data +288 rodata +952 text 
> > +2600
> >tec: all +3784 bss -48 data +280 rodata +952 text 
> > +2600
> >
> >Because prior to this patch they did not set PCI and thus what code was
> >build here was largely discarded at link time.  One or two of the above
> >look to fall in to the case where PCI_TEGRA should be off, but not all.
> >What should we do about this?
> 
> >diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> 
> >@@ -38,6 +38,7 @@ config TEGRA_COMMON
> > select DM_SPI_FLASH
> > select MISC
> > select OF_CONTROL
> >+select PCI
> 
> I don't think this is correct; only a few Tegra boards have PCI, so
> we should likely enabling CONFIG_PCI from the relevant board
> defconfigs, or select it only if the Tegra PCI controller option is
> selected.
> 
> The list of Tegra boards that support PCI is:
> 
> harmony
> trimslice
> apalis
> beaver
> cardhu
> cei-tk1-som
> jetson-tk1
> p2371-2180
> p2771--000
> p2771--500

Two things happen.  One, harmony still grows.  The second is that all of
the other Tegra platforms now shrink slightly as there was (I assume)
strings that weren't being discarded before from unused DM_PCI bits.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI

[Tom Rini]

On Wed, Oct 26, 2016 at 11:11:31AM -0600, Stephen Warren wrote:
> On 10/24/2016 02:13 PM, Tom Rini wrote:
> >Add 'PCI' as a menu option and migrate all existing users.
> >
> >Signed-off-by: Tom Rini 
> >---
> >Tegra is in a funny spot here.  TEGRA_COMMON will select DM_PCI and
> >DM_PCICOMPAT.  But adding PCI to the list here results in the following:
> >   aarch64: (for 61/61 boards) all +217.7 data +24.8 rodata +47.9 text +145.0
> >p2571  : all +4426 data +504 rodata +974 text +2948
> >e2220-1170 : all +4426 data +504 rodata +974 text +2948
> >p2371- : all +4426 data +504 rodata +974 text +2948
> >   arm: (for 557/557 boards) all +96.9 bss +0.1 data +7.2 rodata +23.7 
> > spl/u-boot-spl:all +0.1 spl/u-boot-spl:rodata +0.1 spl/u-boot-spl:text +0.0 
> > text +65.9
> >whistler   : all +3914 bss +28 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2664
> >paz00  : all +3908 bss +16 data +280 rodata +952 text 
> > +2660
> >colibri_t30: all +3898 bss +12 data +280 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2672
> >venice2: all +3862 bss +28 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> >plutux : all +3850 bss +32 data +280 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2604
> >nyan-big   : all +3852 bss -4 data +296 rodata +952 text 
> > +2608
> >dalmore: all +3846 bss +12 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> >seaboard   : all +3848 bss +8 data +288 rodata +952 text 
> > +2600
> >medcom-wide: all +3848 bss +16 data +280 rodata +952 text 
> > +2600
> >harmony: all +3848 bss +8 data +288 rodata +952 text 
> > +2600
> >tec-ng : all +3842 bss +8 data +288 rodata +934 
> > spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> >ventana: all +3844 bss -48 data +280 rodata +952 text 
> > +2660
> >colibri_t20: all +3836 bss -4 data +288 rodata +952 text 
> > +2600
> >tec: all +3784 bss -48 data +280 rodata +952 text 
> > +2600
> >
> >Because prior to this patch they did not set PCI and thus what code was
> >build here was largely discarded at link time.  One or two of the above
> >look to fall in to the case where PCI_TEGRA should be off, but not all.
> >What should we do about this?
> 
> >diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> 
> >@@ -38,6 +38,7 @@ config TEGRA_COMMON
> > select DM_SPI_FLASH
> > select MISC
> > select OF_CONTROL
> >+select PCI
> 
> I don't think this is correct; only a few Tegra boards have PCI, so
> we should likely enabling CONFIG_PCI from the relevant board
> defconfigs, or select it only if the Tegra PCI controller option is
> selected.
> 
> The list of Tegra boards that support PCI is:
> 
> harmony
> trimslice
> apalis
> beaver
> cardhu
> cei-tk1-som
> jetson-tk1
> p2371-2180
> p2771--000
> p2771--500

OK.  I think then the issue is that
arch/arm/mach-tegra/Kconfig::TEGRA_COMMON should not be select'ing
DM_PCI to start with and those handful of boards should be enabling all
relevant PCI options.  I'll re-work things and re-confirm that then
there are no size changes.  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI

[Stephen Warren]

On 10/24/2016 02:13 PM, Tom Rini wrote:

Add 'PCI' as a menu option and migrate all existing users.

Signed-off-by: Tom Rini 
---
Tegra is in a funny spot here.  TEGRA_COMMON will select DM_PCI and
DM_PCICOMPAT.  But adding PCI to the list here results in the following:
   aarch64: (for 61/61 boards) all +217.7 data +24.8 rodata +47.9 text +145.0
p2571  : all +4426 data +504 rodata +974 text +2948
e2220-1170 : all +4426 data +504 rodata +974 text +2948
p2371- : all +4426 data +504 rodata +974 text +2948
   arm: (for 557/557 boards) all +96.9 bss +0.1 data +7.2 rodata +23.7 
spl/u-boot-spl:all +0.1 spl/u-boot-spl:rodata +0.1 spl/u-boot-spl:text +0.0 
text +65.9
whistler   : all +3914 bss +28 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2664
paz00  : all +3908 bss +16 data +280 rodata +952 text +2660
colibri_t30: all +3898 bss +12 data +280 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2672
venice2: all +3862 bss +28 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
plutux : all +3850 bss +32 data +280 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2604
nyan-big   : all +3852 bss -4 data +296 rodata +952 text +2608
dalmore: all +3846 bss +12 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
seaboard   : all +3848 bss +8 data +288 rodata +952 text +2600
medcom-wide: all +3848 bss +16 data +280 rodata +952 text +2600
harmony: all +3848 bss +8 data +288 rodata +952 text +2600
tec-ng : all +3842 bss +8 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
ventana: all +3844 bss -48 data +280 rodata +952 text +2660
colibri_t20: all +3836 bss -4 data +288 rodata +952 text +2600
tec: all +3784 bss -48 data +280 rodata +952 text +2600

Because prior to this patch they did not set PCI and thus what code was
build here was largely discarded at link time.  One or two of the above
look to fall in to the case where PCI_TEGRA should be off, but not all.
What should we do about this?



diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig



@@ -38,6 +38,7 @@ config TEGRA_COMMON
select DM_SPI_FLASH
select MISC
select OF_CONTROL
+   select PCI


I don't think this is correct; only a few Tegra boards have PCI, so we 
should likely enabling CONFIG_PCI from the relevant board defconfigs, or 
select it only if the Tegra PCI controller option is selected.


The list of Tegra boards that support PCI is:

harmony
trimslice
apalis
beaver
cardhu
cei-tk1-som
jetson-tk1
p2371-2180
p2771--000
p2771--500
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI

[Simon Glass]

Hi Tom,

On 24 October 2016 at 13:13, Tom Rini  wrote:
> Add 'PCI' as a menu option and migrate all existing users.
>
> Signed-off-by: Tom Rini 
> ---
> Tegra is in a funny spot here.  TEGRA_COMMON will select DM_PCI and
> DM_PCICOMPAT.  But adding PCI to the list here results in the following:
>aarch64: (for 61/61 boards) all +217.7 data +24.8 rodata +47.9 text +145.0
> p2571  : all +4426 data +504 rodata +974 text +2948
> e2220-1170 : all +4426 data +504 rodata +974 text +2948
> p2371- : all +4426 data +504 rodata +974 text +2948
>arm: (for 557/557 boards) all +96.9 bss +0.1 data +7.2 rodata +23.7 
> spl/u-boot-spl:all +0.1 spl/u-boot-spl:rodata +0.1 spl/u-boot-spl:text +0.0 
> text +65.9
> whistler   : all +3914 bss +28 data +288 rodata +934 
> spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2664
> paz00  : all +3908 bss +16 data +280 rodata +952 text 
> +2660
> colibri_t30: all +3898 bss +12 data +280 rodata +934 
> spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2672
> venice2: all +3862 bss +28 data +288 rodata +934 
> spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> plutux : all +3850 bss +32 data +280 rodata +934 
> spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2604
> nyan-big   : all +3852 bss -4 data +296 rodata +952 text +2608
> dalmore: all +3846 bss +12 data +288 rodata +934 
> spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> seaboard   : all +3848 bss +8 data +288 rodata +952 text +2600
> medcom-wide: all +3848 bss +16 data +280 rodata +952 text 
> +2600
> harmony: all +3848 bss +8 data +288 rodata +952 text +2600
> tec-ng : all +3842 bss +8 data +288 rodata +934 
> spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
> ventana: all +3844 bss -48 data +280 rodata +952 text 
> +2660
> colibri_t20: all +3836 bss -4 data +288 rodata +952 text +2600
> tec: all +3784 bss -48 data +280 rodata +952 text 
> +2600
>
> Because prior to this patch they did not set PCI and thus what code was
> build here was largely discarded at link time.  One or two of the above
> look to fall in to the case where PCI_TEGRA should be off, but not all.
> What should we do about this?

I don't think this matters. The maintainer could always adjust the
options after this patch is applied, if needed.

Reviewed-by: Simon Glass 

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI

[Tom Rini]

Add 'PCI' as a menu option and migrate all existing users.

Signed-off-by: Tom Rini 
---
Tegra is in a funny spot here.  TEGRA_COMMON will select DM_PCI and
DM_PCICOMPAT.  But adding PCI to the list here results in the following:
   aarch64: (for 61/61 boards) all +217.7 data +24.8 rodata +47.9 text +145.0
p2571  : all +4426 data +504 rodata +974 text +2948
e2220-1170 : all +4426 data +504 rodata +974 text +2948
p2371- : all +4426 data +504 rodata +974 text +2948
   arm: (for 557/557 boards) all +96.9 bss +0.1 data +7.2 rodata +23.7 
spl/u-boot-spl:all +0.1 spl/u-boot-spl:rodata +0.1 spl/u-boot-spl:text +0.0 
text +65.9
whistler   : all +3914 bss +28 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2664
paz00  : all +3908 bss +16 data +280 rodata +952 text +2660
colibri_t30: all +3898 bss +12 data +280 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2672
venice2: all +3862 bss +28 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
plutux : all +3850 bss +32 data +280 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2604
nyan-big   : all +3852 bss -4 data +296 rodata +952 text +2608
dalmore: all +3846 bss +12 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
seaboard   : all +3848 bss +8 data +288 rodata +952 text +2600
medcom-wide: all +3848 bss +16 data +280 rodata +952 text +2600
harmony: all +3848 bss +8 data +288 rodata +952 text +2600
tec-ng : all +3842 bss +8 data +288 rodata +934 
spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
ventana: all +3844 bss -48 data +280 rodata +952 text +2660
colibri_t20: all +3836 bss -4 data +288 rodata +952 text +2600
tec: all +3784 bss -48 data +280 rodata +952 text +2600

Because prior to this patch they did not set PCI and thus what code was
build here was largely discarded at link time.  One or two of the above
look to fall in to the case where PCI_TEGRA should be off, but not all.
What should we do about this?

 arch/arm/mach-tegra/Kconfig  |  1 +
 arch/sandbox/Kconfig |  7 ---
 configs/BSC9131RDB_NAND_SYSCLK100_defconfig  |  1 +
 configs/BSC9131RDB_NAND_defconfig|  1 +
 configs/BSC9131RDB_SPIFLASH_SYSCLK100_defconfig  |  1 +
 configs/BSC9131RDB_SPIFLASH_defconfig|  1 +
 configs/M5475AFE_defconfig   |  1 +
 configs/M5475BFE_defconfig   |  1 +
 configs/M5475CFE_defconfig   |  1 +
 configs/M5475DFE_defconfig   |  1 +
 configs/M5475EFE_defconfig   |  1 +
 configs/M5475FFE_defconfig   |  1 +
 configs/M5475GFE_defconfig   |  1 +
 configs/M5485AFE_defconfig   |  1 +
 configs/M5485BFE_defconfig   |  1 +
 configs/M5485CFE_defconfig   |  1 +
 configs/M5485DFE_defconfig   |  1 +
 configs/M5485EFE_defconfig   |  1 +
 configs/M5485FFE_defconfig   |  1 +
 configs/M5485GFE_defconfig   |  1 +
 configs/M5485HFE_defconfig   |  1 +
 configs/MPC832XEMDS_ATM_defconfig|  1 +
 configs/MPC832XEMDS_HOST_33_defconfig|  2 +-
 configs/MPC832XEMDS_HOST_66_defconfig|  2 +-
 configs/MPC832XEMDS_SLAVE_defconfig  |  2 +-
 configs/MPC832XEMDS_defconfig|  1 +
 configs/MPC8349EMDS_defconfig|  1 +
 configs/MPC837XEMDS_HOST_defconfig   |  1 -
 configs/MPC837XEMDS_defconfig|  1 +
 configs/O2D300_defconfig |  1 +
 configs/O2DNT2_RAMBOOT_defconfig |  1 +
 configs/O2DNT2_defconfig |  1 +
 configs/O2D_defconfig|  1 +
 configs/O2I_defconfig|  1 +
 configs/O2MNT_O2M110_defconfig   |  1 +
 configs/O2MNT_O2M112_defconfig   |  1 +
 configs/O2MNT_O2M113_defconfig   |  1 +
 configs/O2MNT_defconfig  |  1 +
 configs/O3DNT_defconfig  |  1 +
 configs/PATI_defconfig   |  1 +
 configs/TQM823L_LCD_defconfig|  1 +
 configs/TQM823L_defconfig|  1 +
 configs/TQM823M_defconfig|  1 +