Re: [U-Boot] [PATCH] gitignore: add intermediates from libfdt build

2017-09-05 Thread Bin Meng 
On Wed, Sep 6, 2017 at 9:12 AM, Tom Rini  wrote:
> On Tue, Sep 05, 2017 at 04:57:07PM +0800, Simon Glass wrote:
>> Hi Bin,
>>
>> On 5 September 2017 at 09:33, Bin Meng  wrote:
>> > On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass  wrote:
>> >> On 29 August 2017 at 17:47, Philipp Tomsich
>> >>  wrote:
>> >>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
>> >>> additional files are auto-generated/installed into the tools directory.
>> >>> List these in .gitignore to suppress having them listed as untracked.
>> >>>
>> >>> Signed-off-by: Philipp Tomsich 
>> >>> References: ee95d10 (fdt: Build the new python libfdt module)
>> >>>
>> >>> ---
>> >>>
>> >>>  .gitignore | 8 
>> >>>  1 file changed, 8 insertions(+)
>> >>
>> >> Reviewed-by: Simon Glass 
>> >
>> > I just noticed this. Shouldn't this be put in the tools/.gitignore instead?
>> >
>> > I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/
>>
>> Yes you are probably right. I have already sent a pull request though.
>>
>> Tom what do you think?
>
> We have many examples of .gitignore in subdirectories, so lets continue
> there.  I believe that keeps the file manageable.

I will post a v2 to fix this.

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] gitignore: add intermediates from libfdt build

2017-09-05 Thread Tom Rini 
On Tue, Sep 05, 2017 at 04:57:07PM +0800, Simon Glass wrote:
> Hi Bin,
> 
> On 5 September 2017 at 09:33, Bin Meng  wrote:
> > On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass  wrote:
> >> On 29 August 2017 at 17:47, Philipp Tomsich
> >>  wrote:
> >>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
> >>> additional files are auto-generated/installed into the tools directory.
> >>> List these in .gitignore to suppress having them listed as untracked.
> >>>
> >>> Signed-off-by: Philipp Tomsich 
> >>> References: ee95d10 (fdt: Build the new python libfdt module)
> >>>
> >>> ---
> >>>
> >>>  .gitignore | 8 
> >>>  1 file changed, 8 insertions(+)
> >>
> >> Reviewed-by: Simon Glass 
> >
> > I just noticed this. Shouldn't this be put in the tools/.gitignore instead?
> >
> > I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/
> 
> Yes you are probably right. I have already sent a pull request though.
> 
> Tom what do you think?

We have many examples of .gitignore in subdirectories, so lets continue
there.  I believe that keeps the file manageable.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] gitignore: add intermediates from libfdt build

2017-09-05 Thread Simon Glass 
Hi Bin,

On 5 September 2017 at 09:33, Bin Meng  wrote:
> On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass  wrote:
>> On 29 August 2017 at 17:47, Philipp Tomsich
>>  wrote:
>>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
>>> additional files are auto-generated/installed into the tools directory.
>>> List these in .gitignore to suppress having them listed as untracked.
>>>
>>> Signed-off-by: Philipp Tomsich 
>>> References: ee95d10 (fdt: Build the new python libfdt module)
>>>
>>> ---
>>>
>>>  .gitignore | 8 
>>>  1 file changed, 8 insertions(+)
>>
>> Reviewed-by: Simon Glass 
>
> I just noticed this. Shouldn't this be put in the tools/.gitignore instead?
>
> I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/

Yes you are probably right. I have already sent a pull request though.

Tom what do you think?

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] gitignore: add intermediates from libfdt build

2017-09-04 Thread Bin Meng 
On Thu, Aug 31, 2017 at 8:52 PM, Simon Glass  wrote:
> On 29 August 2017 at 17:47, Philipp Tomsich
>  wrote:
>> Since ee95d10 (fdt: Build the new python libfdt module), a number of
>> additional files are auto-generated/installed into the tools directory.
>> List these in .gitignore to suppress having them listed as untracked.
>>
>> Signed-off-by: Philipp Tomsich 
>> References: ee95d10 (fdt: Build the new python libfdt module)
>>
>> ---
>>
>>  .gitignore | 8 
>>  1 file changed, 8 insertions(+)
>
> Reviewed-by: Simon Glass 

I just noticed this. Shouldn't this be put in the tools/.gitignore instead?

I have a similar patch @ http://patchwork.ozlabs.org/patch/809493/

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] gitignore: add intermediates from libfdt build

2017-09-04 Thread sjg 
On 29 August 2017 at 17:47, Philipp Tomsich
 wrote:
> Since ee95d10 (fdt: Build the new python libfdt module), a number of
> additional files are auto-generated/installed into the tools directory.
> List these in .gitignore to suppress having them listed as untracked.
>
> Signed-off-by: Philipp Tomsich 
> References: ee95d10 (fdt: Build the new python libfdt module)
>
> ---
>
>  .gitignore | 8 
>  1 file changed, 8 insertions(+)

Reviewed-by: Simon Glass 

Applied to u-boot-dm, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] gitignore: add intermediates from libfdt build

2017-08-31 Thread Simon Glass 
On 29 August 2017 at 17:47, Philipp Tomsich
 wrote:
> Since ee95d10 (fdt: Build the new python libfdt module), a number of
> additional files are auto-generated/installed into the tools directory.
> List these in .gitignore to suppress having them listed as untracked.
>
> Signed-off-by: Philipp Tomsich 
> References: ee95d10 (fdt: Build the new python libfdt module)
>
> ---
>
>  .gitignore | 8 
>  1 file changed, 8 insertions(+)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] gitignore: add intermediates from libfdt build

2017-08-29 Thread Philipp Tomsich 
Since ee95d10 (fdt: Build the new python libfdt module), a number of
additional files are auto-generated/installed into the tools directory.
List these in .gitignore to suppress having them listed as untracked.

Signed-off-by: Philipp Tomsich 
References: ee95d10 (fdt: Build the new python libfdt module)

---

 .gitignore | 8 
 1 file changed, 8 insertions(+)

diff --git a/.gitignore b/.gitignore
index 29757aa..f6f5dae 100644
--- a/.gitignore
+++ b/.gitignore
@@ -57,6 +57,14 @@ fit-dtb.blob
 /include/config/
 /include/generated/
 
+# Since "ee95d10 fdt: Build the new python libfdt module", a number of
+# build artifacts and intermediated from the python libfdt module are
+# installed into the /tools directory.
+/tools/_libfdt.so
+/tools/libfdt.py
+/tools/libfdt.pyc
+/tools/libfdt_wrap.c
+
 # stgit generated dirs
 patches-*
 .stgit-edit.txt
-- 
2.1.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot