Re: [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error

2013-05-14 Thread Michael Heimpold
Am Montag, 13. Mai 2013, 14:14:46 schrieben Sie:
 The commit d196bd8 (env_mmc: add support for redundant environment)
 introduce the following compile error when enable reduandant
 environment support with MMC
 ---8---
 env_mmc.c:149: error: 'env_t' has no member named 'flags'
 env_mmc.c:248: error: 'env_t' has no member named 'flags'
 env_mmc.c:248: error: 'env_t' has no member named 'flags'
 env_mmc.c:250: error: 'env_t' has no member named 'flags'
 env_mmc.c:250: error: 'env_t' has no member named 'flags'
 env_mmc.c:252: error: 'env_t' has no member named 'flags'
 env_mmc.c:252: error: 'env_t' has no member named 'flags'
 env_mmc.c:254: error: 'env_t' has no member named 'flags'
 env_mmc.c:254: error: 'env_t' has no member named 'flags'
 env_mmc.c:267: error: 'env_t' has no member named 'flags'
 make[1]: *** [env_mmc.o] Error 1
 ---8---
 
 Add this patch to fix it
 
 Signed-off-by: Bo Shen voice.s...@atmel.com
 ---
  include/environment.h |6 ++
  1 file changed, 6 insertions(+)
 
 diff --git a/include/environment.h b/include/environment.h
 index 4c6a37b..460ccb4 100644
 --- a/include/environment.h
 +++ b/include/environment.h
 @@ -75,6 +75,12 @@
  # endif
  #endif   /* CONFIG_ENV_IS_IN_FLASH */
  
 +#if defined(CONFIG_ENV_IS_IN_MMC)
 +# ifdef CONFIG_ENV_OFFSET_REDUND
 +#  define CONFIG_SYS_REDUNDAND_ENVIRONMENT
 +# endif
 +#endif
 +
  #if defined(CONFIG_ENV_IS_IN_NAND)
  # if defined(CONFIG_ENV_OFFSET_OOB)
  #  ifdef CONFIG_ENV_OFFSET_REDUND
 

s/reduandant/redundant/

Reviewed-by: Michael Heimpold m...@heimpold.de

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error

2013-05-14 Thread Bo Shen

Hi Michael,

On 5/15/2013 02:16, Michael Heimpold wrote:

Am Montag, 13. Mai 2013, 14:14:46 schrieben Sie:

The commit d196bd8 (env_mmc: add support for redundant environment)
introduce the following compile error when enable reduandant
environment support with MMC
---8---
env_mmc.c:149: error: 'env_t' has no member named 'flags'
env_mmc.c:248: error: 'env_t' has no member named 'flags'
env_mmc.c:248: error: 'env_t' has no member named 'flags'
env_mmc.c:250: error: 'env_t' has no member named 'flags'
env_mmc.c:250: error: 'env_t' has no member named 'flags'
env_mmc.c:252: error: 'env_t' has no member named 'flags'
env_mmc.c:252: error: 'env_t' has no member named 'flags'
env_mmc.c:254: error: 'env_t' has no member named 'flags'
env_mmc.c:254: error: 'env_t' has no member named 'flags'
env_mmc.c:267: error: 'env_t' has no member named 'flags'
make[1]: *** [env_mmc.o] Error 1
---8---

Add this patch to fix it

Signed-off-by: Bo Shen voice.s...@atmel.com
---
  include/environment.h |6 ++
  1 file changed, 6 insertions(+)

diff --git a/include/environment.h b/include/environment.h
index 4c6a37b..460ccb4 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -75,6 +75,12 @@
  # endif
  #endif/* CONFIG_ENV_IS_IN_FLASH */

+#if defined(CONFIG_ENV_IS_IN_MMC)
+# ifdef CONFIG_ENV_OFFSET_REDUND
+#  define CONFIG_SYS_REDUNDAND_ENVIRONMENT
+# endif
+#endif
+
  #if defined(CONFIG_ENV_IS_IN_NAND)
  # if defined(CONFIG_ENV_OFFSET_OOB)
  #  ifdef CONFIG_ENV_OFFSET_REDUND



s/reduandant/redundant/


Thanks for figure out this, I will correct it in next version.


Reviewed-by: Michael Heimpold m...@heimpold.de


In next version, I will add your Reviewed-by tag.

Best Regards,
Bo Shen
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error

2013-05-13 Thread Bo Shen
The commit d196bd8 (env_mmc: add support for redundant environment)
introduce the following compile error when enable reduandant
environment support with MMC
---8---
env_mmc.c:149: error: 'env_t' has no member named 'flags'
env_mmc.c:248: error: 'env_t' has no member named 'flags'
env_mmc.c:248: error: 'env_t' has no member named 'flags'
env_mmc.c:250: error: 'env_t' has no member named 'flags'
env_mmc.c:250: error: 'env_t' has no member named 'flags'
env_mmc.c:252: error: 'env_t' has no member named 'flags'
env_mmc.c:252: error: 'env_t' has no member named 'flags'
env_mmc.c:254: error: 'env_t' has no member named 'flags'
env_mmc.c:254: error: 'env_t' has no member named 'flags'
env_mmc.c:267: error: 'env_t' has no member named 'flags'
make[1]: *** [env_mmc.o] Error 1
---8---

Add this patch to fix it

Signed-off-by: Bo Shen voice.s...@atmel.com
---
 include/environment.h |6 ++
 1 file changed, 6 insertions(+)

diff --git a/include/environment.h b/include/environment.h
index 4c6a37b..460ccb4 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -75,6 +75,12 @@
 # endif
 #endif /* CONFIG_ENV_IS_IN_FLASH */
 
+#if defined(CONFIG_ENV_IS_IN_MMC)
+# ifdef CONFIG_ENV_OFFSET_REDUND
+#  define CONFIG_SYS_REDUNDAND_ENVIRONMENT
+# endif
+#endif
+
 #if defined(CONFIG_ENV_IS_IN_NAND)
 # if defined(CONFIG_ENV_OFFSET_OOB)
 #  ifdef CONFIG_ENV_OFFSET_REDUND
-- 
1.7.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot