subject:"\[U\-Boot\] \[PATCH\] mmc\: fix the wrong dislabing clock"

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

2018-01-21 Thread Jaehoon Chung

On 01/17/2018 07:36 PM, Jaehoon Chung wrote:
> When power is off, clock is not disabling.
> Because it's passed to 1, mmc->clock should be set to f_min value.
> Some drivers can't initialize the eMMC/SD card with current status.
> 
> This patch is to fix the disabling clock value to 0.
> 
> Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off")
> 
> Signed-off-by: Jaehoon Chung 

Applied to u-boot-mmc. Thanks.

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/mmc.c | 12 +++-
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 53c819187e..311f51f237 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1501,11 +1501,13 @@ static int mmc_set_ios(struct mmc *mmc)
>  
>  int mmc_set_clock(struct mmc *mmc, uint clock, bool disable)
>  {
> - if (clock > mmc->cfg->f_max)
> - clock = mmc->cfg->f_max;
> + if (!disable && clock != 0) {
> + if (clock > mmc->cfg->f_max)
> + clock = mmc->cfg->f_max;
>  
> - if (clock < mmc->cfg->f_min)
> - clock = mmc->cfg->f_min;
> + if (clock < mmc->cfg->f_min)
> + clock = mmc->cfg->f_min;
> + }
>  
>   mmc->clock = clock;
>   mmc->clk_disable = disable;
> @@ -2449,7 +2451,7 @@ static int mmc_power_on(struct mmc *mmc)
>  
>  static int mmc_power_off(struct mmc *mmc)
>  {
> - mmc_set_clock(mmc, 1, true);
> + mmc_set_clock(mmc, 0, true);
>  #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
>   if (mmc->vmmc_supply) {
>   int ret = regulator_set_enable(mmc->vmmc_supply, false);
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

2018-01-18 Thread Anand Moon

Hi JaeHoon,

On 17 January 2018 at 16:06, Jaehoon Chung  wrote:
> When power is off, clock is not disabling.
> Because it's passed to 1, mmc->clock should be set to f_min value.
> Some drivers can't initialize the eMMC/SD card with current status.
>
> This patch is to fix the disabling clock value to 0.
>
> Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off")
>
> Signed-off-by: Jaehoon Chung 
> ---
>  drivers/mmc/mmc.c | 12 +++-
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 53c819187e..311f51f237 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1501,11 +1501,13 @@ static int mmc_set_ios(struct mmc *mmc)
>
>  int mmc_set_clock(struct mmc *mmc, uint clock, bool disable)
>  {
> -   if (clock > mmc->cfg->f_max)
> -   clock = mmc->cfg->f_max;
> +   if (!disable && clock != 0) {
> +   if (clock > mmc->cfg->f_max)
> +   clock = mmc->cfg->f_max;
>
> -   if (clock < mmc->cfg->f_min)
> -   clock = mmc->cfg->f_min;
> +   if (clock < mmc->cfg->f_min)
> +   clock = mmc->cfg->f_min;
> +   }
>
> mmc->clock = clock;
> mmc->clk_disable = disable;
> @@ -2449,7 +2451,7 @@ static int mmc_power_on(struct mmc *mmc)
>
>  static int mmc_power_off(struct mmc *mmc)
>  {
> -   mmc_set_clock(mmc, 1, true);
> +   mmc_set_clock(mmc, 0, true);
>  #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
> if (mmc->vmmc_supply) {
> int ret = regulator_set_enable(mmc->vmmc_supply, false);
> --
> 2.15.1
>

I have tested this patch on Odroid Xu4 on sd_card and eMMC module
and all seem to be working.

Tested-by: Anand Moon 

Best Regards
-Anand
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

2018-01-18 Thread Guillaume Gardet


Hi,


Le 17/01/2018 à 11:36, Jaehoon Chung a écrit :

When power is off, clock is not disabling.
Because it's passed to 1, mmc->clock should be set to f_min value.
Some drivers can't initialize the eMMC/SD card with current status.


This fixes the MMC boot for snow (Chromebook). Thanks a lot!

Tested-by: Guillaume GARDET 


Guillaume




This patch is to fix the disabling clock value to 0.

Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off")

Signed-off-by: Jaehoon Chung 
---
  drivers/mmc/mmc.c | 12 +++-
  1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 53c819187e..311f51f237 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -1501,11 +1501,13 @@ static int mmc_set_ios(struct mmc *mmc)
  
  int mmc_set_clock(struct mmc *mmc, uint clock, bool disable)

  {
-   if (clock > mmc->cfg->f_max)
-   clock = mmc->cfg->f_max;
+   if (!disable && clock != 0) {
+   if (clock > mmc->cfg->f_max)
+   clock = mmc->cfg->f_max;
  
-	if (clock < mmc->cfg->f_min)

-   clock = mmc->cfg->f_min;
+   if (clock < mmc->cfg->f_min)
+   clock = mmc->cfg->f_min;
+   }
  
  	mmc->clock = clock;

mmc->clk_disable = disable;
@@ -2449,7 +2451,7 @@ static int mmc_power_on(struct mmc *mmc)
  
  static int mmc_power_off(struct mmc *mmc)

  {
-   mmc_set_clock(mmc, 1, true);
+   mmc_set_clock(mmc, 0, true);
  #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
if (mmc->vmmc_supply) {
int ret = regulator_set_enable(mmc->vmmc_supply, false);


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

2018-01-17 Thread Jean-Jacques Hiblot




On 17/01/2018 11:56, Jaehoon Chung wrote:

Hi,

On 01/17/2018 07:36 PM, Jaehoon Chung wrote:

When power is off, clock is not disabling.
Because it's passed to 1, mmc->clock should be set to f_min value.
Some drivers can't initialize the eMMC/SD card with current status.

This patch is to fix the disabling clock value to 0.

Subject is typo..Will resend. but i want to get the opinion about this patch.


It looks good to me.

Reviewed-by: Jean-Jacques Hiblot 




Best Regards,
Jaehoon Chung


Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off")

Signed-off-by: Jaehoon Chung 
---
  drivers/mmc/mmc.c | 12 +++-
  1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 53c819187e..311f51f237 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -1501,11 +1501,13 @@ static int mmc_set_ios(struct mmc *mmc)
  
  int mmc_set_clock(struct mmc *mmc, uint clock, bool disable)

  {
-   if (clock > mmc->cfg->f_max)
-   clock = mmc->cfg->f_max;
+   if (!disable && clock != 0) {
+   if (clock > mmc->cfg->f_max)
+   clock = mmc->cfg->f_max;
  
-	if (clock < mmc->cfg->f_min)

-   clock = mmc->cfg->f_min;
+   if (clock < mmc->cfg->f_min)
+   clock = mmc->cfg->f_min;
+   }
  
  	mmc->clock = clock;

mmc->clk_disable = disable;
@@ -2449,7 +2451,7 @@ static int mmc_power_on(struct mmc *mmc)
  
  static int mmc_power_off(struct mmc *mmc)

  {
-   mmc_set_clock(mmc, 1, true);
+   mmc_set_clock(mmc, 0, true);
  #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
if (mmc->vmmc_supply) {
int ret = regulator_set_enable(mmc->vmmc_supply, false);





___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

2018-01-17 Thread Jaehoon Chung

Hi, 

On 01/17/2018 07:36 PM, Jaehoon Chung wrote:
> When power is off, clock is not disabling.
> Because it's passed to 1, mmc->clock should be set to f_min value.
> Some drivers can't initialize the eMMC/SD card with current status.
> 
> This patch is to fix the disabling clock value to 0.

Subject is typo..Will resend. but i want to get the opinion about this patch.

Best Regards,
Jaehoon Chung

> 
> Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off")
> 
> Signed-off-by: Jaehoon Chung 
> ---
>  drivers/mmc/mmc.c | 12 +++-
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 53c819187e..311f51f237 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1501,11 +1501,13 @@ static int mmc_set_ios(struct mmc *mmc)
>  
>  int mmc_set_clock(struct mmc *mmc, uint clock, bool disable)
>  {
> - if (clock > mmc->cfg->f_max)
> - clock = mmc->cfg->f_max;
> + if (!disable && clock != 0) {
> + if (clock > mmc->cfg->f_max)
> + clock = mmc->cfg->f_max;
>  
> - if (clock < mmc->cfg->f_min)
> - clock = mmc->cfg->f_min;
> + if (clock < mmc->cfg->f_min)
> + clock = mmc->cfg->f_min;
> + }
>  
>   mmc->clock = clock;
>   mmc->clk_disable = disable;
> @@ -2449,7 +2451,7 @@ static int mmc_power_on(struct mmc *mmc)
>  
>  static int mmc_power_off(struct mmc *mmc)
>  {
> - mmc_set_clock(mmc, 1, true);
> + mmc_set_clock(mmc, 0, true);
>  #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
>   if (mmc->vmmc_supply) {
>   int ret = regulator_set_enable(mmc->vmmc_supply, false);
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] mmc: fix the wrong dislabing clock

2018-01-17 Thread Jaehoon Chung

When power is off, clock is not disabling.
Because it's passed to 1, mmc->clock should be set to f_min value.
Some drivers can't initialize the eMMC/SD card with current status.

This patch is to fix the disabling clock value to 0.

Fixes: 2e7410d76ad1 ("mmc: disable the mmc clock during power off")

Signed-off-by: Jaehoon Chung 
---
 drivers/mmc/mmc.c | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 53c819187e..311f51f237 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -1501,11 +1501,13 @@ static int mmc_set_ios(struct mmc *mmc)
 
 int mmc_set_clock(struct mmc *mmc, uint clock, bool disable)
 {
-   if (clock > mmc->cfg->f_max)
-   clock = mmc->cfg->f_max;
+   if (!disable && clock != 0) {
+   if (clock > mmc->cfg->f_max)
+   clock = mmc->cfg->f_max;
 
-   if (clock < mmc->cfg->f_min)
-   clock = mmc->cfg->f_min;
+   if (clock < mmc->cfg->f_min)
+   clock = mmc->cfg->f_min;
+   }
 
mmc->clock = clock;
mmc->clk_disable = disable;
@@ -2449,7 +2451,7 @@ static int mmc_power_on(struct mmc *mmc)
 
 static int mmc_power_off(struct mmc *mmc)
 {
-   mmc_set_clock(mmc, 1, true);
+   mmc_set_clock(mmc, 0, true);
 #if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_REGULATOR)
if (mmc->vmmc_supply) {
int ret = regulator_set_enable(mmc->vmmc_supply, false);
-- 
2.15.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

Re: [U-Boot] [PATCH] mmc: fix the wrong dislabing clock

[U-Boot] [PATCH] mmc: fix the wrong dislabing clock

6 matches

Site Navigation

Mail list logo

Footer information