Re: [U-Boot] [PATCH] mx28evk: add trimffs to nand command

2013-04-16 Thread Stefano Babic
On 08/04/2013 20:59, Eric Bénard wrote:
 this is usefull when writing an UBI image which contains
 and UBIFS volume (check README.nand and UBI FAQ for more details)
 
 Signed-off-by: Eric Bénard e...@eukrea.com
 ---

Applied to u-boot-imx, -next branch, thanks.

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] mx28evk: add trimffs to nand command

2013-04-09 Thread Otavio Salvador
On Mon, Apr 8, 2013 at 3:59 PM, Eric Bénard e...@eukrea.com wrote:
 this is usefull when writing an UBI image which contains
 and UBIFS volume (check README.nand and UBI FAQ for more details)

 Signed-off-by: Eric Bénard e...@eukrea.com

Acked-by: Otavio Salvador ota...@ossystems.com.br

--
Otavio Salvador O.S. Systems
E-mail: ota...@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854  http://projetos.ossystems.com.br
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] mx28evk: add trimffs to nand command

2013-04-09 Thread Fabio Estevam
Eric Bénard wrote:
 this is usefull when writing an UBI image which contains
 and UBIFS volume (check README.nand and UBI FAQ for more details)
 
 Signed-off-by: Eric Bénard e...@eukrea.com
 ---
  include/configs/mx28evk.h | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
 index d470b47..b22a20b 100644
 --- a/include/configs/mx28evk.h
 +++ b/include/configs/mx28evk.h
 @@ -63,6 +63,7 @@
  #define CONFIG_CMD_USB
  #define CONFIG_CMD_BOOTZ
  #define CONFIG_CMD_NAND
 +#define CONFIG_CMD_NAND_TRIMFFS

You should add this into mx28evk_nand.h, available in u-boot.imx tree.


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] mx28evk: add trimffs to nand command

2013-04-09 Thread Eric Bénard
Hi Fabio,

Le Tue, 9 Apr 2013 15:02:44 -0300,
Fabio Estevam fabio.este...@freescale.com a écrit :

 Eric Bénard wrote:
  this is usefull when writing an UBI image which contains
  and UBIFS volume (check README.nand and UBI FAQ for more details)
  
  Signed-off-by: Eric Bénard e...@eukrea.com
  ---
   include/configs/mx28evk.h | 1 +
   1 file changed, 1 insertion(+)
  
  diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
  index d470b47..b22a20b 100644
  --- a/include/configs/mx28evk.h
  +++ b/include/configs/mx28evk.h
  @@ -63,6 +63,7 @@
   #define CONFIG_CMD_USB
   #define CONFIG_CMD_BOOTZ
   #define CONFIG_CMD_NAND
  +#define CONFIG_CMD_NAND_TRIMFFS
 
 You should add this into mx28evk_nand.h, available in u-boot.imx tree.

that's the second time you ask this but mx28evk_nand.h doesn't exist,
even in u-boot-imx tree, and you are the developer who added nand
support to mx28evk in commit
ab461be65dbfe3e2fa45f7cd836faa99663be5bb ;-)

Here is a reminder of what you did in that commit : you added the
mx28evk_nand option in boards.cfg which defines ENV_IS_IN_NAND when
mx28evk defines ENV_IS_IN_MMC and both are using the same config which
is include/configs/mx28evk.h :
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=ab461be65dbfe3e2fa45f7cd836faa99663be5bb

So this patch is fine against u-boot-imx.

Best regards
Eric
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] mx28evk: add trimffs to nand command

2013-04-09 Thread Fabio Estevam
Hi Eric,

On Tue, Apr 9, 2013 at 4:21 PM, Eric Bénard e...@eukrea.com wrote:

 that's the second time you ask this but mx28evk_nand.h doesn't exist,
 even in u-boot-imx tree, and you are the developer who added nand
 support to mx28evk in commit
 ab461be65dbfe3e2fa45f7cd836faa99663be5bb ;-)

Right, mx28_evk.h only existed in my first version of the patch, and
then the patch I submitted handles both ENV_IS_NAND and ENV_IS_MMC
with the same config file.

Sorry for the confusion :-)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] mx28evk: add trimffs to nand command

2013-04-08 Thread Eric Bénard
this is usefull when writing an UBI image which contains
and UBIFS volume (check README.nand and UBI FAQ for more details)

Signed-off-by: Eric Bénard e...@eukrea.com
---
 include/configs/mx28evk.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index d470b47..b22a20b 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -63,6 +63,7 @@
 #define CONFIG_CMD_USB
 #define CONFIG_CMD_BOOTZ
 #define CONFIG_CMD_NAND
+#define CONFIG_CMD_NAND_TRIMFFS
 
 /* Memory configurations */
 #define CONFIG_NR_DRAM_BANKS   1   /* 1 bank of DRAM */
-- 
1.7.11.7

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot