Re: [U-Boot] [PATCH] power: pmic: Let PFUZE3000 see all 256 registers
On 27/06/2018 03:37, Fabio Estevam wrote: > Hi Stefano, > > Could you please consider this one for 2018.07? > Hi Fabio, sure, is u-boot-imx the right tree for it ? Anyway, applied to u-boot-imx, thanks ! Best regards, Stefano > Thanks > > On Wed, Apr 25, 2018 at 2:06 PM, Trent Piepho wrote: >> The PFUZE3000 uses registers addresses up to 0xff. >> >> The DM pfuze100 driver supports both pfuze100 and pfuze3000. Allow it >> to use the device type to return the correct number of registers. >> >> Also rename the too generic PMIC_NUM_OF_REGS enumeration value for >> pfuze3000 to match the other "PFUZE3000_" prefixed enumerations and the >> pfuze100 enumeration value PFUZE100_NUM_OF_REGS. >> >> Cc: Peng Fan >> Cc: Jaehoon Chung >> Cc: Stefano Babic >> Cc: Fabio Estevam >> Signed-off-by: Trent Piepho >> --- >> drivers/power/pmic/pfuze100.c | 3 ++- >> drivers/power/pmic/pmic_pfuze3000.c | 2 +- >> include/power/pfuze3000_pmic.h | 2 +- >> 3 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/power/pmic/pfuze100.c b/drivers/power/pmic/pfuze100.c >> index a06cbc07d4..f85ad25981 100644 >> --- a/drivers/power/pmic/pfuze100.c >> +++ b/drivers/power/pmic/pfuze100.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> >> DECLARE_GLOBAL_DATA_PTR; >> >> @@ -26,7 +27,7 @@ static const struct pmic_child_info pmic_children_info[] = >> { >> >> static int pfuze100_reg_count(struct udevice *dev) >> { >> - return PFUZE100_NUM_OF_REGS; >> + return dev->driver_data == PFUZE3000 ? PFUZE3000_NUM_OF_REGS : >> PFUZE100_NUM_OF_REGS; >> } >> >> static int pfuze100_write(struct udevice *dev, uint reg, const uint8_t >> *buff, >> diff --git a/drivers/power/pmic/pmic_pfuze3000.c >> b/drivers/power/pmic/pmic_pfuze3000.c >> index ac807a801f..d0f358f808 100644 >> --- a/drivers/power/pmic/pmic_pfuze3000.c >> +++ b/drivers/power/pmic/pmic_pfuze3000.c >> @@ -23,7 +23,7 @@ int power_pfuze3000_init(unsigned char bus) >> >> p->name = name; >> p->interface = PMIC_I2C; >> - p->number_of_regs = PMIC_NUM_OF_REGS; >> + p->number_of_regs = PFUZE3000_NUM_OF_REGS; >> p->hw.i2c.addr = CONFIG_POWER_PFUZE3000_I2C_ADDR; >> p->hw.i2c.tx_num = 1; >> p->bus = bus; >> diff --git a/include/power/pfuze3000_pmic.h b/include/power/pfuze3000_pmic.h >> index 7d66ba48d4..94946e9594 100644 >> --- a/include/power/pfuze3000_pmic.h >> +++ b/include/power/pfuze3000_pmic.h >> @@ -70,7 +70,7 @@ enum { >> PFUZE3000_VLDO3CTL = 0x70, >> PFUZE3000_VLD4CTL = 0x71, >> >> - PMIC_NUM_OF_REGS= 0x7F, >> + PFUZE3000_NUM_OF_REGS = 0x100, >> }; >> >> int power_pfuze3000_init(unsigned char bus); >> -- >> 2.14.3 >> >> ___ >> U-Boot mailing list >> U-Boot@lists.denx.de >> https://lists.denx.de/listinfo/u-boot -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] power: pmic: Let PFUZE3000 see all 256 registers
Hi Stefano, Could you please consider this one for 2018.07? Thanks On Wed, Apr 25, 2018 at 2:06 PM, Trent Piepho wrote: > The PFUZE3000 uses registers addresses up to 0xff. > > The DM pfuze100 driver supports both pfuze100 and pfuze3000. Allow it > to use the device type to return the correct number of registers. > > Also rename the too generic PMIC_NUM_OF_REGS enumeration value for > pfuze3000 to match the other "PFUZE3000_" prefixed enumerations and the > pfuze100 enumeration value PFUZE100_NUM_OF_REGS. > > Cc: Peng Fan > Cc: Jaehoon Chung > Cc: Stefano Babic > Cc: Fabio Estevam > Signed-off-by: Trent Piepho > --- > drivers/power/pmic/pfuze100.c | 3 ++- > drivers/power/pmic/pmic_pfuze3000.c | 2 +- > include/power/pfuze3000_pmic.h | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/pmic/pfuze100.c b/drivers/power/pmic/pfuze100.c > index a06cbc07d4..f85ad25981 100644 > --- a/drivers/power/pmic/pfuze100.c > +++ b/drivers/power/pmic/pfuze100.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > DECLARE_GLOBAL_DATA_PTR; > > @@ -26,7 +27,7 @@ static const struct pmic_child_info pmic_children_info[] = { > > static int pfuze100_reg_count(struct udevice *dev) > { > - return PFUZE100_NUM_OF_REGS; > + return dev->driver_data == PFUZE3000 ? PFUZE3000_NUM_OF_REGS : > PFUZE100_NUM_OF_REGS; > } > > static int pfuze100_write(struct udevice *dev, uint reg, const uint8_t *buff, > diff --git a/drivers/power/pmic/pmic_pfuze3000.c > b/drivers/power/pmic/pmic_pfuze3000.c > index ac807a801f..d0f358f808 100644 > --- a/drivers/power/pmic/pmic_pfuze3000.c > +++ b/drivers/power/pmic/pmic_pfuze3000.c > @@ -23,7 +23,7 @@ int power_pfuze3000_init(unsigned char bus) > > p->name = name; > p->interface = PMIC_I2C; > - p->number_of_regs = PMIC_NUM_OF_REGS; > + p->number_of_regs = PFUZE3000_NUM_OF_REGS; > p->hw.i2c.addr = CONFIG_POWER_PFUZE3000_I2C_ADDR; > p->hw.i2c.tx_num = 1; > p->bus = bus; > diff --git a/include/power/pfuze3000_pmic.h b/include/power/pfuze3000_pmic.h > index 7d66ba48d4..94946e9594 100644 > --- a/include/power/pfuze3000_pmic.h > +++ b/include/power/pfuze3000_pmic.h > @@ -70,7 +70,7 @@ enum { > PFUZE3000_VLDO3CTL = 0x70, > PFUZE3000_VLD4CTL = 0x71, > > - PMIC_NUM_OF_REGS= 0x7F, > + PFUZE3000_NUM_OF_REGS = 0x100, > }; > > int power_pfuze3000_init(unsigned char bus); > -- > 2.14.3 > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] power: pmic: Let PFUZE3000 see all 256 registers
[Adding Stefano] On Thu, May 31, 2018 at 3:01 PM, Trent Piepho wrote: > Ping. Been a while. 2018.05 is out. > > On Thu, 2018-04-26 at 03:22 -0300, Fabio Estevam wrote: >> On Wed, Apr 25, 2018 at 2:06 PM, Trent Piepho >> wrote: >> > The PFUZE3000 uses registers addresses up to 0xff. >> > >> > The DM pfuze100 driver supports both pfuze100 and pfuze3000. Allow >> > it >> > to use the device type to return the correct number of registers. >> > >> > Also rename the too generic PMIC_NUM_OF_REGS enumeration value for >> > pfuze3000 to match the other "PFUZE3000_" prefixed enumerations and >> > the >> > pfuze100 enumeration value PFUZE100_NUM_OF_REGS. >> > >> > Cc: Peng Fan >> > Cc: Jaehoon Chung >> > Cc: Stefano Babic >> > Cc: Fabio Estevam >> > Signed-off-by: Trent Piepho >> >> Reviewed-by: Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] power: pmic: Let PFUZE3000 see all 256 registers
Ping. Been a while. 2018.05 is out. On Thu, 2018-04-26 at 03:22 -0300, Fabio Estevam wrote: > On Wed, Apr 25, 2018 at 2:06 PM, Trent Piepho > wrote: > > The PFUZE3000 uses registers addresses up to 0xff. > > > > The DM pfuze100 driver supports both pfuze100 and pfuze3000. Allow > > it > > to use the device type to return the correct number of registers. > > > > Also rename the too generic PMIC_NUM_OF_REGS enumeration value for > > pfuze3000 to match the other "PFUZE3000_" prefixed enumerations and > > the > > pfuze100 enumeration value PFUZE100_NUM_OF_REGS. > > > > Cc: Peng Fan > > Cc: Jaehoon Chung > > Cc: Stefano Babic > > Cc: Fabio Estevam > > Signed-off-by: Trent Piepho > > Reviewed-by: Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] power: pmic: Let PFUZE3000 see all 256 registers
On Wed, Apr 25, 2018 at 2:06 PM, Trent Piephowrote: > The PFUZE3000 uses registers addresses up to 0xff. > > The DM pfuze100 driver supports both pfuze100 and pfuze3000. Allow it > to use the device type to return the correct number of registers. > > Also rename the too generic PMIC_NUM_OF_REGS enumeration value for > pfuze3000 to match the other "PFUZE3000_" prefixed enumerations and the > pfuze100 enumeration value PFUZE100_NUM_OF_REGS. > > Cc: Peng Fan > Cc: Jaehoon Chung > Cc: Stefano Babic > Cc: Fabio Estevam > Signed-off-by: Trent Piepho Reviewed-by: Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] power: pmic: Let PFUZE3000 see all 256 registers
The PFUZE3000 uses registers addresses up to 0xff. The DM pfuze100 driver supports both pfuze100 and pfuze3000. Allow it to use the device type to return the correct number of registers. Also rename the too generic PMIC_NUM_OF_REGS enumeration value for pfuze3000 to match the other "PFUZE3000_" prefixed enumerations and the pfuze100 enumeration value PFUZE100_NUM_OF_REGS. Cc: Peng FanCc: Jaehoon Chung Cc: Stefano Babic Cc: Fabio Estevam Signed-off-by: Trent Piepho --- drivers/power/pmic/pfuze100.c | 3 ++- drivers/power/pmic/pmic_pfuze3000.c | 2 +- include/power/pfuze3000_pmic.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/power/pmic/pfuze100.c b/drivers/power/pmic/pfuze100.c index a06cbc07d4..f85ad25981 100644 --- a/drivers/power/pmic/pfuze100.c +++ b/drivers/power/pmic/pfuze100.c @@ -13,6 +13,7 @@ #include #include #include +#include DECLARE_GLOBAL_DATA_PTR; @@ -26,7 +27,7 @@ static const struct pmic_child_info pmic_children_info[] = { static int pfuze100_reg_count(struct udevice *dev) { - return PFUZE100_NUM_OF_REGS; + return dev->driver_data == PFUZE3000 ? PFUZE3000_NUM_OF_REGS : PFUZE100_NUM_OF_REGS; } static int pfuze100_write(struct udevice *dev, uint reg, const uint8_t *buff, diff --git a/drivers/power/pmic/pmic_pfuze3000.c b/drivers/power/pmic/pmic_pfuze3000.c index ac807a801f..d0f358f808 100644 --- a/drivers/power/pmic/pmic_pfuze3000.c +++ b/drivers/power/pmic/pmic_pfuze3000.c @@ -23,7 +23,7 @@ int power_pfuze3000_init(unsigned char bus) p->name = name; p->interface = PMIC_I2C; - p->number_of_regs = PMIC_NUM_OF_REGS; + p->number_of_regs = PFUZE3000_NUM_OF_REGS; p->hw.i2c.addr = CONFIG_POWER_PFUZE3000_I2C_ADDR; p->hw.i2c.tx_num = 1; p->bus = bus; diff --git a/include/power/pfuze3000_pmic.h b/include/power/pfuze3000_pmic.h index 7d66ba48d4..94946e9594 100644 --- a/include/power/pfuze3000_pmic.h +++ b/include/power/pfuze3000_pmic.h @@ -70,7 +70,7 @@ enum { PFUZE3000_VLDO3CTL = 0x70, PFUZE3000_VLD4CTL = 0x71, - PMIC_NUM_OF_REGS= 0x7F, + PFUZE3000_NUM_OF_REGS = 0x100, }; int power_pfuze3000_init(unsigned char bus); -- 2.14.3 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot