Re: [U-Boot] [PATCH] power: tps65910: replace error() by pr_err()

2017-12-19 Thread Simon Glass
On 18 December 2017 at 07:38, Felix Brack  wrote:
> The patch replaces the former error() by the new pr_err().
> This makes the TPS65910 driver conform to Masahiro's patch
> 'treewide:replace with error() with pr_err()' introduced
> October 2017.
>
> Signed-off-by: Felix Brack 
> ---
>
>  drivers/power/pmic/pmic_tps65910_dm.c| 4 ++--
>  drivers/power/regulator/tps65910_regulator.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH] power: tps65910: replace error() by pr_err()

2017-12-18 Thread Felix Brack
The patch replaces the former error() by the new pr_err().
This makes the TPS65910 driver conform to Masahiro's patch
'treewide:replace with error() with pr_err()' introduced
October 2017.

Signed-off-by: Felix Brack 
---

 drivers/power/pmic/pmic_tps65910_dm.c| 4 ++--
 drivers/power/regulator/tps65910_regulator.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/power/pmic/pmic_tps65910_dm.c 
b/drivers/power/pmic/pmic_tps65910_dm.c
index 0127ce3..c65f38f 100644
--- a/drivers/power/pmic/pmic_tps65910_dm.c
+++ b/drivers/power/pmic/pmic_tps65910_dm.c
@@ -32,7 +32,7 @@ static int pmic_tps65910_write(struct udevice *dev, uint reg, 
const u8 *buffer,
 
ret = dm_i2c_write(dev, reg, buffer, len);
if (ret)
-   error("%s write error on register %02x\n", dev->name, reg);
+   pr_err("%s write error on register %02x\n", dev->name, reg);
 
return ret;
 }
@@ -44,7 +44,7 @@ static int pmic_tps65910_read(struct udevice *dev, uint reg, 
u8 *buffer,
 
ret = dm_i2c_read(dev, reg, buffer, len);
if (ret)
-   error("%s read error on register %02x\n", dev->name, reg);
+   pr_err("%s read error on register %02x\n", dev->name, reg);
 
return ret;
 }
diff --git a/drivers/power/regulator/tps65910_regulator.c 
b/drivers/power/regulator/tps65910_regulator.c
index 5e2ec8f..ad952e5 100644
--- a/drivers/power/regulator/tps65910_regulator.c
+++ b/drivers/power/regulator/tps65910_regulator.c
@@ -340,11 +340,11 @@ static int buck_set_vdd1_vdd2_value(struct udevice *dev, 
int uV)
 
/* check setpoint is within limits */
if (uV < uc_pdata->min_uV) {
-   error("voltage %duV for %s too low\n", uV, dev->name);
+   pr_err("voltage %duV for %s too low\n", uV, dev->name);
return -EINVAL;
}
if (uV > uc_pdata->max_uV) {
-   error("voltage %duV for %s too high\n", uV, dev->name);
+   pr_err("voltage %duV for %s too high\n", uV, dev->name);
return -EINVAL;
}
 
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot