Re: [U-Boot] [PATCH] rockchip: Add support for MiQi rk3288 board

2017-03-24 Thread Jernej Škrabec
Hi Kever,

Dne petek, 24. marec 2017 ob 03:38:16 CET je Kever Yang napisal(a):
> Hi Jernej,
> 
> On 03/24/2017 08:11 AM, Jernej Skrabec wrote:
> > MiQi is rk3288 based development board with 1 or 2 GB SDRAM, 16 GB eMMC,
> > micro SD card interface, 4 USB 2.0 ports, HDMI, gigabit Ethernet and
> > expansion ports.
> > 
> > Signed-off-by: Jernej Skrabec 
> > ---
> > 
> >   arch/arm/dts/Makefile   |   1 +
> >   arch/arm/dts/rk3288-miqi.dts|  46 
> >   arch/arm/dts/rk3288-miqi.dtsi   | 459
> >    arch/arm/mach-rockchip/rk3288/Kconfig 
> >|  11 +
> >   board/mqmaker/miqi_rk3288/Kconfig   |  15 ++
> >   board/mqmaker/miqi_rk3288/MAINTAINERS   |   6 +
> >   board/mqmaker/miqi_rk3288/Makefile  |   7 +
> >   board/mqmaker/miqi_rk3288/miqi-rk3288.c |  15 ++
> >   configs/miqi-rk3288_defconfig   |  73 +
> >   doc/README.rockchip |   5 +-
> >   include/configs/miqi_rk3288.h   |  22 ++
> >   11 files changed, 658 insertions(+), 2 deletions(-)
> >   create mode 100644 arch/arm/dts/rk3288-miqi.dts
> >   create mode 100644 arch/arm/dts/rk3288-miqi.dtsi
> >   create mode 100644 board/mqmaker/miqi_rk3288/Kconfig
> >   create mode 100644 board/mqmaker/miqi_rk3288/MAINTAINERS
> >   create mode 100644 board/mqmaker/miqi_rk3288/Makefile
> >   create mode 100644 board/mqmaker/miqi_rk3288/miqi-rk3288.c
> >   create mode 100644 configs/miqi-rk3288_defconfig
> >   create mode 100644 include/configs/miqi_rk3288.h
> > 
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> > index afeb43ff66..60a9aeb698 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
> > 
> > rk3288-fennec.dtb \
> > rk3288-tinker.dtb \
> > rk3288-popmetal.dtb \
> > 
> > +   rk3288-miqi.dtb \
> 
> Should be alphabet order, so before tinker and after fennec.
> 

But then also other rk3288 boards are not listed in any particular order. I 
will reorder them all alphabetically.

> > rk3328-evb.dtb \
> > rk3399-evb.dtb
> >   
> >   dtb-$(CONFIG_ARCH_MESON) += \
> > 
> > diff --git a/arch/arm/dts/rk3288-miqi.dts b/arch/arm/dts/rk3288-miqi.dts
> > new file mode 100644
> > index 00..7b92caf024
> > --- /dev/null
> > +++ b/arch/arm/dts/rk3288-miqi.dts
> > @@ -0,0 +1,46 @@
> > +/*
> > + * (C) Copyright 2016 Rockchip Electronics Co., Ltd
> > + *
> > + * SPDX-License-Identifier: GPL-2.0+ X11
> > + */
> > +
> > +/dts-v1/;
> > +#include "rk3288-miqi.dtsi"
> > +
> > +/ {
> > +   model = "mqmaker MiQi";
> > +   compatible = "mqmaker,miqi", "rockchip,rk3288";
> > +
> > +   chosen {
> > +   stdout-path = "serial2:115200n8";
> > +   };
> > +};
> > +
> > + {
> > +   rockchip,pctl-timing = <0x29a 0xc8 0x1f8 0x42 0x4e 0x4 0xea 0xa
> > +   0x5 0x0 0xa 0x7 0x19 0x24 0xa 0x7
> > +   0x5 0xa 0x5 0x200 0x5 0x10 0x40 0x0
> > +   0x1 0x7 0x7 0x4 0xc 0x43 0x100 0x0
> > +   0x5 0x0>;
> > +   rockchip,phy-timing = <0x48f9aab4 0xea0910 0x1002c200
> > +   0xa60 0x40 0x10 0x0>;
> > +   rockchip,sdram-params = <0x30B25564 0x627 3 66600 3 9 1>;
> > +};
> > +
> > +
> > + {
> > +   u-boot,dm-pre-reloc;
> > +};
> > +
> > + {
> > +   u-boot,dm-pre-reloc;
> > +   reg-shift = <2>;
> > +};
> > +
> > + {
> > +   u-boot,dm-pre-reloc;
> > +};
> > +
> > + {
> > +   u-boot,dm-pre-reloc;
> > +};
> > diff --git a/arch/arm/dts/rk3288-miqi.dtsi b/arch/arm/dts/rk3288-miqi.dtsi
> > new file mode 100644
> > index 00..12e584f242
> > --- /dev/null
> > +++ b/arch/arm/dts/rk3288-miqi.dtsi
> > @@ -0,0 +1,459 @@
> > +/*
> > + * Copyright (c) 2016 Heiko Stuebner 
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + *  a) This file is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of the
> > + * License, or (at your option) any later version.
> > + *
> > + * This file is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, to any person
> > + * obtaining a copy of this software and associated documentation
> > + * files (the "Software"), to deal in the Software without
> > + * restriction, including without limitation the rights to use,
> > + * copy, modify, merge, publish, distribute, sublicense, and/or
> > + * sell copies 

Re: [U-Boot] [PATCH] rockchip: Add support for MiQi rk3288 board

2017-03-23 Thread Kever Yang

Hi Jernej,

On 03/24/2017 08:11 AM, Jernej Skrabec wrote:

MiQi is rk3288 based development board with 1 or 2 GB SDRAM, 16 GB eMMC,
micro SD card interface, 4 USB 2.0 ports, HDMI, gigabit Ethernet and
expansion ports.

Signed-off-by: Jernej Skrabec 
---

  arch/arm/dts/Makefile   |   1 +
  arch/arm/dts/rk3288-miqi.dts|  46 
  arch/arm/dts/rk3288-miqi.dtsi   | 459 
  arch/arm/mach-rockchip/rk3288/Kconfig   |  11 +
  board/mqmaker/miqi_rk3288/Kconfig   |  15 ++
  board/mqmaker/miqi_rk3288/MAINTAINERS   |   6 +
  board/mqmaker/miqi_rk3288/Makefile  |   7 +
  board/mqmaker/miqi_rk3288/miqi-rk3288.c |  15 ++
  configs/miqi-rk3288_defconfig   |  73 +
  doc/README.rockchip |   5 +-
  include/configs/miqi_rk3288.h   |  22 ++
  11 files changed, 658 insertions(+), 2 deletions(-)
  create mode 100644 arch/arm/dts/rk3288-miqi.dts
  create mode 100644 arch/arm/dts/rk3288-miqi.dtsi
  create mode 100644 board/mqmaker/miqi_rk3288/Kconfig
  create mode 100644 board/mqmaker/miqi_rk3288/MAINTAINERS
  create mode 100644 board/mqmaker/miqi_rk3288/Makefile
  create mode 100644 board/mqmaker/miqi_rk3288/miqi-rk3288.c
  create mode 100644 configs/miqi-rk3288_defconfig
  create mode 100644 include/configs/miqi_rk3288.h

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index afeb43ff66..60a9aeb698 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
rk3288-fennec.dtb \
rk3288-tinker.dtb \
rk3288-popmetal.dtb \
+   rk3288-miqi.dtb \


Should be alphabet order, so before tinker and after fennec.

rk3328-evb.dtb \
rk3399-evb.dtb
  dtb-$(CONFIG_ARCH_MESON) += \
diff --git a/arch/arm/dts/rk3288-miqi.dts b/arch/arm/dts/rk3288-miqi.dts
new file mode 100644
index 00..7b92caf024
--- /dev/null
+++ b/arch/arm/dts/rk3288-miqi.dts
@@ -0,0 +1,46 @@
+/*
+ * (C) Copyright 2016 Rockchip Electronics Co., Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0+ X11
+ */
+
+/dts-v1/;
+#include "rk3288-miqi.dtsi"
+
+/ {
+   model = "mqmaker MiQi";
+   compatible = "mqmaker,miqi", "rockchip,rk3288";
+
+   chosen {
+   stdout-path = "serial2:115200n8";
+   };
+};
+
+ {
+   rockchip,pctl-timing = <0x29a 0xc8 0x1f8 0x42 0x4e 0x4 0xea 0xa
+   0x5 0x0 0xa 0x7 0x19 0x24 0xa 0x7
+   0x5 0xa 0x5 0x200 0x5 0x10 0x40 0x0
+   0x1 0x7 0x7 0x4 0xc 0x43 0x100 0x0
+   0x5 0x0>;
+   rockchip,phy-timing = <0x48f9aab4 0xea0910 0x1002c200
+   0xa60 0x40 0x10 0x0>;
+   rockchip,sdram-params = <0x30B25564 0x627 3 66600 3 9 1>;
+};
+
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+   reg-shift = <2>;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
diff --git a/arch/arm/dts/rk3288-miqi.dtsi b/arch/arm/dts/rk3288-miqi.dtsi
new file mode 100644
index 00..12e584f242
--- /dev/null
+++ b/arch/arm/dts/rk3288-miqi.dtsi
@@ -0,0 +1,459 @@
+/*
+ * Copyright (c) 2016 Heiko Stuebner 
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ 

[U-Boot] [PATCH] rockchip: Add support for MiQi rk3288 board

2017-03-23 Thread Jernej Skrabec
MiQi is rk3288 based development board with 1 or 2 GB SDRAM, 16 GB eMMC,
micro SD card interface, 4 USB 2.0 ports, HDMI, gigabit Ethernet and
expansion ports.

Signed-off-by: Jernej Skrabec 
---

 arch/arm/dts/Makefile   |   1 +
 arch/arm/dts/rk3288-miqi.dts|  46 
 arch/arm/dts/rk3288-miqi.dtsi   | 459 
 arch/arm/mach-rockchip/rk3288/Kconfig   |  11 +
 board/mqmaker/miqi_rk3288/Kconfig   |  15 ++
 board/mqmaker/miqi_rk3288/MAINTAINERS   |   6 +
 board/mqmaker/miqi_rk3288/Makefile  |   7 +
 board/mqmaker/miqi_rk3288/miqi-rk3288.c |  15 ++
 configs/miqi-rk3288_defconfig   |  73 +
 doc/README.rockchip |   5 +-
 include/configs/miqi_rk3288.h   |  22 ++
 11 files changed, 658 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/dts/rk3288-miqi.dts
 create mode 100644 arch/arm/dts/rk3288-miqi.dtsi
 create mode 100644 board/mqmaker/miqi_rk3288/Kconfig
 create mode 100644 board/mqmaker/miqi_rk3288/MAINTAINERS
 create mode 100644 board/mqmaker/miqi_rk3288/Makefile
 create mode 100644 board/mqmaker/miqi_rk3288/miqi-rk3288.c
 create mode 100644 configs/miqi-rk3288_defconfig
 create mode 100644 include/configs/miqi_rk3288.h

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index afeb43ff66..60a9aeb698 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
rk3288-fennec.dtb \
rk3288-tinker.dtb \
rk3288-popmetal.dtb \
+   rk3288-miqi.dtb \
rk3328-evb.dtb \
rk3399-evb.dtb
 dtb-$(CONFIG_ARCH_MESON) += \
diff --git a/arch/arm/dts/rk3288-miqi.dts b/arch/arm/dts/rk3288-miqi.dts
new file mode 100644
index 00..7b92caf024
--- /dev/null
+++ b/arch/arm/dts/rk3288-miqi.dts
@@ -0,0 +1,46 @@
+/*
+ * (C) Copyright 2016 Rockchip Electronics Co., Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0+ X11
+ */
+
+/dts-v1/;
+#include "rk3288-miqi.dtsi"
+
+/ {
+   model = "mqmaker MiQi";
+   compatible = "mqmaker,miqi", "rockchip,rk3288";
+
+   chosen {
+   stdout-path = "serial2:115200n8";
+   };
+};
+
+ {
+   rockchip,pctl-timing = <0x29a 0xc8 0x1f8 0x42 0x4e 0x4 0xea 0xa
+   0x5 0x0 0xa 0x7 0x19 0x24 0xa 0x7
+   0x5 0xa 0x5 0x200 0x5 0x10 0x40 0x0
+   0x1 0x7 0x7 0x4 0xc 0x43 0x100 0x0
+   0x5 0x0>;
+   rockchip,phy-timing = <0x48f9aab4 0xea0910 0x1002c200
+   0xa60 0x40 0x10 0x0>;
+   rockchip,sdram-params = <0x30B25564 0x627 3 66600 3 9 1>;
+};
+
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+   reg-shift = <2>;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
+
+ {
+   u-boot,dm-pre-reloc;
+};
diff --git a/arch/arm/dts/rk3288-miqi.dtsi b/arch/arm/dts/rk3288-miqi.dtsi
new file mode 100644
index 00..12e584f242
--- /dev/null
+++ b/arch/arm/dts/rk3288-miqi.dtsi
@@ -0,0 +1,459 @@
+/*
+ * Copyright (c) 2016 Heiko Stuebner 
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of the
+ * License, or (at your option) any later version.
+ *
+ * This file is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ * obtaining a copy of this software and associated documentation
+ * files (the "Software"), to deal in the Software without
+ * restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following
+ * conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *