Re: [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device"

[Michal Simek]

On 01/27/2015 05:02 PM, Tom Rini wrote:
> On Tue, Jan 27, 2015 at 04:45:09PM +0100, Stefan Roese wrote:
> 
>> Microblaze currently doesn't use printf in SPL. So this one line was the only
>> reference to it and resulted in the printf functionality to be pulled in.
>> Exceeding the 4k size limit. Lets change the printf back to puts so that
>> Microblaze is fixed again. The only drawback is that the detected boot-device
>> number will not be printed. But this message alone should be helpful enough
>> to get an idea where the boot process is broken.
>>
>> Signed-off-by: Stefan Roese 
>> Cc: Tom Rini 
>> Cc: Michal Simek 
> 
> Since we have a debug() higher up that will print out what the value is,
> I'm OK with this and I'll apply shortly, thanks!
> 

Works for me.
Acked-by: Michal Simek 

Thanks,
Michal



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device"

[Tom Rini]

On Tue, Jan 27, 2015 at 04:45:09PM +0100, Stefan Roese wrote:

> Microblaze currently doesn't use printf in SPL. So this one line was the only
> reference to it and resulted in the printf functionality to be pulled in.
> Exceeding the 4k size limit. Lets change the printf back to puts so that
> Microblaze is fixed again. The only drawback is that the detected boot-device
> number will not be printed. But this message alone should be helpful enough
> to get an idea where the boot process is broken.
> 
> Signed-off-by: Stefan Roese 
> Cc: Tom Rini 
> Cc: Michal Simek 

Since we have a debug() higher up that will print out what the value is,
I'm OK with this and I'll apply shortly, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device"

[Stefan Roese]

Microblaze currently doesn't use printf in SPL. So this one line was the only
reference to it and resulted in the printf functionality to be pulled in.
Exceeding the 4k size limit. Lets change the printf back to puts so that
Microblaze is fixed again. The only drawback is that the detected boot-device
number will not be printed. But this message alone should be helpful enough
to get an idea where the boot process is broken.

Signed-off-by: Stefan Roese 
Cc: Tom Rini 
Cc: Michal Simek 
---
 common/spl/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index 1826c47..daaeb50 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -231,7 +231,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 #endif
default:
 #if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
-   printf("SPL: Unsupported Boot Device %d\n", boot_device);
+   puts("SPL: Unsupported Boot Device!\n");
 #endif
hang();
}
-- 
2.2.2

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot