subject:"\[U\-Boot\] \[PATCH\] sunxi\: add MACPWR in Orange Pi PC2 defconfig"

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

2017-08-11 Thread Jagan Teki

On Fri, Aug 11, 2017 at 3:30 PM, Jagan Teki  wrote:
> On Tue, Jul 4, 2017 at 4:13 PM, Icenowy Zheng  wrote:
>> The Ethernet function is enabled in the Orange Pi PC2 device tree and
>> defconfig, however, CONFIG_MACPWR is not properly set, which left the
>> PHY being disabled when booting, which makes the Ethernet function not
>> usable.
>>
>> Add the proper value of this option in the PC2 defconfig.
>>
>> Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
>> Signed-off-by: Icenowy Zheng 
>
> Reviewed-by: Jagan Teki 

Applied to u-boot-sunxi/master

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

2017-08-11 Thread Jagan Teki

On Tue, Jul 4, 2017 at 4:13 PM, Icenowy Zheng  wrote:
> The Ethernet function is enabled in the Orange Pi PC2 device tree and
> defconfig, however, CONFIG_MACPWR is not properly set, which left the
> PHY being disabled when booting, which makes the Ethernet function not
> usable.
>
> Add the proper value of this option in the PC2 defconfig.
>
> Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
> Signed-off-by: Icenowy Zheng 

Reviewed-by: Jagan Teki 

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

2017-07-04 Thread Andre Przywara

Hi,

On 04/07/17 11:48, Icenowy Zheng wrote:

> 于 2017年7月4日 GMT+08:00 下午6:47:17, Andre Przywara  写到:
>> Hi,
>>
>> On 04/07/17 11:43, Icenowy Zheng wrote:
>>> The Ethernet function is enabled in the Orange Pi PC2 device tree and
>>> defconfig, however, CONFIG_MACPWR is not properly set, which left the
>>> PHY being disabled when booting, which makes the Ethernet function
>> not
>>> usable.
>>
>> Indeed, so I can remove this very same patch from my queue here ;-)
>>
>>> Add the proper value of this option in the PC2 defconfig.
>>>
>>> Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
>>
>> I believe the support for CONFIG_MACPWR wasn't there when I wrote this
>> patch, so I hacked this into my ATF port at the time ;-)
> 
> It used to be in CONFIG_EXTRA_OPTIONS, see the history of
> H3 GbE OPis' defconfig.

I know, but I didn't want to let this legacy hack creep into a new board.

Cheers,
Andre.

>>> Signed-off-by: Icenowy Zheng 
>>
>> Acked-by: Andre Przywara 
>>
>> Thanks,
>> Andre.
>>
>>> ---
>>>  configs/orangepi_pc2_defconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/configs/orangepi_pc2_defconfig
>> b/configs/orangepi_pc2_defconfig
>>> index 5a64ad3f41..b72514d3b9 100644
>>> --- a/configs/orangepi_pc2_defconfig
>>> +++ b/configs/orangepi_pc2_defconfig
>>> @@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
>>>  CONFIG_MACH_SUN50I_H5=y
>>>  CONFIG_DRAM_CLK=672
>>>  CONFIG_DRAM_ZQ=3881977
>>> +CONFIG_MACPWR="PD6"
>>>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
>>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>>>  CONFIG_SPL=y
>>>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

2017-07-04 Thread Icenowy Zheng



于 2017年7月4日 GMT+08:00 下午6:47:17, Andre Przywara  写到:
>Hi,
>
>On 04/07/17 11:43, Icenowy Zheng wrote:
>> The Ethernet function is enabled in the Orange Pi PC2 device tree and
>> defconfig, however, CONFIG_MACPWR is not properly set, which left the
>> PHY being disabled when booting, which makes the Ethernet function
>not
>> usable.
>
>Indeed, so I can remove this very same patch from my queue here ;-)
>
>> Add the proper value of this option in the PC2 defconfig.
>> 
>> Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
>
>I believe the support for CONFIG_MACPWR wasn't there when I wrote this
>patch, so I hacked this into my ATF port at the time ;-)

It used to be in CONFIG_EXTRA_OPTIONS, see the history of
H3 GbE OPis' defconfig.

>
>> Signed-off-by: Icenowy Zheng 
>
>Acked-by: Andre Przywara 
>
>Thanks,
>Andre.
>
>> ---
>>  configs/orangepi_pc2_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/configs/orangepi_pc2_defconfig
>b/configs/orangepi_pc2_defconfig
>> index 5a64ad3f41..b72514d3b9 100644
>> --- a/configs/orangepi_pc2_defconfig
>> +++ b/configs/orangepi_pc2_defconfig
>> @@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
>>  CONFIG_MACH_SUN50I_H5=y
>>  CONFIG_DRAM_CLK=672
>>  CONFIG_DRAM_ZQ=3881977
>> +CONFIG_MACPWR="PD6"
>>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>>  CONFIG_SPL=y
>> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

2017-07-04 Thread Andre Przywara

Hi,

On 04/07/17 11:43, Icenowy Zheng wrote:
> The Ethernet function is enabled in the Orange Pi PC2 device tree and
> defconfig, however, CONFIG_MACPWR is not properly set, which left the
> PHY being disabled when booting, which makes the Ethernet function not
> usable.

Indeed, so I can remove this very same patch from my queue here ;-)

> Add the proper value of this option in the PC2 defconfig.
> 
> Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")

I believe the support for CONFIG_MACPWR wasn't there when I wrote this
patch, so I hacked this into my ATF port at the time ;-)

> Signed-off-by: Icenowy Zheng 

Acked-by: Andre Przywara 

Thanks,
Andre.

> ---
>  configs/orangepi_pc2_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
> index 5a64ad3f41..b72514d3b9 100644
> --- a/configs/orangepi_pc2_defconfig
> +++ b/configs/orangepi_pc2_defconfig
> @@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
>  CONFIG_MACH_SUN50I_H5=y
>  CONFIG_DRAM_CLK=672
>  CONFIG_DRAM_ZQ=3881977
> +CONFIG_MACPWR="PD6"
>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_SPL=y
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

2017-07-04 Thread Icenowy Zheng

The Ethernet function is enabled in the Orange Pi PC2 device tree and
defconfig, however, CONFIG_MACPWR is not properly set, which left the
PHY being disabled when booting, which makes the Ethernet function not
usable.

Add the proper value of this option in the PC2 defconfig.

Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support")
Signed-off-by: Icenowy Zheng 
---
 configs/orangepi_pc2_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig
index 5a64ad3f41..b72514d3b9 100644
--- a/configs/orangepi_pc2_defconfig
+++ b/configs/orangepi_pc2_defconfig
@@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_MACH_SUN50I_H5=y
 CONFIG_DRAM_CLK=672
 CONFIG_DRAM_ZQ=3881977
+CONFIG_MACPWR="PD6"
 CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL=y
-- 
2.13.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

Re: [U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

[U-Boot] [PATCH] sunxi: add MACPWR in Orange Pi PC2 defconfig

6 matches

Site Navigation

Mail list logo

Footer information