Re: [U-Boot] [PATCH] usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

2019-09-10 Thread Bin Meng 
Hi Neil,

On Tue, Sep 10, 2019 at 3:58 PM Neil Armstrong  wrote:
>
> Hi Bin, Marek,
>
> On 10/09/2019 03:56, Bin Meng wrote:
> > On Tue, Sep 10, 2019 at 2:52 AM Neil Armstrong  
> > wrote:
> >>
> >> This quirk is necessary for the Amlogic GXL SoCs otherwise the
> >> Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:
> >>
> >> XHCI timeout on event type 33... cannot recover.
> >> BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!
> >> BUG!
> >>
> >> This quirk is also handled in the dwc3 core code, but until the
> >> xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here
> >> to fix USB support on the Amlogic libretech-cc and libretech-ac board
> >> when a device is only plugged in the OTG port.
> >>
> >> Cc: Yuri Frolov 
> >> Cc: Bin Meng 
> >> Fixes: dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
> >> Signed-off-by: Neil Armstrong 
> >> ---
> >>  drivers/usb/host/xhci-dwc3.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >
> > Thanks for your efforts tracing this down!
> >
> > Reviewed-by: Bin Meng 
> >
>
> Should I take it into my amlogic tree or you'll handle it ?
>

I think you can take it via your tree. Thanks!

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

2019-09-10 Thread Neil Armstrong 
Hi Bin, Marek,

On 10/09/2019 03:56, Bin Meng wrote:
> On Tue, Sep 10, 2019 at 2:52 AM Neil Armstrong  
> wrote:
>>
>> This quirk is necessary for the Amlogic GXL SoCs otherwise the
>> Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:
>>
>> XHCI timeout on event type 33... cannot recover.
>> BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!
>> BUG!
>>
>> This quirk is also handled in the dwc3 core code, but until the
>> xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here
>> to fix USB support on the Amlogic libretech-cc and libretech-ac board
>> when a device is only plugged in the OTG port.
>>
>> Cc: Yuri Frolov 
>> Cc: Bin Meng 
>> Fixes: dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
>> Signed-off-by: Neil Armstrong 
>> ---
>>  drivers/usb/host/xhci-dwc3.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
> 
> Thanks for your efforts tracing this down!
> 
> Reviewed-by: Bin Meng 
> 

Should I take it into my amlogic tree or you'll handle it ?

Thanks,
Neil
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

2019-09-09 Thread Bin Meng 
On Tue, Sep 10, 2019 at 2:52 AM Neil Armstrong  wrote:
>
> This quirk is necessary for the Amlogic GXL SoCs otherwise the
> Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:
>
> XHCI timeout on event type 33... cannot recover.
> BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!
> BUG!
>
> This quirk is also handled in the dwc3 core code, but until the
> xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here
> to fix USB support on the Amlogic libretech-cc and libretech-ac board
> when a device is only plugged in the OTG port.
>
> Cc: Yuri Frolov 
> Cc: Bin Meng 
> Fixes: dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
> Signed-off-by: Neil Armstrong 
> ---
>  drivers/usb/host/xhci-dwc3.c | 3 +++
>  1 file changed, 3 insertions(+)
>

Thanks for your efforts tracing this down!

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] usb: xhci-dwc3: Add support for dis_u2_susphy_quirk

2019-09-09 Thread Neil Armstrong 
This quirk is necessary for the Amlogic GXL SoCs otherwise the
Port 2 PHY doesn't get out of suspend and U-Boot resets the board after:

XHCI timeout on event type 33... cannot recover.
BUG: failure at drivers/usb/host/xhci-ring.c:474/xhci_wait_for_event()!
BUG!

This quirk is also handled in the dwc3 core code, but until the
xhci-dwc3 driver uses the dwc3 core, the quirk must be handled here
to fix USB support on the Amlogic libretech-cc and libretech-ac board
when a device is only plugged in the OTG port.

Cc: Yuri Frolov 
Cc: Bin Meng 
Fixes: dc9cdf859e ("usb: dwc3: Add DWC3 controller driver support")
Signed-off-by: Neil Armstrong 
---
 drivers/usb/host/xhci-dwc3.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c
index 9e8cae7ae4..55a1b22cf6 100644
--- a/drivers/usb/host/xhci-dwc3.c
+++ b/drivers/usb/host/xhci-dwc3.c
@@ -150,6 +150,9 @@ static int xhci_dwc3_probe(struct udevice *dev)
if (dev_read_bool(dev, "snps,dis-u2-freeclk-exists-quirk"))
reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS;
 
+   if (dev_read_bool(dev, "snps,dis_u2_susphy_quirk"))
+   reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
+
writel(reg, &dwc3_reg->g_usb2phycfg[0]);
 
dr_mode = usb_get_dr_mode(dev_of_offset(dev));
-- 
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot