Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-11-25 Thread Simon Glass
Hi,

On 16 November 2016 at 06:43, Fabian Vogt  wrote:
> Hi,
>
> any news on this? As far as I can tell nothing happened after my last
> reply to this thread, so: Ping!

Adding Tom - the patches are assigned to him in Patchwork.

- Simon

>
> Thanks,
> Fabian
>
> Am Montag, 26. September 2016, 14:26:42 CET schrieben Sie:
>> This patch series modifies the used drivers to work with OF_CONTROL
>> and switches the board code and configs to use it.
>> The added device trees are directly from the linux kernel tree
>> and can thus be used for booting the (upstream) kernel.
>>
>> Fabian Vogt (9):
>>   gpio: bcm2835: add device tree support
>>   serial: bcm283x_mu: add device tree support
>>   serial: pl01x: expose skip_init platdata option in DT
>>   fdt: add dt-bindings for bcm2835
>>   fdt: import bcm283x device tree sources from the linux kernel tree
>>   fdt: adjust bcm283x device tree for u-boot
>>   serial: bcm283x_mu: support disabling after initialization
>>   board: rpi: move uart deactivation to board_init
>>   ARM: bcm283x: use OF_CONTROL for bcm283x
>>
>>  arch/arm/Kconfig   |   1 +
>>  arch/arm/dts/Makefile  |   9 +
>>  arch/arm/dts/bcm2835-rpi-a-plus.dts|  35 +++
>>  arch/arm/dts/bcm2835-rpi-a.dts |  28 ++
>>  arch/arm/dts/bcm2835-rpi-b-plus.dts|  36 +++
>>  arch/arm/dts/bcm2835-rpi-b-rev2.dts|  29 ++
>>  arch/arm/dts/bcm2835-rpi-b.dts |  23 ++
>>  arch/arm/dts/bcm2835-rpi.dtsi  |  86 ++
>>  arch/arm/dts/bcm2835.dtsi  |  25 ++
>>  arch/arm/dts/bcm2836-rpi-2-b.dts   |  40 +++
>>  arch/arm/dts/bcm2836.dtsi  |  78 +
>>  arch/arm/dts/bcm2837-rpi-3-b.dts   |  30 ++
>>  arch/arm/dts/bcm2837.dtsi  |  76 +
>>  arch/arm/dts/bcm283x-rpi-smsc9512.dtsi |  19 ++
>>  arch/arm/dts/bcm283x-rpi-smsc9514.dtsi |  19 ++
>>  arch/arm/dts/bcm283x-uboot.dtsi|  22 ++
>>  arch/arm/dts/bcm283x.dtsi  | 323 
>> +
>>  board/raspberrypi/rpi/rpi.c|  77 ++---
>>  configs/rpi_2_defconfig|   2 +
>>  configs/rpi_3_32b_defconfig|   2 +
>>  configs/rpi_3_defconfig|   2 +
>>  configs/rpi_defconfig  |   2 +
>>  doc/device-tree-bindings/gpio/bcm2835-gpio.txt |   5 +
>>  .../serial/bcm2835-aux-uart.txt|  10 +
>>  doc/device-tree-bindings/serial/pl01x.txt  |   3 +
>>  drivers/gpio/bcm2835_gpio.c|  24 ++
>>  drivers/serial/serial_bcm283x_mu.c |  46 ++-
>>  drivers/serial/serial_pl01x.c  |   2 +
>>  include/configs/rpi.h  |   1 -
>>  include/dt-bindings/clock/bcm2835-aux.h|  17 ++
>>  include/dt-bindings/clock/bcm2835.h|  66 +
>>  include/dt-bindings/pinctrl/bcm2835.h  |  27 ++
>>  include/dt-bindings/power/raspberrypi-power.h  |  41 +++
>>  33 files changed, 1152 insertions(+), 54 deletions(-)
>>  create mode 100644 arch/arm/dts/bcm2835-rpi-a-plus.dts
>>  create mode 100644 arch/arm/dts/bcm2835-rpi-a.dts
>>  create mode 100644 arch/arm/dts/bcm2835-rpi-b-plus.dts
>>  create mode 100644 arch/arm/dts/bcm2835-rpi-b-rev2.dts
>>  create mode 100644 arch/arm/dts/bcm2835-rpi-b.dts
>>  create mode 100644 arch/arm/dts/bcm2835-rpi.dtsi
>>  create mode 100644 arch/arm/dts/bcm2835.dtsi
>>  create mode 100644 arch/arm/dts/bcm2836-rpi-2-b.dts
>>  create mode 100644 arch/arm/dts/bcm2836.dtsi
>>  create mode 100644 arch/arm/dts/bcm2837-rpi-3-b.dts
>>  create mode 100644 arch/arm/dts/bcm2837.dtsi
>>  create mode 100644 arch/arm/dts/bcm283x-rpi-smsc9512.dtsi
>>  create mode 100644 arch/arm/dts/bcm283x-rpi-smsc9514.dtsi
>>  create mode 100644 arch/arm/dts/bcm283x-uboot.dtsi
>>  create mode 100644 arch/arm/dts/bcm283x.dtsi
>>  create mode 100644 doc/device-tree-bindings/gpio/bcm2835-gpio.txt
>>  create mode 100644 doc/device-tree-bindings/serial/bcm2835-aux-uart.txt
>>  create mode 100644 include/dt-bindings/clock/bcm2835-aux.h
>>  create mode 100644 include/dt-bindings/clock/bcm2835.h
>>  create mode 100644 include/dt-bindings/pinctrl/bcm2835.h
>>  create mode 100644 include/dt-bindings/power/raspberrypi-power.h
>>
>>
>
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-11-16 Thread Fabian Vogt
Hi,

any news on this? As far as I can tell nothing happened after my last
reply to this thread, so: Ping!

Thanks,
Fabian

Am Montag, 26. September 2016, 14:26:42 CET schrieben Sie:
> This patch series modifies the used drivers to work with OF_CONTROL
> and switches the board code and configs to use it.
> The added device trees are directly from the linux kernel tree
> and can thus be used for booting the (upstream) kernel.
> 
> Fabian Vogt (9):
>   gpio: bcm2835: add device tree support
>   serial: bcm283x_mu: add device tree support
>   serial: pl01x: expose skip_init platdata option in DT
>   fdt: add dt-bindings for bcm2835
>   fdt: import bcm283x device tree sources from the linux kernel tree
>   fdt: adjust bcm283x device tree for u-boot
>   serial: bcm283x_mu: support disabling after initialization
>   board: rpi: move uart deactivation to board_init
>   ARM: bcm283x: use OF_CONTROL for bcm283x
> 
>  arch/arm/Kconfig   |   1 +
>  arch/arm/dts/Makefile  |   9 +
>  arch/arm/dts/bcm2835-rpi-a-plus.dts|  35 +++
>  arch/arm/dts/bcm2835-rpi-a.dts |  28 ++
>  arch/arm/dts/bcm2835-rpi-b-plus.dts|  36 +++
>  arch/arm/dts/bcm2835-rpi-b-rev2.dts|  29 ++
>  arch/arm/dts/bcm2835-rpi-b.dts |  23 ++
>  arch/arm/dts/bcm2835-rpi.dtsi  |  86 ++
>  arch/arm/dts/bcm2835.dtsi  |  25 ++
>  arch/arm/dts/bcm2836-rpi-2-b.dts   |  40 +++
>  arch/arm/dts/bcm2836.dtsi  |  78 +
>  arch/arm/dts/bcm2837-rpi-3-b.dts   |  30 ++
>  arch/arm/dts/bcm2837.dtsi  |  76 +
>  arch/arm/dts/bcm283x-rpi-smsc9512.dtsi |  19 ++
>  arch/arm/dts/bcm283x-rpi-smsc9514.dtsi |  19 ++
>  arch/arm/dts/bcm283x-uboot.dtsi|  22 ++
>  arch/arm/dts/bcm283x.dtsi  | 323 
> +
>  board/raspberrypi/rpi/rpi.c|  77 ++---
>  configs/rpi_2_defconfig|   2 +
>  configs/rpi_3_32b_defconfig|   2 +
>  configs/rpi_3_defconfig|   2 +
>  configs/rpi_defconfig  |   2 +
>  doc/device-tree-bindings/gpio/bcm2835-gpio.txt |   5 +
>  .../serial/bcm2835-aux-uart.txt|  10 +
>  doc/device-tree-bindings/serial/pl01x.txt  |   3 +
>  drivers/gpio/bcm2835_gpio.c|  24 ++
>  drivers/serial/serial_bcm283x_mu.c |  46 ++-
>  drivers/serial/serial_pl01x.c  |   2 +
>  include/configs/rpi.h  |   1 -
>  include/dt-bindings/clock/bcm2835-aux.h|  17 ++
>  include/dt-bindings/clock/bcm2835.h|  66 +
>  include/dt-bindings/pinctrl/bcm2835.h  |  27 ++
>  include/dt-bindings/power/raspberrypi-power.h  |  41 +++
>  33 files changed, 1152 insertions(+), 54 deletions(-)
>  create mode 100644 arch/arm/dts/bcm2835-rpi-a-plus.dts
>  create mode 100644 arch/arm/dts/bcm2835-rpi-a.dts
>  create mode 100644 arch/arm/dts/bcm2835-rpi-b-plus.dts
>  create mode 100644 arch/arm/dts/bcm2835-rpi-b-rev2.dts
>  create mode 100644 arch/arm/dts/bcm2835-rpi-b.dts
>  create mode 100644 arch/arm/dts/bcm2835-rpi.dtsi
>  create mode 100644 arch/arm/dts/bcm2835.dtsi
>  create mode 100644 arch/arm/dts/bcm2836-rpi-2-b.dts
>  create mode 100644 arch/arm/dts/bcm2836.dtsi
>  create mode 100644 arch/arm/dts/bcm2837-rpi-3-b.dts
>  create mode 100644 arch/arm/dts/bcm2837.dtsi
>  create mode 100644 arch/arm/dts/bcm283x-rpi-smsc9512.dtsi
>  create mode 100644 arch/arm/dts/bcm283x-rpi-smsc9514.dtsi
>  create mode 100644 arch/arm/dts/bcm283x-uboot.dtsi
>  create mode 100644 arch/arm/dts/bcm283x.dtsi
>  create mode 100644 doc/device-tree-bindings/gpio/bcm2835-gpio.txt
>  create mode 100644 doc/device-tree-bindings/serial/bcm2835-aux-uart.txt
>  create mode 100644 include/dt-bindings/clock/bcm2835-aux.h
>  create mode 100644 include/dt-bindings/clock/bcm2835.h
>  create mode 100644 include/dt-bindings/pinctrl/bcm2835.h
>  create mode 100644 include/dt-bindings/power/raspberrypi-power.h
> 
> 


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-07 Thread Stefan Bruens
On Freitag, 7. Oktober 2016 16:42:40 CEST Tom Rini wrote:
> On Thu, Oct 06, 2016 at 09:42:52PM -0700, Eric Anholt wrote:
> > Stefan Bruens  writes:
> > > On Donnerstag, 6. Oktober 2016 12:32:12 CEST Eric Anholt wrote:
> > >> Alexander Graf  writes:
> > >> >> Am 05.10.2016 um 18:48 schrieb Fabian Vogt :
> > >> >> 
> > >> >> Hi,
> > >> >> 
> > >> >> Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
> > >> >>> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
> > >>  This patch series modifies the used drivers to work with
> > >>  OF_CONTROL
> > >>  and switches the board code and configs to use it.
> > >>  The added device trees are directly from the linux kernel tree
> > >>  and can thus be used for booting the (upstream) kernel.
> > >> >>> 
> > >> >>> Is there a user-visible or developer-visible benefit to this
> > >> >>> change? In
> > >> >>> general, converting to use DT to instantiate devices simply ends up
> > >> >>> using more code (and hence complexity and time) to get to the exact
> > >> >>> same
> > >> >>> state afterwards.
> > >> >> 
> > >> >> There are various reasons, like:
> > >> >> 
> > >> >> - The device tree describes the platform, so it can also be used by
> > >> >> the
> > >> >> 
> > >> >>  linux kernel for configuration (no separate dtb needed)
> > >> > 
> > >> > With a bit of lobbying, we might even be able to get a working dt
> > >> > from
> > >> > the rpi firmware. That again would enable awesome things like hat
> > >> > support in u-boot :).
> > >> 
> > >> I can't imagine the firmware handing any DT off to the kernel other
> > >> than
> > >> the one that's being shipped from whatever kernel is being loaded.
> > >> Being able to update the DT in lockstep with the kernel is very much
> > >> part of their process.  (This makes linux insisting that DT is ABI that
> > >> must maintain backwards compat quite painful for upstreaming)
> > >> 
> > >> Given that the firmware already hands the kernel's DT back to the
> > >> kernel, it seems like we should be able to load the kernel's DT too if
> > >> we wanted that.
> > > 
> > > You mean the DT modified by the firmware according to config.txt, at
> > > least
> > > applying the specified DT overlays?
> > 
> > Yeah, that.
> 
> That would also be a good thing, yes.

My primary concern here was the bcm2708-rpi-b.dtb vs bcm2835-rpi-b.dtb 
devicetrees, i.e. the one distributed by the RPi foundation vs the upstream 
kernel one.

This concern may no longer be valid, https://www.raspberrypi.org/
documentation/configuration/device-tree.md#part3 says:
---
The loader now supports builds using bcm2835_defconfig, which selects the 
upstreamed BCM2835 support. This configuration will cause bcm2835-rpi-b.dtb 
and bcm2835-rpi-b-plus.dtb to be built. If these files are copied with the 
kernel, and if the kernel has been tagged by a recent mkknlimg, then the 
loader will attempt to load one of those DTBs by default.
---

Open points:
1. is u-boot.bin tagged in an appropriate way (i.e. as done by mkknlimg)?
2. what about the other RPis, i.e. RPi2, RPI3, RPi1-CM?

Kind regards,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034 mobile: +49 151 50412019
work: +49 2405 49936-424
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-07 Thread Tom Rini
On Thu, Oct 06, 2016 at 09:42:52PM -0700, Eric Anholt wrote:
> Stefan Bruens  writes:
> 
> > On Donnerstag, 6. Oktober 2016 12:32:12 CEST Eric Anholt wrote:
> >> Alexander Graf  writes:
> >> >> Am 05.10.2016 um 18:48 schrieb Fabian Vogt :
> >> >> 
> >> >> Hi,
> >> >> 
> >> >> Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
> >> >>> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
> >>  This patch series modifies the used drivers to work with OF_CONTROL
> >>  and switches the board code and configs to use it.
> >>  The added device trees are directly from the linux kernel tree
> >>  and can thus be used for booting the (upstream) kernel.
> >> >>> 
> >> >>> Is there a user-visible or developer-visible benefit to this change? In
> >> >>> general, converting to use DT to instantiate devices simply ends up
> >> >>> using more code (and hence complexity and time) to get to the exact 
> >> >>> same
> >> >>> state afterwards.
> >> >> 
> >> >> There are various reasons, like:
> >> >> 
> >> >> - The device tree describes the platform, so it can also be used by the
> >> >> 
> >> >>  linux kernel for configuration (no separate dtb needed)
> >> > 
> >> > With a bit of lobbying, we might even be able to get a working dt from
> >> > the rpi firmware. That again would enable awesome things like hat
> >> > support in u-boot :).
> >> 
> >> I can't imagine the firmware handing any DT off to the kernel other than
> >> the one that's being shipped from whatever kernel is being loaded.
> >> Being able to update the DT in lockstep with the kernel is very much
> >> part of their process.  (This makes linux insisting that DT is ABI that
> >> must maintain backwards compat quite painful for upstreaming)
> >> 
> >> Given that the firmware already hands the kernel's DT back to the
> >> kernel, it seems like we should be able to load the kernel's DT too if
> >> we wanted that.
> >
> > You mean the DT modified by the firmware according to config.txt, at least 
> > applying the specified DT overlays?
> 
> Yeah, that.

That would also be a good thing, yes.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-06 Thread Eric Anholt
Stefan Bruens  writes:

> On Donnerstag, 6. Oktober 2016 12:32:12 CEST Eric Anholt wrote:
>> Alexander Graf  writes:
>> >> Am 05.10.2016 um 18:48 schrieb Fabian Vogt :
>> >> 
>> >> Hi,
>> >> 
>> >> Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
>> >>> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
>>  This patch series modifies the used drivers to work with OF_CONTROL
>>  and switches the board code and configs to use it.
>>  The added device trees are directly from the linux kernel tree
>>  and can thus be used for booting the (upstream) kernel.
>> >>> 
>> >>> Is there a user-visible or developer-visible benefit to this change? In
>> >>> general, converting to use DT to instantiate devices simply ends up
>> >>> using more code (and hence complexity and time) to get to the exact same
>> >>> state afterwards.
>> >> 
>> >> There are various reasons, like:
>> >> 
>> >> - The device tree describes the platform, so it can also be used by the
>> >> 
>> >>  linux kernel for configuration (no separate dtb needed)
>> > 
>> > With a bit of lobbying, we might even be able to get a working dt from
>> > the rpi firmware. That again would enable awesome things like hat
>> > support in u-boot :).
>> 
>> I can't imagine the firmware handing any DT off to the kernel other than
>> the one that's being shipped from whatever kernel is being loaded.
>> Being able to update the DT in lockstep with the kernel is very much
>> part of their process.  (This makes linux insisting that DT is ABI that
>> must maintain backwards compat quite painful for upstreaming)
>> 
>> Given that the firmware already hands the kernel's DT back to the
>> kernel, it seems like we should be able to load the kernel's DT too if
>> we wanted that.
>
> You mean the DT modified by the firmware according to config.txt, at least 
> applying the specified DT overlays?

Yeah, that.


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-06 Thread Stefan Bruens
On Donnerstag, 6. Oktober 2016 12:32:12 CEST Eric Anholt wrote:
> Alexander Graf  writes:
> >> Am 05.10.2016 um 18:48 schrieb Fabian Vogt :
> >> 
> >> Hi,
> >> 
> >> Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
> >>> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
>  This patch series modifies the used drivers to work with OF_CONTROL
>  and switches the board code and configs to use it.
>  The added device trees are directly from the linux kernel tree
>  and can thus be used for booting the (upstream) kernel.
> >>> 
> >>> Is there a user-visible or developer-visible benefit to this change? In
> >>> general, converting to use DT to instantiate devices simply ends up
> >>> using more code (and hence complexity and time) to get to the exact same
> >>> state afterwards.
> >> 
> >> There are various reasons, like:
> >> 
> >> - The device tree describes the platform, so it can also be used by the
> >> 
> >>  linux kernel for configuration (no separate dtb needed)
> > 
> > With a bit of lobbying, we might even be able to get a working dt from
> > the rpi firmware. That again would enable awesome things like hat
> > support in u-boot :).
> 
> I can't imagine the firmware handing any DT off to the kernel other than
> the one that's being shipped from whatever kernel is being loaded.
> Being able to update the DT in lockstep with the kernel is very much
> part of their process.  (This makes linux insisting that DT is ABI that
> must maintain backwards compat quite painful for upstreaming)
> 
> Given that the firmware already hands the kernel's DT back to the
> kernel, it seems like we should be able to load the kernel's DT too if
> we wanted that.

You mean the DT modified by the firmware according to config.txt, at least 
applying the specified DT overlays?

Kind regards,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034 mobile: +49 151 50412019
work: +49 2405 49936-424
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-06 Thread Eric Anholt
Alexander Graf  writes:

>> Am 05.10.2016 um 18:48 schrieb Fabian Vogt :
>> 
>> Hi,
>> 
>> Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
>>> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
 This patch series modifies the used drivers to work with OF_CONTROL
 and switches the board code and configs to use it.
 The added device trees are directly from the linux kernel tree
 and can thus be used for booting the (upstream) kernel.
>>> 
>>> Is there a user-visible or developer-visible benefit to this change? In 
>>> general, converting to use DT to instantiate devices simply ends up 
>>> using more code (and hence complexity and time) to get to the exact same 
>>> state afterwards.
>> 
>> There are various reasons, like:
>> 
>> - The device tree describes the platform, so it can also be used by the
>>  linux kernel for configuration (no separate dtb needed)
>
> With a bit of lobbying, we might even be able to get a working dt from
> the rpi firmware. That again would enable awesome things like hat
> support in u-boot :).

I can't imagine the firmware handing any DT off to the kernel other than
the one that's being shipped from whatever kernel is being loaded.
Being able to update the DT in lockstep with the kernel is very much
part of their process.  (This makes linux insisting that DT is ABI that
must maintain backwards compat quite painful for upstreaming)

Given that the firmware already hands the kernel's DT back to the
kernel, it seems like we should be able to load the kernel's DT too if
we wanted that.


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-05 Thread Alexander Graf


> Am 05.10.2016 um 18:48 schrieb Fabian Vogt :
> 
> Hi,
> 
> Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
>> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
>>> This patch series modifies the used drivers to work with OF_CONTROL
>>> and switches the board code and configs to use it.
>>> The added device trees are directly from the linux kernel tree
>>> and can thus be used for booting the (upstream) kernel.
>> 
>> Is there a user-visible or developer-visible benefit to this change? In 
>> general, converting to use DT to instantiate devices simply ends up 
>> using more code (and hence complexity and time) to get to the exact same 
>> state afterwards.
> 
> There are various reasons, like:
> 
> - The device tree describes the platform, so it can also be used by the
>  linux kernel for configuration (no separate dtb needed)

With a bit of lobbying, we might even be able to get a working dt from the rpi 
firmware. That again would enable awesome things like hat support in u-boot :).


Alex

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-05 Thread Simon Glass
+Tom too

On 5 October 2016 at 10:48, Fabian Vogt  wrote:
> Hi,
>
> Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
>> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
>> > This patch series modifies the used drivers to work with OF_CONTROL
>> > and switches the board code and configs to use it.
>> > The added device trees are directly from the linux kernel tree
>> > and can thus be used for booting the (upstream) kernel.
>>
>> Is there a user-visible or developer-visible benefit to this change? In
>> general, converting to use DT to instantiate devices simply ends up
>> using more code (and hence complexity and time) to get to the exact same
>> state afterwards.
>
> There are various reasons, like:
>
> - The device tree describes the platform, so it can also be used by the
>   linux kernel for configuration (no separate dtb needed)
> - Properties are not hardcoded in the u-boot code
> - Slightly different hardware deviations do not require significant code
>   changes (like #ifdef or even new platdatas), just a new dts and Kconfig
>   adjustments
>
> It's also mentioned in Simon Glass's talk about DM:
> https://events.linuxfoundation.org/sites/events/files/slides/Order%20at%20last%20-%20U-Boot%20driver%20model%20slides%20(2).pdf
>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-05 Thread Fabian Vogt
Hi,

Am Mittwoch, 5. Oktober 2016, 09:54:46 CEST schrieb Stephen Warren:
> On 09/26/2016 06:26 AM, Fabian Vogt wrote:
> > This patch series modifies the used drivers to work with OF_CONTROL
> > and switches the board code and configs to use it.
> > The added device trees are directly from the linux kernel tree
> > and can thus be used for booting the (upstream) kernel.
> 
> Is there a user-visible or developer-visible benefit to this change? In 
> general, converting to use DT to instantiate devices simply ends up 
> using more code (and hence complexity and time) to get to the exact same 
> state afterwards.

There are various reasons, like:

- The device tree describes the platform, so it can also be used by the
  linux kernel for configuration (no separate dtb needed)
- Properties are not hardcoded in the u-boot code
- Slightly different hardware deviations do not require significant code
  changes (like #ifdef or even new platdatas), just a new dts and Kconfig
  adjustments

It's also mentioned in Simon Glass's talk about DM:
https://events.linuxfoundation.org/sites/events/files/slides/Order%20at%20last%20-%20U-Boot%20driver%20model%20slides%20(2).pdf


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-10-05 Thread Stephen Warren

On 09/26/2016 06:26 AM, Fabian Vogt wrote:

This patch series modifies the used drivers to work with OF_CONTROL
and switches the board code and configs to use it.
The added device trees are directly from the linux kernel tree
and can thus be used for booting the (upstream) kernel.


Is there a user-visible or developer-visible benefit to this change? In 
general, converting to use DT to instantiate devices simply ends up 
using more code (and hence complexity and time) to get to the exact same 
state afterwards.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 0/9] Switch bcm283x platform to use OF_CONTROL

2016-09-26 Thread Fabian Vogt
This patch series modifies the used drivers to work with OF_CONTROL
and switches the board code and configs to use it.
The added device trees are directly from the linux kernel tree
and can thus be used for booting the (upstream) kernel.

Fabian Vogt (9):
  gpio: bcm2835: add device tree support
  serial: bcm283x_mu: add device tree support
  serial: pl01x: expose skip_init platdata option in DT
  fdt: add dt-bindings for bcm2835
  fdt: import bcm283x device tree sources from the linux kernel tree
  fdt: adjust bcm283x device tree for u-boot
  serial: bcm283x_mu: support disabling after initialization
  board: rpi: move uart deactivation to board_init
  ARM: bcm283x: use OF_CONTROL for bcm283x

 arch/arm/Kconfig   |   1 +
 arch/arm/dts/Makefile  |   9 +
 arch/arm/dts/bcm2835-rpi-a-plus.dts|  35 +++
 arch/arm/dts/bcm2835-rpi-a.dts |  28 ++
 arch/arm/dts/bcm2835-rpi-b-plus.dts|  36 +++
 arch/arm/dts/bcm2835-rpi-b-rev2.dts|  29 ++
 arch/arm/dts/bcm2835-rpi-b.dts |  23 ++
 arch/arm/dts/bcm2835-rpi.dtsi  |  86 ++
 arch/arm/dts/bcm2835.dtsi  |  25 ++
 arch/arm/dts/bcm2836-rpi-2-b.dts   |  40 +++
 arch/arm/dts/bcm2836.dtsi  |  78 +
 arch/arm/dts/bcm2837-rpi-3-b.dts   |  30 ++
 arch/arm/dts/bcm2837.dtsi  |  76 +
 arch/arm/dts/bcm283x-rpi-smsc9512.dtsi |  19 ++
 arch/arm/dts/bcm283x-rpi-smsc9514.dtsi |  19 ++
 arch/arm/dts/bcm283x-uboot.dtsi|  22 ++
 arch/arm/dts/bcm283x.dtsi  | 323 +
 board/raspberrypi/rpi/rpi.c|  77 ++---
 configs/rpi_2_defconfig|   2 +
 configs/rpi_3_32b_defconfig|   2 +
 configs/rpi_3_defconfig|   2 +
 configs/rpi_defconfig  |   2 +
 doc/device-tree-bindings/gpio/bcm2835-gpio.txt |   5 +
 .../serial/bcm2835-aux-uart.txt|  10 +
 doc/device-tree-bindings/serial/pl01x.txt  |   3 +
 drivers/gpio/bcm2835_gpio.c|  24 ++
 drivers/serial/serial_bcm283x_mu.c |  46 ++-
 drivers/serial/serial_pl01x.c  |   2 +
 include/configs/rpi.h  |   1 -
 include/dt-bindings/clock/bcm2835-aux.h|  17 ++
 include/dt-bindings/clock/bcm2835.h|  66 +
 include/dt-bindings/pinctrl/bcm2835.h  |  27 ++
 include/dt-bindings/power/raspberrypi-power.h  |  41 +++
 33 files changed, 1152 insertions(+), 54 deletions(-)
 create mode 100644 arch/arm/dts/bcm2835-rpi-a-plus.dts
 create mode 100644 arch/arm/dts/bcm2835-rpi-a.dts
 create mode 100644 arch/arm/dts/bcm2835-rpi-b-plus.dts
 create mode 100644 arch/arm/dts/bcm2835-rpi-b-rev2.dts
 create mode 100644 arch/arm/dts/bcm2835-rpi-b.dts
 create mode 100644 arch/arm/dts/bcm2835-rpi.dtsi
 create mode 100644 arch/arm/dts/bcm2835.dtsi
 create mode 100644 arch/arm/dts/bcm2836-rpi-2-b.dts
 create mode 100644 arch/arm/dts/bcm2836.dtsi
 create mode 100644 arch/arm/dts/bcm2837-rpi-3-b.dts
 create mode 100644 arch/arm/dts/bcm2837.dtsi
 create mode 100644 arch/arm/dts/bcm283x-rpi-smsc9512.dtsi
 create mode 100644 arch/arm/dts/bcm283x-rpi-smsc9514.dtsi
 create mode 100644 arch/arm/dts/bcm283x-uboot.dtsi
 create mode 100644 arch/arm/dts/bcm283x.dtsi
 create mode 100644 doc/device-tree-bindings/gpio/bcm2835-gpio.txt
 create mode 100644 doc/device-tree-bindings/serial/bcm2835-aux-uart.txt
 create mode 100644 include/dt-bindings/clock/bcm2835-aux.h
 create mode 100644 include/dt-bindings/clock/bcm2835.h
 create mode 100644 include/dt-bindings/pinctrl/bcm2835.h
 create mode 100644 include/dt-bindings/power/raspberrypi-power.h

-- 
2.6.2

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot