Re: [U-Boot] [PATCH 013/126] dm: test: Correct a stray backslash in dm_test_destroy()
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > This should perhaps be a period but it is not necessary. Remove it. > > > > Signed-off-by: Simon Glass > > --- > > > > test/dm/test-main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/dm/test-main.c b/test/dm/test-main.c > > index 74f77ccc849..c944ab9c5f2 100644 > > --- a/test/dm/test-main.c > > +++ b/test/dm/test-main.c > > @@ -64,7 +64,7 @@ static int dm_test_destroy(struct unit_test_state *uts) > > > > /* > > * If the uclass doesn't exist we don't want to create it. > > So > > -* check that here before we call uclass_find_device()/ > > +* check that here before we call uclass_find_device() > > I tend to use a period since it's a complete sentence. Added the ending period, reworded the commit message, and > > > */ > > uc = uclass_find(id); > > if (!uc) > > -- > > Reviewed-by: Bin Meng applied to u-boot-x86/next, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 013/126] dm: test: Correct a stray backslash in dm_test_destroy()
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > This should perhaps be a period but it is not necessary. Remove it. > > Signed-off-by: Simon Glass > --- > > test/dm/test-main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/dm/test-main.c b/test/dm/test-main.c > index 74f77ccc849..c944ab9c5f2 100644 > --- a/test/dm/test-main.c > +++ b/test/dm/test-main.c > @@ -64,7 +64,7 @@ static int dm_test_destroy(struct unit_test_state *uts) > > /* > * If the uclass doesn't exist we don't want to create it. So > -* check that here before we call uclass_find_device()/ > +* check that here before we call uclass_find_device() I tend to use a period since it's a complete sentence. > */ > uc = uclass_find(id); > if (!uc) > -- Reviewed-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 013/126] dm: test: Correct a stray backslash in dm_test_destroy()
This should perhaps be a period but it is not necessary. Remove it. Signed-off-by: Simon Glass --- test/dm/test-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/dm/test-main.c b/test/dm/test-main.c index 74f77ccc849..c944ab9c5f2 100644 --- a/test/dm/test-main.c +++ b/test/dm/test-main.c @@ -64,7 +64,7 @@ static int dm_test_destroy(struct unit_test_state *uts) /* * If the uclass doesn't exist we don't want to create it. So -* check that here before we call uclass_find_device()/ +* check that here before we call uclass_find_device() */ uc = uclass_find(id); if (!uc) -- 2.23.0.444.g18eeb5a265-goog ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
