Re: [U-Boot] [PATCH 019/126] sandbox: swap_case: Use statics where possible

[Bin Meng]

On Sat, Oct 5, 2019 at 10:01 AM Bin Meng  wrote:
>
> On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
> >
> > Some functions and a struct should be marked static since they are not
> > used outside this file. Update them.
> >
> > Signed-off-by: Simon Glass 
> > ---
> >
> >  drivers/misc/swap_case.c | 10 +-
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Bin Meng 

applied to u-boot-x86/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 019/126] sandbox: swap_case: Use statics where possible

[Bin Meng]

On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
>
> Some functions and a struct should be marked static since they are not
> used outside this file. Update them.
>
> Signed-off-by: Simon Glass 
> ---
>
>  drivers/misc/swap_case.c | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 019/126] sandbox: swap_case: Use statics where possible

[Simon Glass]

Some functions and a struct should be marked static since they are not
used outside this file. Update them.

Signed-off-by: Simon Glass 
---

 drivers/misc/swap_case.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/swap_case.c b/drivers/misc/swap_case.c
index eb32d101f96..8abf88a8fff 100644
--- a/drivers/misc/swap_case.c
+++ b/drivers/misc/swap_case.c
@@ -286,8 +286,8 @@ static void sandbox_swap_case_do_op(enum swap_case_op op, 
char *str, int len)
}
 }
 
-int sandbox_swap_case_read_io(struct udevice *dev, unsigned int addr,
- ulong *valuep, enum pci_size_t size)
+static int sandbox_swap_case_read_io(struct udevice *dev, unsigned int addr,
+ulong *valuep, enum pci_size_t size)
 {
struct swap_case_priv *priv = dev_get_priv(dev);
unsigned int offset;
@@ -304,8 +304,8 @@ int sandbox_swap_case_read_io(struct udevice *dev, unsigned 
int addr,
return 0;
 }
 
-int sandbox_swap_case_write_io(struct udevice *dev, unsigned int addr,
-  ulong value, enum pci_size_t size)
+static int sandbox_swap_case_write_io(struct udevice *dev, unsigned int addr,
+ ulong value, enum pci_size_t size)
 {
struct swap_case_priv *priv = dev_get_priv(dev);
unsigned int offset;
@@ -392,7 +392,7 @@ static int sandbox_swap_case_unmap_physmem(struct udevice 
*dev,
return 0;
 }
 
-struct dm_pci_emul_ops sandbox_swap_case_emul_ops = {
+static struct dm_pci_emul_ops sandbox_swap_case_emul_ops = {
.get_devfn = sandbox_swap_case_get_devfn,
.read_config = sandbox_swap_case_read_config,
.write_config = sandbox_swap_case_write_config,
-- 
2.23.0.444.g18eeb5a265-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot