Re: [U-Boot] [PATCH 020/126] sandbox: pci: Drop the get_devfn() method

[Bin Meng]

On Sat, Oct 5, 2019 at 10:01 AM Bin Meng  wrote:
>
> On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
> >
> > This method is not used anymore since the bus/device/function of PCI
> > devices can be obtained from their (parent's per-child) platform data.
> > Drop it.
> >
> > Signed-off-by: Simon Glass 
> > ---
> >
> >  drivers/misc/swap_case.c | 8 
> >  include/pci.h| 7 ---
> >  2 files changed, 15 deletions(-)
> >
>
> Reviewed-by: Bin Meng 

applied to u-boot-x86/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 020/126] sandbox: pci: Drop the get_devfn() method

[Bin Meng]

On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
>
> This method is not used anymore since the bus/device/function of PCI
> devices can be obtained from their (parent's per-child) platform data.
> Drop it.
>
> Signed-off-by: Simon Glass 
> ---
>
>  drivers/misc/swap_case.c | 8 
>  include/pci.h| 7 ---
>  2 files changed, 15 deletions(-)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 020/126] sandbox: pci: Drop the get_devfn() method

[Simon Glass]

This method is not used anymore since the bus/device/function of PCI
devices can be obtained from their (parent's per-child) platform data.
Drop it.

Signed-off-by: Simon Glass 
---

 drivers/misc/swap_case.c | 8 
 include/pci.h| 7 ---
 2 files changed, 15 deletions(-)

diff --git a/drivers/misc/swap_case.c b/drivers/misc/swap_case.c
index 8abf88a8fff..18d756e9cd5 100644
--- a/drivers/misc/swap_case.c
+++ b/drivers/misc/swap_case.c
@@ -54,13 +54,6 @@ struct swap_case_priv {
char mem_text[MEM_TEXT_SIZE];
 };
 
-static int sandbox_swap_case_get_devfn(struct udevice *dev)
-{
-   struct pci_child_platdata *plat = dev_get_parent_platdata(dev);
-
-   return plat->devfn;
-}
-
 static int sandbox_swap_case_use_ea(struct udevice *dev)
 {
return !!ofnode_get_property(dev->node, "use-ea", NULL);
@@ -393,7 +386,6 @@ static int sandbox_swap_case_unmap_physmem(struct udevice 
*dev,
 }
 
 static struct dm_pci_emul_ops sandbox_swap_case_emul_ops = {
-   .get_devfn = sandbox_swap_case_get_devfn,
.read_config = sandbox_swap_case_read_config,
.write_config = sandbox_swap_case_write_config,
.read_io = sandbox_swap_case_read_io,
diff --git a/include/pci.h b/include/pci.h
index 298d0d43559..999a594cddf 100644
--- a/include/pci.h
+++ b/include/pci.h
@@ -1490,13 +1490,6 @@ int dm_pci_find_class(uint find_class, int index, struct 
udevice **devp);
  * struct dm_pci_emul_ops - PCI device emulator operations
  */
 struct dm_pci_emul_ops {
-   /**
-* get_devfn(): Check which device and function this emulators
-*
-* @dev:device to check
-* @return the device and function this emulates, or -ve on error
-*/
-   int (*get_devfn)(struct udevice *dev);
/**
 * read_config() - Read a PCI configuration value
 *
-- 
2.23.0.444.g18eeb5a265-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot