Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii
Joe, > On 14 Jun 2018, at 20:26, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich > wrote: >> >>> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: >>> >>> On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann >>> wrote: We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() to enable the RX delay. The MASK was used in a wrong way. Signed-off-by: Janine Hagemann >>> >>> Acked-by: Joe Hershberger >> >> Reviewed-by: Philipp Tomsich > > I assume I should take this series? Or would you prefer to? I’ll take these as part of the larger series. Thanks, Philipp. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii
On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich wrote: > >> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: >> >> On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann >> wrote: >>> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >>> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >>> to enable the RX delay. >>> The MASK was used in a wrong way. >>> >>> Signed-off-by: Janine Hagemann >> >> Acked-by: Joe Hershberger > > Reviewed-by: Philipp Tomsich I assume I should take this series? Or would you prefer to? -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii
> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann wrote: >> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >> to enable the RX delay. >> The MASK was used in a wrong way. >> >> Signed-off-by: Janine Hagemann > > Acked-by: Joe Hershberger Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii
On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann wrote: > We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of > RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() > to enable the RX delay. > The MASK was used in a wrong way. > > Signed-off-by: Janine Hagemann Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii
We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() to enable the RX delay. The MASK was used in a wrong way. Signed-off-by: Janine Hagemann --- drivers/net/gmac_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gmac_rockchip.c b/drivers/net/gmac_rockchip.c index 30a24d1..0f91731 100644 --- a/drivers/net/gmac_rockchip.c +++ b/drivers/net/gmac_rockchip.c @@ -350,7 +350,7 @@ static void rk3328_gmac_set_to_rgmii(struct gmac_rockchip_platdata *pdata) RK3328_RXCLK_DLY_ENA_GMAC_MASK | RK3328_TXCLK_DLY_ENA_GMAC_MASK, RK3328_GMAC_PHY_INTF_SEL_RGMII | -RK3328_RXCLK_DLY_ENA_GMAC_MASK | +RK3328_RXCLK_DLY_ENA_GMAC_ENABLE | RK3328_TXCLK_DLY_ENA_GMAC_ENABLE); rk_clrsetreg(>mac_con[0], -- 2.7.4 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
