Re: [U-Boot] [PATCH 03/30] x86: Add debugging when cpu_common_init() fails

2016-08-28 Thread Bin Meng 
On Thu, Jul 28, 2016 at 2:53 PM, Bin Meng  wrote:
> On Tue, Jul 26, 2016 at 8:58 AM, Simon Glass  wrote:
>> Add a debug() at this point to help figure out what is wrong.
>>
>> Signed-off-by: Simon Glass 
>> ---
>>
>>  arch/x86/cpu/ivybridge/cpu.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng 

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 03/30] x86: Add debugging when cpu_common_init() fails

2016-07-28 Thread Bin Meng 
On Tue, Jul 26, 2016 at 8:58 AM, Simon Glass  wrote:
> Add a debug() at this point to help figure out what is wrong.
>
> Signed-off-by: Simon Glass 
> ---
>
>  arch/x86/cpu/ivybridge/cpu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 03/30] x86: Add debugging when cpu_common_init() fails

2016-07-25 Thread Simon Glass 
Add a debug() at this point to help figure out what is wrong.

Signed-off-by: Simon Glass 
---

 arch/x86/cpu/ivybridge/cpu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/cpu/ivybridge/cpu.c b/arch/x86/cpu/ivybridge/cpu.c
index 0f93905..85e361a 100644
--- a/arch/x86/cpu/ivybridge/cpu.c
+++ b/arch/x86/cpu/ivybridge/cpu.c
@@ -146,8 +146,10 @@ int print_cpuinfo(void)
}
 
ret = cpu_common_init();
-   if (ret)
+   if (ret) {
+   debug("%s: cpu_common_init() failed\n", __func__);
return ret;
+   }
 
/* Check PM1_STS[15] to see if we are waking from Sx */
pm1_sts = inw(DEFAULT_PMBASE + PM1_STS);
-- 
2.8.0.rc3.226.g39d4020

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot